Received-SPF: pass (google.com: domain of linux-kernel+bounces-121400-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
To: Arnd Bergmann <arnd@kernel.org>,
        "llvm@lists.linux.dev"
	<llvm@lists.linux.dev>,
        Ariel Elior <aelior@marvell.com>, Manish Chopra
	<manishc@marvell.com>
CC: Arnd Bergmann <arnd@arndb.de>, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo
 Abeni <pabeni@redhat.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick
 Desaulniers <ndesaulniers@google.com>,
        Bill Wendling <morbo@google.com>,
        Justin Stitt <justinstitt@google.com>, Simon Horman <horms@kernel.org>,
        Konstantin Khorenko <khorenko@virtuozzo.com>,
        Sudarsana Reddy Kalluru
	<sudarsana.kalluru@cavium.com>,
        "netdev@vger.kernel.org"
	<netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] [PATCH 3/9] qed: avoid truncating work queue length
Thread-Topic: [EXTERNAL] [PATCH 3/9] qed: avoid truncating work queue length
Thread-Index: AQHagCfC+qakUE/9NUWNrCxJqKFS87FLnkwQ
Date: Wed, 27 Mar 2024 14:04:08 +0000
Message-ID: 
 <CO1PR18MB4666DF3B7684D340C3A3646DA1342@CO1PR18MB4666.namprd18.prod.outlook.com>
References: <20240326223825.4084412-1-arnd@kernel.org>
 <20240326223825.4084412-4-arnd@kernel.org>
In-Reply-To: <20240326223825.4084412-4-arnd@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?i0fYQOqlFzAJCI2T6999OiIEFbs6aKK0zobenp/Y3BNe6b9nS1PvXsiDlXdW?=
 =?us-ascii?Q?k6O7NAnFqXOPDvNh0ZXg5b9B/HqUuaiG+ICvIfA2+1fqDG7eHIivyHIKpW4M?=
 =?us-ascii?Q?HoIjwEoWJlbf+f73nzGSe3x62gNGUfA/eF2/NQ6WtKYVJs5jWlDA9gamx/ew?=
 =?us-ascii?Q?18RN0jQADxYWLvtK26B99qrfX4hZhvN8CcFmoVEGiDgOakOfjVNYFv5Oes83?=
 =?us-ascii?Q?bf3zk/+DNV9OqoqFKGadQzkPIZ0BOsyKec+JTN9VryXzH7SUagbMhtY4oF1O?=
 =?us-ascii?Q?dI/z6DTgwvkkUvIpaj+aYFfR7Fd+oTim2/jq78dSei2KXk5NoBRuEqSbHNxZ?=
 =?us-ascii?Q?t6VIQ4pdvsaXdD+NALCzKFtOfr2zm4xI5GkObuQx7P6/ZiA+qdOE27lNLJXI?=
 =?us-ascii?Q?XOUbcdLFb0U8h7lAowLW7FKJJlTw0e+rSw0e+ExJsc0ciiOoo+RPqlOq/XMP?=
 =?us-ascii?Q?P1/ROnrrxJcKzxJizwQOZVwIeFPApRWQblpL2WmqR1NMCnA4IIxZiDMWkyiS?=
 =?us-ascii?Q?OhECy0B0BHvVSpkMHjpQy4u/I4lxDOshT5kJRZ6D54c0X3vDXvtKWY34IVk/?=
 =?us-ascii?Q?/dkuC0CJWB3bvBzGVMebqCipi/r5tOiNvUFk6Nay1DY3WT90hgHlqLB0TZQd?=
 =?us-ascii?Q?PCLQeerCrw8TQRBTMoWZszjWNWg7VEj+iIUX3xFffLKsyR4RWJEa7jMrwsAa?=
 =?us-ascii?Q?IIEnwYANUm9xSyc6dbr4Kx/DZn3LsWRl+775EZmQwncL9ZzQKXg3UzMZHQ6w?=
 =?us-ascii?Q?p+ypq9Bj/OX+RlnSIRT8kcjUsG31F5S/jQjjjDp9cj23suy/R6H1pKfh/IJN?=
 =?us-ascii?Q?fmAIL//XBCK4u13NxQoKoPty2Fb39Ju5W/RgzSkf+QxIUtR7ButfsEJnN+10?=
 =?us-ascii?Q?mqFNDrEJ5s0S6kzm0DrSoiZHL7U/t4UQJIIO1vUMLsX2Ko0q+2s7WnDd8AAI?=
 =?us-ascii?Q?xrPjx8yBxcrVkp87pgiXUikg5vMFLfjzLAiXwkzYT/oH7bF1dZnzutogY/Uu?=
 =?us-ascii?Q?ZfGTzsIw+/7dIHk5JfDbmUnHSFfvO28/8nzjFu1gN+cH37QWuCGhMmlQJHQR?=
 =?us-ascii?Q?3yXugrUWXYRmrgUC3YXMjzwBzFy8e+/6dB7XWKU+tegPsCynWBw6b8Cepuh8?=
 =?us-ascii?Q?2jPV8O4Ubju1f8bO6SoCkWOcxV8R44Iyo1/1s4bAx5IFNFpid3rSKpZ5wavs?=
 =?us-ascii?Q?kuvSuDbhBE0yQTmKzbKs19mN+VinPxaNIwNdFx9rA2tOBMAWBX2q3Ygphew+?=
 =?us-ascii?Q?j73PGuHFfEy4NKExZmMU0bykMhtOlIc9//6MLBMeN7kW6jgnzYj68wk5QVQv?=
 =?us-ascii?Q?ZxuKxACV40EIc7Ep7oZd9NozKivff8ycPS6MzEaSz2H7S9gAl8geHhjijSCE?=
 =?us-ascii?Q?GvE+fhTe2wJedUYMW3Sa05hWTWfZRQjWgJ7ZR+fuSxLf9Bzo9WX76Geug6Rg?=
 =?us-ascii?Q?xDvJb/EGVtXPkemSwQ3L61ZLL1DZ7awEdBe3CQfKZoW87LRA4E9+uLntynRI?=
 =?us-ascii?Q?+CZwEbBEezTxZu2aEIRPdUVIr5ab6LbbZmQwWbt6hM0RLb/ZvOABiNXMK7ei?=
 =?us-ascii?Q?+Rf2GnQi2EsezR3wOAFsWI96p0crGXrDiBzheKkO?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4666.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26483821-bf97-44d2-a348-08dc4e66c58f
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 14:04:08.7499
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yNVxVMz2udKX3VWn9TeEnT6fv404dwBsv3ZWCvDNVHOAeRhzNMI3zQaUodicATWr6oslrZLj8ZjvvLMqTrxGQw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR18MB4405
X-Proofpoint-ORIG-GUID: CbGQTm4YubvupUOoGgPWobDcKzulcOkm
X-Proofpoint-GUID: CbGQTm4YubvupUOoGgPWobDcKzulcOkm
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-27_08,2024-03-27_01,2023-05-22_02

Hi,

>-----Original Message-----
>From: Arnd Bergmann <arnd@kernel.org>
>Sent: Wednesday, March 27, 2024 4:08 AM
>To: llvm@lists.linux.dev; Ariel Elior <aelior@marvell.com>; Manish Chopra
><manishc@marvell.com>
>Cc: Arnd Bergmann <arnd@arndb.de>; David S. Miller <davem@davemloft.net>;
>Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paol=
o
>Abeni <pabeni@redhat.com>; Nathan Chancellor <nathan@kernel.org>; Nick
>Desaulniers <ndesaulniers@google.com>; Bill Wendling <morbo@google.com>;
>Justin Stitt <justinstitt@google.com>; Simon Horman <horms@kernel.org>;
>Konstantin Khorenko <khorenko@virtuozzo.com>; Sudarsana Reddy Kalluru
><sudarsana.kalluru@cavium.com>; netdev@vger.kernel.org; linux-
>kernel@vger.kernel.org
>Subject: [PATCH 3/9] qed: avoid truncating work queue length
>
>From: Arnd Bergmann <arnd@arndb.de>
>
>clang complains that the temporary string for the name passed into
>alloc_workqueue() is too short for its contents:
>
>drivers/net/ethernet/qlogic/qed/qed_main.c:1218:3: error: 'snprintf' will =
always
>be truncated; specified size is 16, but format string expands to at least =
18 [-
>Werror,-Wformat-truncation]
>
>There is no need for a temporary buffer, and the actual name of a workqueu=
e=09
>is 32 bytes (WQ_NAME_LEN), so just use the interface as intended to avoid
>the truncation.
>
>Fixes: 59ccf86fe69a ("qed: Add driver infrastucture for handling mfw reque=
sts.")
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>---
> drivers/net/ethernet/qlogic/qed/qed_main.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c
>b/drivers/net/ethernet/qlogic/qed/qed_main.c
>index c278f8893042..8159b4c315b5 100644
>--- a/drivers/net/ethernet/qlogic/qed/qed_main.c
>+++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
>@@ -1206,7 +1206,6 @@ static void qed_slowpath_task(struct work_struct
>*work)
> static int qed_slowpath_wq_start(struct qed_dev *cdev)
> {
> 	struct qed_hwfn *hwfn;
>-	char name[NAME_SIZE];
> 	int i;
>
> 	if (IS_VF(cdev))
>@@ -1215,11 +1214,11 @@ static int qed_slowpath_wq_start(struct qed_dev
>*cdev)
> 	for_each_hwfn(cdev, i) {
> 		hwfn =3D &cdev->hwfns[i];
>
>-		snprintf(name, NAME_SIZE, "slowpath-%02x:%02x.%02x",
>-			 cdev->pdev->bus->number,
>-			 PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id);
>+		hwfn->slowpath_wq =3D alloc_workqueue("slowpath-
>%02x:%02x.%02x",
>+					 0, 0, cdev->pdev->bus->number,
>+					 PCI_SLOT(cdev->pdev->devfn),
>+					 hwfn->abs_pf_id);

Confused. This should be alloc_workqueue("slowpath-%02x:%02x.%02x",  cdev->=
pdev->bus->number, PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id, 0, 0);
Right?

Thanks,
Sundeep
>
>-		hwfn->slowpath_wq =3D alloc_workqueue(name, 0, 0);
> 		if (!hwfn->slowpath_wq) {
> 			DP_NOTICE(hwfn, "Cannot create slowpath
>workqueue\n");
> 			return -ENOMEM;
>--
>2.39.2
>