Received-SPF: pass (google.com: domain of linux-kernel+bounces-121362-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 27 Mar 2024 14:25:06 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Konrad Dybcio <konradybcio@kernel.org>, 
	Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] power: supply: test-power: implement charge_behaviour
 property
Message-ID: <daactalkmzucga47cmncjkgnxyppouqnrj3vtsz34d5edrkmzu@p32ylpv3nqwx>
References: <20240306-power_supply-charge_behaviour_prop-v3-1-d04cf1f5f0af@weissschuh.net>
 <171148264419.185695.14027540198251584096.b4-ty@collabora.com>
 <6f0761a6-5f49-42e2-9b79-3e04c9d259a4@redhat.com>
 <9fe3d7a6-3b34-4c96-bd9f-510b41f9ab0d@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="giotfuwncs36wkgs"
Content-Disposition: inline
In-Reply-To: <9fe3d7a6-3b34-4c96-bd9f-510b41f9ab0d@redhat.com>


--giotfuwncs36wkgs
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Hans,

On Wed, Mar 27, 2024 at 11:44:41AM +0100, Hans de Goede wrote:
> On 3/27/24 11:36 AM, Hans de Goede wrote:
> > On 3/26/24 8:50 PM, Sebastian Reichel wrote:
> >> On Wed, 06 Mar 2024 20:37:04 +0100, Thomas Wei=DFschuh wrote:
> >>> To validate the special formatting of the "charge_behaviour" sysfs
> >>> property add it to the example driver.
> >>
> >> Applied, thanks!
> >>
> >> [1/1] power: supply: test-power: implement charge_behaviour property
> >>       commit: 070c1470ae24317e7b19bd3882b300b6d69922a4
> >=20
> > Does this mean that you've also applied patches 1-3 of:
> > "[PATCH v2 0/4] power: supply: core: align charge_behaviour format with=
 docs" ?
> >=20
> > Because this is a new version of 4/4 of that series and I think
> > that the new test may depend on the fixes from patches 1-3
> > of that series (which I'm reviewing now).
>=20
> Ok, I have some not entirely trivial comments on patch 3/4 of that series.
> I guess you (Sebastian) could address those while merging, or wait for
> a v3 of the series.

I can't. Patches 1-3 are already in 6.9-rc1. It looks you did not
get my replies, but they certainly have been captured by lore and
obviously Thomas got them since he send a v3 with just the last
patch:

https://lore.kernel.org/all/20240303-power_supply-charge_behaviour_prop-v2-=
0-8ebb0a7c2409@weissschuh.net/

Anyways, I think your suggestions for further simplifications in
patch 3 are sensible. They just require doing an extra patch now
instead of being squashed.

Greetings,

-- Sebastian

--giotfuwncs36wkgs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmYEHioACgkQ2O7X88g7
+pqQnw//To7k/fV34WTlIy3RJYrPP9jiW3FUJc9rqM+qICHvpglsyhiIh//Zcl9G
9CbZJ0xRXnS36ynoZhG5qsgAT3Uk4nTVN55xe/gUBMRRZoSPvoV+1L16fA+jEmpX
5OtcGotIn9Vk/J3EGrwmFn4OdnSNKV0ek8w/k8aE5W2rPeIrMddNOqxm35t4mgZ4
llaBFDrFGe8pg1MBo/h2mJkgo/62T/C5vOYe93uqtfkkwreTOBYzAkp9wJodXrmf
kq7NaSVCr92WKoYbczmSH2OV5n2YaHO1IMVWs1OJYz+EAitFP+LcttYhICBsKyhr
KMCD7jTQLggM/zIeW/gtUo6L+NsFc85ufmAo14fQYYRWnQQCv7pCLA7d7qyHLSO3
6oVKk2s3Af8UslRWPu3kQG+Kg5gR8F2IENI89s57lfwwt0qiV65EPAzJIiENplRt
fBn1rXhw5W/Jo7txIUGYvp4ggP0OYwA0hQbPhbS5qg0uNLsAHW/h/oAJleKi7qMv
HASgR7dfXZFxQ0RQRheKgfVe1qfJpUnYt/YpJPFXP9AGV9Pqc/prIMG2Lb5LdHEt
UTvr2nK2sK3tpZuRAzJ8lmVOVltOiUlZbfX8T7x0KqsK2q/JYeo0fjBkHCrp4R4q
JsmXFtYXbmXuTXD47SuBqCjO1MdTAC8A7sM1DJrmq7i17qSocrk=
=E25x
-----END PGP SIGNATURE-----

--giotfuwncs36wkgs--