Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp109046lqo; Wed, 27 Mar 2024 08:11:07 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU1MmcQXCBYDPT2VvZdt2XdfDhbCnB5m+dxs/WNqbV4baqgwdz6gilxZ1CyuM6f7z5fZP+lzu91HqoJxvJTvoBPurDiwJYRqvm+nsUpHw== X-Google-Smtp-Source: AGHT+IETSOF2Z2Q7M61G2verDASCGoAzuAtSoAOUXst1dEY3J5rgOfuB76ytF17DuTLeu9mUR+SJ X-Received: by 2002:a05:6830:155:b0:6e6:ded0:8a69 with SMTP id j21-20020a056830015500b006e6ded08a69mr45252otp.31.1711552266858; Wed, 27 Mar 2024 08:11:06 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711552266; cv=pass; d=google.com; s=arc-20160816; b=HOxp/NRgJII91sciQKfWtF+hncrmqwkMOL6L+SmKbjaq0i7TqzrbFQdMQHCe4RwN3r 3NnKwXEmtRVDTsfmBVZ0EMI+bXvU6wk30UxVOyC17+QI00Wgaabuf6QrN0Aew4zZuH1i 36xHRkgt99pCvJrorRy7gL+oCoMbXYSQcr37UEgR7kIHwdubVDr1YHXYYjFCt0yX+q89 JbWc1HSFnLtgQsKgWV0MXQr+ubeIIXAKRcv7584FackZAGV8y2BvSbd7h8Gjmiyc3HCZ JhQyLn8VW4rtvaaP5njm/uZIBCrggWna2l5heZpzmaZhud/Lkwaxq8J20QEnOgutW6pV yZXA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5bdXps+t1i8xgjPfuY6oGSadm5VQnIbnnHtugNr1z3Q=; fh=fVNPnFzZHqXOZZaWZyliVEmn6/AMd0Czyy+wigMFxHM=; b=w1/ol2PXPMLo9t2Ap1C+pcPxlGvsSIM4D0xjCR9lfJzYNqiU5YZ7WHEN9U+ToxHScE 7uc4BWuh0T/d16HSyFV5jFLrmccagcDIhL2ij2gotqaWjsRr6+XCAhpLzB6ak5SJjZve Dd8cey0cmzy+V/net1ulQLhea7y2DZB/09bk5O3tlASLFG60iyEqrAVNtGwZWn5nm7hA 1NElC9ktCmPbI7XHvQ7dUfm5lpEh0PjPWhmvynBAms3/6XmcHyw2vNaOD8EZ7ZtdDN2/ G1UoGrSvGtmGNecpOMu4N9kPC7mTha3U1XDjpOeYIWczvtl/cmllSVHI+JpdzV91rpWX KphQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LtEJdsCC; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-121448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121448-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id kd23-20020a056214401700b00696aca23f43si1534150qvb.166.2024.03.27.08.11.06 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:11:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=LtEJdsCC; arc=pass (i=1 dkim=pass dkdomain=linuxfoundation.org); spf=pass (google.com: domain of linux-kernel+bounces-121448-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121448-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 8FACE1C2F829 for ; Wed, 27 Mar 2024 15:11:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4053C1494DA; Wed, 27 Mar 2024 14:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="LtEJdsCC" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 50A341494AC; Wed, 27 Mar 2024 14:37:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711550225; cv=none; b=KovbBO1/CgxuyEFIgEVNu1sevMW6ZC30X7iD6nk34hmXiNrHLwzjR61kY9UksyivHv7xfaE84W7JeYSk26vxdVYTj831VvAdAdHBCeu/x4qzvm24jCAW4zPuAG+pg1MX1xojGEI34RwmQ8g1NVHGEjJSwVTZdK5ChgpDZ1mz488= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711550225; c=relaxed/simple; bh=CNvTdSlrwsQbv/udDF8Dk7iqvTn3Y6HeV3CkmDU+yOs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iWtx4oAF16idl+FGVBu7TauhjBPjzLma4YnRrc707C97yMmZtBVrqSre/chd1B8+lmgjR+oXgxZKgd5ufWRSMcnoL9xhhodNbcIQeQPraAL74UNKDwQaHE40wa3BrXQpZvZtvTdXIOKXWjYNGaSAUgHzIpt+pXZ1LtOozg39P3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=LtEJdsCC; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 867B0C433F1; Wed, 27 Mar 2024 14:37:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1711550225; bh=CNvTdSlrwsQbv/udDF8Dk7iqvTn3Y6HeV3CkmDU+yOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LtEJdsCCdKpsltsQU6Ytj7X4C265OAerO6/JumdSuySgr+fi/PZIZV6fjzUF4+zj3 eIcOFw82FGggfERd9RGAZd8jPx9PPULtfnL7gW6UVoofpnZOOr3JJ9TmA+n7iSNWrG wxssgc1GiQiEHR+ljTQ8kSPLatxk/4kaZkwbP82s= Date: Wed, 27 Mar 2024 15:37:02 +0100 From: Greg Kroah-Hartman To: Shung-Hsi Yu Cc: linux-cve-announce@vger.kernel.org, cve@kernel.org, linux-kernel@vger.kernel.org Subject: Re: CVE-2023-52462: bpf: fix check for attempt to corrupt spilled pointer Message-ID: <2024032752-crave-emu-c82a@gregkh> References: <2024022335-CVE-2023-52462-b663@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Mar 05, 2024 at 11:41:52PM +0800, Shung-Hsi Yu wrote: > On Fri, Feb 23, 2024 at 03:47:35PM +0100, Greg Kroah-Hartman wrote: > > Description > > =========== > > > > In the Linux kernel, the following vulnerability has been resolved: > > > > bpf: fix check for attempt to corrupt spilled pointer > > > > When register is spilled onto a stack as a 1/2/4-byte register, we set > > slot_type[BPF_REG_SIZE - 1] (plus potentially few more below it, > > depending on actual spill size). So to check if some stack slot has > > spilled register we need to consult slot_type[7], not slot_type[0]. > > > > To avoid the need to remember and double-check this in the future, just > > use is_spilled_reg() helper. > > > > The Linux kernel CVE team has assigned CVE-2023-52462 to this issue. > > > > > > Affected and fixed versions > > =========================== > > > > Issue introduced in 5.10.163 with commit cdd73a5ed084 and fixed in 5.10.209 with commit 2757f17972d8 > > Issue introduced in 5.15.86 with commit 07c286c10a9c and fixed in 5.15.148 with commit 67e6707f0735 > > Issue introduced in 5.16 with commit 27113c59b6d0 and fixed in 6.1.75 with commit fc3e3c50a0a4 > > Issue introduced in 5.16 with commit 27113c59b6d0 and fixed in 6.6.14 with commit 8dc15b067059 > > Issue introduced in 5.16 with commit 27113c59b6d0 and fixed in 6.7.2 with commit 40617d45ea05 > > Issue introduced in 5.16 with commit 27113c59b6d0 and fixed in 6.8-rc1 with commit ab125ed3ec1c > > While commit 27113c59b6d0 ("bpf: Check the other end of slot_type for > STACK_SPILL") is referenced in the Fixes tag, and made the switch to use > slot_type[7] instead of slot_type[0]. This shouldn't cause any issue > because its commit message stated that > > ... Verifier currently only saves the reg state if the whole 8 bytes > are spilled to the stack, so checking the slot_type[7] is the same as > checking slot_type[0]. > > It is the next commit in the series, commit 354e8f1970f8 ("bpf: Support > <8-byte scalar spill and refill"), that rendered checking slot_type[0] > problematic. > > So I believe the issue is introduced with commit 354e8f1970f8 rather > than 27113c59b6d0. That said kernel releases seems to either contain > both or none of them at all, so in pratice the difference probably > doesn't matter too much. Thanks for the information! greg k-h > > > [snip] >