Received-SPF: pass (google.com: domain of linux-kernel+bounces-121356-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <e15019f54d26898e4b67b84c331cd52d09427258.camel@kernel.org>
Subject: Re: [PATCH v4 02/14] mm: Switch mm->get_unmapped_area() to a flag
From: Jarkko Sakkinen <jarkko@kernel.org>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
 "keescook@chromium.org" <keescook@chromium.org>, "luto@kernel.org"
 <luto@kernel.org>,  "dave.hansen@linux.intel.com"
 <dave.hansen@linux.intel.com>, "debug@rivosinc.com" <debug@rivosinc.com>, 
 "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
 "Liam.Howlett@oracle.com" <Liam.Howlett@oracle.com>, 
 "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
 "mingo@redhat.com" <mingo@redhat.com>,  "christophe.leroy@csgroup.eu"
 <christophe.leroy@csgroup.eu>, "tglx@linutronix.de" <tglx@linutronix.de>, 
 "hpa@zytor.com" <hpa@zytor.com>, "peterz@infradead.org"
 <peterz@infradead.org>, "bp@alien8.de" <bp@alien8.de>, "x86@kernel.org"
 <x86@kernel.org>, "broonie@kernel.org" <broonie@kernel.org>
Cc: "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>, 
 "linux-s390@vger.kernel.org"
	 <linux-s390@vger.kernel.org>, "linux-mm@kvack.org" <linux-mm@kvack.org>, 
 "linux-cxl@vger.kernel.org"
	 <linux-cxl@vger.kernel.org>, "sparclinux@vger.kernel.org"
	 <sparclinux@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	 <linux-kernel@vger.kernel.org>, "io-uring@vger.kernel.org"
	 <io-uring@vger.kernel.org>, "linux-fsdevel@vger.kernel.org"
	 <linux-fsdevel@vger.kernel.org>, "nvdimm@lists.linux.dev"
	 <nvdimm@lists.linux.dev>, "bpf@vger.kernel.org" <bpf@vger.kernel.org>
Date: Wed, 27 Mar 2024 15:15:17 +0200
In-Reply-To: <5b585bcced9b5fffbcfa093ea92a6403ee8ac462.camel@intel.com>
References: <20240326021656.202649-1-rick.p.edgecombe@intel.com>
	 <20240326021656.202649-3-rick.p.edgecombe@intel.com>
	 <D03NWFQM9XP2.1AWMB9VW98Z98@kernel.org>
	 <5b585bcced9b5fffbcfa093ea92a6403ee8ac462.camel@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.52.0 
Precedence: bulk
MIME-Version: 1.0

On Wed, 2024-03-27 at 02:42 +0000, Edgecombe, Rick P wrote:
> On Tue, 2024-03-26 at 13:57 +0200, Jarkko Sakkinen wrote:
> > In which conditions which path is used during the initialization of
> > mm
> > and why is this the case? It is an open claim in the current form.
>=20
> There is an arch_pick_mmap_layout() that arch's can have their own
> rules for. There is also a
> generic one. It gets called during exec.
>=20
> >=20
> > That would be nice to have documented for the sake of being
> > complete
> > description. I have zero doubts of the claim being untrue.
>=20
> ...being untrue?
>=20

I mean I believe the change itself makes sense, it is just not
fully documented in the commit message.

BR, Jarkko