Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp111621lqo; Wed, 27 Mar 2024 08:14:28 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWUEisYBIZUFi2pa0e5KMEhUTSGC61I/9GfZDFOqGbAuI1E03YmAIly3XtcFDti7LyJ7fJHvSHa6b83Wl69kkSpTTgo2pYg7qc3RHPKEA== X-Google-Smtp-Source: AGHT+IEXJVHUesFk5Xzn13gzVvjaSq0kzjj2BHIoAnAnQOygt3mtrGwGFY7V87MXMTv7gvdghtlW X-Received: by 2002:a05:620a:c94:b0:78a:3d2a:e0c with SMTP id q20-20020a05620a0c9400b0078a3d2a0e0cmr4505997qki.8.1711552467943; Wed, 27 Mar 2024 08:14:27 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711552467; cv=pass; d=google.com; s=arc-20160816; b=rvw4JYFxfEmf++RdYY0RQGuWPY7Xd9DldKfmP/wskpanCcXRvT+m+yqCRclJeKZc1I Y6t7Ql+a7Mle0p0IIuC5GiEHkS2eD6a5gRpEvrQxIzjGVLh5qPWp8RAsJRlUYzkGKW43 sAEfykFl8z6pdh+umZA7GbvvYYJ+ngPNm/wqfRcQ6tSG2rb52JsZLlexkjZwTxeUd7ro cSIQES/Irw7rFTVdTFlKDx2MBxIXL6KfyKPtTAzzjXV3cJXBu8xBlBSpI9LskP/F6w88 AFcKTyxHyjkZHhpxCNenOi0HxRAl9Wxia2E9vodQykUBFqXYW2iOG1L+S+/y6tdERZkU zMeA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=umCFANJ3vs+WOKOw7HufdXJ/lCLwlG1wjS8wimtj5UE=; fh=byMXkkqNwyTcUcBCGlV2A/dWjGAU2s+iMwFnmI4GTbc=; b=p/xP3eCxA8afPV89KXVWmQM7nxkfAHFEj5bvwMWqYscAaL/Hz94lL1UGWQfxngGOuM pT/DhtJVKP2BIZN0fHYFHT7LfZUBZW6cXpPFS/cE7Q0lkseJis8ukKbeL+E1mztQwf0z YQRUAx0DM56tVXlRpCpy6XrE7rFGsahzRBDsok4vIHFUPk+i/I7N5LQS8MIlpxdAvmI/ boC7ZLH21ViUDH4HnjjNBEF43y6UHvJFb5L0c6reHNgtYogxPu96BCcLdiaLWy0ceS9j zLrCkyvwk6CDfW44MqAh8cUyyNNrVQHhtnueUFKNwBU/OWtZZu9t4XCWvEiudMMymM13 YBuQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VGNJNTSE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-121458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121458-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s14-20020a05620a030e00b0078a3f07321esi9700113qkm.37.2024.03.27.08.14.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:14:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VGNJNTSE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-121458-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121458-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A92131C2FB4E for ; Wed, 27 Mar 2024 15:14:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 76E6C13B5B4; Wed, 27 Mar 2024 14:45:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VGNJNTSE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A197913B5A3; Wed, 27 Mar 2024 14:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711550718; cv=none; b=d1rkTvH2YkqMaKVQ9ov8zUR2n5U5BYMm9LEraLWTZyhZYJwDkdY1yFFcr0gV+t3kjfOz/IDiHCqdEFJ6KV4FnDqcRZU5FUvS6sV9+CLmWFgK4jyKHkRPImAB6KI8DXiaQofeDCAJxC3e8HyHvTfw3oZbk/uVZzKE10ZEJsGm6MY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711550718; c=relaxed/simple; bh=8DwuZaB/v3gjqMP4ZlY0VgdKvdFBfDihBASZIQ2fe/M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VeasDbETb+dY4UFTll9YJRJSwMhQ2EuSTlTVYlH/DnkUd7+UtDuQqwqPig29kGxiKTjWkA6XAXxMoGzT9edlcNb7NG8oxypvwH3uINHm+mi6ZCvrGHenDkR9PmFO8olTftLRq6I9j+9F8AfCAKobl6X1FFNjd7oAYx2yHzZvQb8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VGNJNTSE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B393CC433C7; Wed, 27 Mar 2024 14:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711550718; bh=8DwuZaB/v3gjqMP4ZlY0VgdKvdFBfDihBASZIQ2fe/M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VGNJNTSEWJNtgs2Hu+M47Xgcqo+VVmjftP3nd/F+C8sRcppBMoJhDWhicoq7pfFOP 7S3n/Vx2oHlntat9lLQaNy5iD7AVptqUIZrfY5ejpBq7CnLaFI7lXzIBvfwpQyt1G/ QO+HSeuPK/ruT03yWMoUs5mAeNRAHjp+QMWinaYGEqubEXvoJBQ3L/Zya9BS2/aUhS 4e6aD9fltwq6wKYJFfNlF4V57xqjJ5tge3uoCKDtBeXU6zIastxUeUGPWEO1JO/qQq 6HnJR7p3L2+bhfn6bhHGPZDu8Z8GrvONszFZ+wCvHIjUnOPQmxWMdyzjjkne1m5VHV g90OrfmDS/Htw== Date: Wed, 27 Mar 2024 07:45:16 -0700 From: Jakub Kicinski To: Breno Leitao Cc: Jeff Johnson , Kalle Valo , Jeff Johnson , keescook@chromium.org, "open list:NETWORKING DRIVERS (WIRELESS)" , "open list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" , open list Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically Message-ID: <20240327074516.624b7ecf@kernel.org> In-Reply-To: References: <20240319104754.2535294-1-leitao@debian.org> <9fcdb857-da62-4832-ae11-043fe993e4ad@quicinc.com> <20240321072821.59f56757@kernel.org> <5039256c-03eb-4cda-8d11-49e4561cf1ef@quicinc.com> <20240321151744.246ce2d0@kernel.org> <20240322082336.49f110cc@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Mar 2024 07:38:05 -0700 Breno Leitao wrote: > -void init_dummy_netdev(struct net_device *dev) > +void init_dummy_netdev_core(struct net_device *dev) Can init_dummy_netdev_core() be a static function (and no export)? alloc_netdev_dummy() is probably going to be the only user. I'd also lean towards squashing the two commits into one.