Received-SPF: pass (google.com: domain of linux-kernel+bounces-121348-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Zi Yan <ziy@nvidia.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
 Andrew Morton <akpm@linux-foundation.org>,
 Mel Gorman <mgorman@techsingularity.net>,
 "Huang, Ying" <ying.huang@intel.com>, David Hildenbrand <david@redhat.com>,
 linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 00/10] mm: page_alloc: freelist migratetype hygiene
Date: Wed, 27 Mar 2024 09:10:38 -0400
Message-ID: <A2223EEC-5CA7-469F-AD25-0D9BA35634A9@nvidia.com>
In-Reply-To: <81b1d642-2ec0-49f5-89fc-19a3828419ff@suse.cz>
References: <20240320180429.678181-1-hannes@cmpxchg.org>
 <81b1d642-2ec0-49f5-89fc-19a3828419ff@suse.cz>
Content-Type: multipart/signed;
 boundary="=_MailMate_EE6F443E-A2AA-4140-9630-05EC3E076536_=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?zajcMaEEUVF8BQxvsm6DWU9BThW270LCYrcuPe5FAWSpxUTt3GqEltDacge8?=
 =?us-ascii?Q?JyLnOkNn7ggOF0jULdU59fbjHdC7yOJqvwXwEMH31fbdASOyXdEWdMST+6Xs?=
 =?us-ascii?Q?2pYu2KqriA1yGh7dPY/uDramN9fMtNE2ibdk2i356QpyVNsfROht2DujR+wz?=
 =?us-ascii?Q?dwUxjdU6Do2t6H1L+tfksbGMx3yOTx9zr/IlD+Kv+gMnYh3FYw7PKJRFCrMk?=
 =?us-ascii?Q?zTS4KsBTcXGIGOJ3XYMX9zepWFBPoZ3bauLaGHXhkw6D0yKjnUtAiuWJ/znt?=
 =?us-ascii?Q?Y+qv/iBOf1LXLmjm39Vd5cJcLUNWC4Lxvdx2tizkN51PhUWb09zFLIM22YU3?=
 =?us-ascii?Q?dKhDvn4d2u9tU+Lv0iwjFJl4u5tefFubW7wDeeHpfB8bWRIdWraRQJRvLmqR?=
 =?us-ascii?Q?MOnbMdyNotEMas1xqKBGe43zrH0L8x2AGoMANPOoI1hJcDV5fomrpmGYmCvc?=
 =?us-ascii?Q?pmP83b2IiwGkiomhoNhvfAumt9jioNoxKocd1vtlKy2hyLYbxw3EDFr0p0Nh?=
 =?us-ascii?Q?pdo01BDtIg243ocBEXQ/6H9y5CyScXwmCd5wgiOdHFdfjij2aeJadnxB2YZu?=
 =?us-ascii?Q?WDNv/QrGSn0Sk68wcjVj7TEyNaRcmYsHp92b7kz7hrriPzC8zXcayrRAas3v?=
 =?us-ascii?Q?i3C7vc7gZDA8YF3nLmBq8WCuI/ZW+1ZwqU1NvUz9rbYjZ8dTU4ruQq+qGaS/?=
 =?us-ascii?Q?myHb3eUx22xWAVKrBfzgdp7wWgrf5PHi1Ys8bT1i9xCHejPX3+2O+sB90GcD?=
 =?us-ascii?Q?wSlt62ewYR0KfvKFek+B334k1XQDEiFW3hbgVhC11W3KRFADAWY0uSxI2NaE?=
 =?us-ascii?Q?AzCgkRbsz5eTvJKxJxQKiG/IcyJZYEvc1JtnOxQFx3VvSuBWa9rvjM9NE9pa?=
 =?us-ascii?Q?Cfh9dKn+ccMqqfYR3BC/XQ+cdrlw6Z7N6TuqgrDrfCWW4V1egIYVgJcQEMyp?=
 =?us-ascii?Q?OU7b1RhJPYPxPe0TO1LeZJ7sdB1d/7HhG5VQrNbQ/5SizhnPcaF8/YXjucol?=
 =?us-ascii?Q?/9HvaELnOT8NeDVBBDrfKkOEyCO27GoJhmplS17dMoyus3WCRKDKzN9LLEGf?=
 =?us-ascii?Q?NjZoHo8Lu8Pqc2hWl4KJQ543hVLJXQiJ7KmWOHkuLTNKHniN29fPaDUL7BG4?=
 =?us-ascii?Q?XEIesub0bSVDMKQ/Cmld04WRWbd+nNpahzPNUGuJpuKs9iXp/f8njG+lLIVW?=
 =?us-ascii?Q?awsEVaIQuTVRCluyJC76Ld8y3v7kvRfFSMn5+NCUj9A8mdUk9igx5AYnbRXE?=
 =?us-ascii?Q?PJ1Krsnhn6KX9xs71behiKgDMWUPeXYu+PPAboH0lMe9ddHKAoYJkH0H/ua3?=
 =?us-ascii?Q?uOpuAhHbYkaiRnw/YyMNUYN4DKl0IC+7A7dJuROoV6adMi453S0HOFh/uFeY?=
 =?us-ascii?Q?inQ2Imo6ELuFIgPfORd5UBeeD9BwtJ8mI/t1pC4Q7nEgsw/idz67F4S5qTly?=
 =?us-ascii?Q?dgI5YT0Yi5np/t7+vobbTA01S7NJ/r+nuCW19ctOWyJpibeNGUpKf4dBIBkj?=
 =?us-ascii?Q?PTEATPYhUbn9wywQ4Ju2YXbICR5gaN3iQSA3EfzJ4/ox/B5kiAG2ZlIC7xGY?=
 =?us-ascii?Q?RfRAc1tLETmt+DjjJ5g=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0fba3d83-42cb-418e-3d77-08dc4e5f4d56
X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5744.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 13:10:41.0060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: dpX9xd6wEQykFPn6PP+NQrvz3CNF2zBphMl+vN4yEp2Ats2ROWlepJc/89DTHWsk
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8180

--=_MailMate_EE6F443E-A2AA-4140-9630-05EC3E076536_=
Content-Type: text/plain

On 27 Mar 2024, at 5:30, Vlastimil Babka wrote:

> On 3/20/24 7:02 PM, Johannes Weiner wrote:
>> V4:
>> - fixed !pcp_order_allowed() case in free_unref_folios()
>> - reworded the patch 0 changelog a bit for the git log
>> - rebased to mm-everything-2024-03-19-23-01
>> - runtime-tested again with various CONFIG_DEBUG_FOOs enabled
>>
>> ---
>>
>> The page allocator's mobility grouping is intended to keep unmovable
>> pages separate from reclaimable/compactable ones to allow on-demand
>> defragmentation for higher-order allocations and huge pages.
>>
>> Currently, there are several places where accidental type mixing
>> occurs: an allocation asks for a page of a certain migratetype and
>> receives another. This ruins pageblocks for compaction, which in turn
>> makes allocating huge pages more expensive and less reliable.
>>
>> The series addresses those causes. The last patch adds type checks on
>> all freelist movements to prevent new violations being introduced.
>>
>> The benefits can be seen in a mixed workload that stresses the machine
>> with a memcache-type workload and a kernel build job while
>> periodically attempting to allocate batches of THP. The following data
>> is aggregated over 50 consecutive defconfig builds:
>
> Great stuff. What would you say to the following on top?
>
> ----8<----
> From 84f8a6d3a9e34c7ed8b438c3152d56e359a4ffb4 Mon Sep 17 00:00:00 2001
> From: Vlastimil Babka <vbabka@suse.cz>
> Date: Wed, 27 Mar 2024 10:19:47 +0100
> Subject: [PATCH] mm: page_alloc: change move_freepages() to
>  __move_freepages_block()
>
> The function is now supposed to be called only on a single pageblock and
> checks start_pfn and end_pfn accordingly. Rename it to make this more
> obvious and drop the end_pfn parameter which can be determined trivially
> and none of the callers use it for anything else.
>
> Also make the (now internal) end_pfn exclusive, which is more common.
>
> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> ---
>  mm/page_alloc.c | 43 ++++++++++++++++++++-----------------------
>  1 file changed, 20 insertions(+), 23 deletions(-)
>
This looks good to me and makes sense. Reviewed-by: Zi Yan <ziy@nvidia.com>

--
Best Regards,
Yan, Zi

--=_MailMate_EE6F443E-A2AA-4140-9630-05EC3E076536_=
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename=signature.asc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQJDBAEBCgAtFiEE6rR4j8RuQ2XmaZol4n+egRQHKFQFAmYEGs4PHHppeUBudmlk
aWEuY29tAAoJEOJ/noEUByhUHrUQAKHhEop4mkFtZVXp+3/WbrANacnUjftW1U+E
RA300v1Jp3C8do8AzzraXMVw7BgswG8mY5oecmPcsUKF2anhr14GP4GihMfzwxs7
ZiHhA/u01yfgWMz/FfZu/M+uhnhS+1wPu2HNeGaZY0PynWdi9zF+SZi4X5d7aCDm
FoWFCz2TgYd6KXgxfSqMcebEFiMiTAdv3Yv9nCAdxIDKjvDglVQInBItioAqIe8e
HZOO5ERzKIKWytK5ISWjMyvsjY2DtdYGbn0bZETq9by7oiQlhcSMQuTt7jCIZJE2
eLW28pVET8SzSCOxey+3zrGayd+GKRpncvOeTwGvVhRIR96OkBAFYVXMteOYp2Gf
qVKfHgzBqMm+R4pMgdDyC3A5LXeM+ukCANoAs3blws7fm51aaMyx0hXN/9hwgbxc
tv/R87Q20vIdnvnRScJnjIGa9yro/hiHFweE7fcwKOaaqJm2OiQD3wY3YhhnuORX
gxS4kyMprjrObK2raADRbosh41Q4r4o5no5I0tEARU0WvUDGSnGO94/I2srXsgiW
XSOUU9h6oPKYoF+zEzwb7RCrLhea+jLHMl6/sMHtugquuPDMrJBFvJZFlFCk9q77
ueHzBILgsUQom2N71bzm8fGo4Eis8YKnWHbunTVSWg59v53E5sYqadFVG8DM8ywh
WJTkrKr7
=HwrE
-----END PGP SIGNATURE-----

--=_MailMate_EE6F443E-A2AA-4140-9630-05EC3E076536_=--