Received-SPF: pass (google.com: domain of linux-kernel+bounces-121501-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240325220952.1453477-1-helgaas@kernel.org>
In-Reply-To: <20240325220952.1453477-1-helgaas@kernel.org>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 27 Mar 2024 16:23:41 +0100
Message-ID: <CAJZ5v0j6SaxTG9+Zr1Sk9iN_bvzzOCD+7_s98HEes1CY825epQ@mail.gmail.com>
Subject: Re: [PATCH] Documentation: PM: Update platform_pci_wakeup_init() reference
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, 
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Bjorn Helgaas <bhelgaas@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 25, 2024 at 11:11=E2=80=AFPM Bjorn Helgaas <helgaas@kernel.org>=
 wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> platform_pci_wakeup_init() was removed by d2e5f0c16ad6 ("ACPI / PCI: Rewo=
rk
> the setup and cleanup of device wakeup") but was still mentioned in the
> documentation.
>
> Update the doc to refer to pci_acpi_setup(), which does the equivalent
> work.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
>
> pci_acpi_setup() is a firmware-specific wart in this otherwise generic
> paragraph, so maybe there's some better way to express this?
>
>  Documentation/power/pci.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/power/pci.rst b/Documentation/power/pci.rst
> index 12070320307e..e2c1fb8a569a 100644
> --- a/Documentation/power/pci.rst
> +++ b/Documentation/power/pci.rst
> @@ -333,7 +333,7 @@ struct pci_dev.
>  The PCI subsystem's first task related to device power management is to
>  prepare the device for power management and initialize the fields of str=
uct
>  pci_dev used for this purpose.  This happens in two functions defined in
> -drivers/pci/pci.c, pci_pm_init() and platform_pci_wakeup_init().
> +drivers/pci/, pci_pm_init() and pci_acpi_setup().
>
>  The first of these functions checks if the device supports native PCI PM
>  and if that's the case the offset of its power management capability str=
ucture
> --

Applied as 6.10 material, or if you'd rather take it to the PCI tree,
please let me know.