Received-SPF: pass (google.com: domain of linux-kernel+bounces-121493-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Luck, Tony" <tony.luck@intel.com>
To: Kees Cook <keescook@chromium.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: __randomize_layout;
Thread-Topic: __randomize_layout;
Thread-Index: AdqAWK/04TJgEIx0R828MwI3UxJ65w==
Date: Wed, 27 Mar 2024 15:21:59 +0000
Message-ID: <SJ1PR11MB608346DDA3F41ABB893C7860FC342@SJ1PR11MB6083.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CrmeY+5+Wl9hZBNus7M1pC1S+uwbSfv3+I1LRWQqv/aBXBaRr9G325A46rR7?=
 =?us-ascii?Q?wdkyPoXYBLuONsPgcjRoKwOl9CjuE8EMEvGdZLeBLwX5dGco/N2mlryh9hL+?=
 =?us-ascii?Q?BeUkjTQSU9SJeM8R2lEv6SEUVVKLsszyc0mWpYHtQOhJzX5Tdmy0w/chcBxA?=
 =?us-ascii?Q?DQnSxnQ8KgxTGtmpYGJAtnq+hPjY7dIo4UTyXflxkR2mmAebjd5uHDYNmlIA?=
 =?us-ascii?Q?AZoWssdq+wkNZCzDPdsxUE543hK2rMYLUm8V/OemhJG+bLITA4jFeegMUbjS?=
 =?us-ascii?Q?AamMOZIPb/q51AyZmKC1XpYEA4g4ICBe2ppB5BypYPYb2mSHplDpQOKmb2AQ?=
 =?us-ascii?Q?D1FkzKLwtwx586CHbec3YJQZ8IdYarMM4zxzqYtbSHNbYTqdneL+tWHAGIxZ?=
 =?us-ascii?Q?ucHPNHPsANIoau77t+xOpudt5vQ01C0R2+eYiKPwZWfnmMTDDwH4Cvs3HBga?=
 =?us-ascii?Q?3pL47FuGHZv6+10Ozm29Pg2QVjSRKkDyKaxqdX9MZUju0kue45qeW5TsqRch?=
 =?us-ascii?Q?bv8KB1Lmica8HlRJW1rlxR3REcJ6s9lDhnWR9cAXxcv6deZ+tDla5umbhtvK?=
 =?us-ascii?Q?wtcIFrSg9Xd3kZy0Ry7olYZYid/IWGaAh3uHon+uciejOiPp6ksPFEuu6Pz+?=
 =?us-ascii?Q?e8tettNBRZdiIYw0oKjAGHlvJyHOtLS82UvrRt3RdfnEnj4pm+SRZ55ahaea?=
 =?us-ascii?Q?ucnT4B9Ru3b5+5T5dXXwUhX3uQQMrz17aN7ZJf9VBkY+CfV9p6pyy62jxAea?=
 =?us-ascii?Q?ihcEczVusOrAJlKYCnPfsMna5JZv+WmpqS6JC0bcDUD/olqrW4fEmf8tqwPR?=
 =?us-ascii?Q?czavlR9cjl5u05gY8aD23RrIXJA3Jfc+fjRKS1m4DPxZ3SNzJnohHIiBRCPl?=
 =?us-ascii?Q?CvgLTMs9wZbfKHPhOHDNRG0fjK1P7n9T5AIrDY+oG2LnlNhkviikVIp3LKl/?=
 =?us-ascii?Q?C1qoJmz80Zc68ZKAab2Mtl0tEKg3w1W4reaRPL14cYUcr1hX/QfUvzm8qD0n?=
 =?us-ascii?Q?un8yizrS1QJCJmNF2FyRgLdyhSx+k9v3oyVNKTrc8JQjVFjMOU2UJhR7EBMC?=
 =?us-ascii?Q?StlXO9e8IwfjXnM7pJILvu1UjCBrFZCOg8YG1bdv7d//0Xv8v8RsojjRoSXe?=
 =?us-ascii?Q?F/bY03SzPko1GRyA0POWsQwCu9lRnUi9/8tXiOzvw95Q7IxxI8GvXPVtGO87?=
 =?us-ascii?Q?1gsgzjmX6vy+RsD7QMiqaElppnznt+9xAPhgV0sATFbVJn3Y35caxl/cRlAG?=
 =?us-ascii?Q?aHRzUIESbA8e4DR5vOaxjtz98Tzjh3ZNrS7pzz7jtjYuJg1pzyOmAlpnH7mh?=
 =?us-ascii?Q?r1niXoppcKze+cDAjAEOAJ9xopFgUF6gSE2nJu8SF9K3m+P/Ll6BimjIb3vk?=
 =?us-ascii?Q?KV+BfurP2TrDln/MNLJi/HW0iHaMGAflS43Ulqg/6l2SHwlv9SZ+WiGjUOef?=
 =?us-ascii?Q?o8/z2/HtzinS6M6wKDhRdmPEZFR+2ICnXf0Fwuk0as8zPkPELxR+1HwAKmat?=
 =?us-ascii?Q?pZrMf1Dd592oYEGuCpkftBqF9rvlKlKgK6K3WCbhwct/Ca1HYI0ln8w7kB8e?=
 =?us-ascii?Q?09t/lHVYOsOf3o3TawLp+m1Th+LWCScya4FcQCf+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR11MB6083.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c0d7459-ad77-4105-c2d8-08dc4e71a59a
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 15:21:59.6364
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vZBSmPkh5yQ4rSlgAf9sNLOtlgC//OlSXRf8rQ8twYA6FDS7mHdNKzO39sUuF9ECpKzoN2lLmRYcFspFXsEL1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4679
X-OriginatorOrg: intel.com

Kees,

I'm working on some changes/cleanups to make supporting new x86 CPUID famil=
ies
easier and safer. The big picture is to make the Intel CPU model definition=
s in
<asm/intel_family.h> encode vendor, family and model so that code like:

  if (c->x86_vendor =3D=3D X86_VENDOR_INTEL && c->x86 =3D=3D 6 && c->x86_mo=
del =3D=3D INTEL_FAM6_ICELAKE_X)

can become:

  if (c->x86_vfm =3D=3D INTEL_ICELAKE_X)

Source and generated code are smaller. Safer too as it becomes impossible t=
o skip the
vendor and family checks.

To achieve this I want to make a union in struct cpuinfo_x86 that overlays =
vendor/family/model onto
a 32-bit "x86_vfm" field:

struct cpuinfo_x86 {
        union {
                struct {
                        __u8    x86_vendor;     /* CPU vendor */
                        __u8    x86;            /* CPU family */
                        __u8    x86_model;
                        __u8    x86_reserved;
                };
                __u32           x86_vfm;        /* combined vendor, family,=
 model */
        };
        __u8                    x86_stepping;

	... many other fields
} __randomize_layout;

This e-mail is to check you on whether that __randomize_layout can shuffle =
the
fields inside that nested union/structure. I tried some experiments, and in=
 a
few kernel builds I saw the whole block move to different offsets, but the =
order
of x86_vendor, x86, x86_model, and x86_reserved was preserved.

But experiments aren't proof. Nor defense against future versions of
scripts/gcc-plugins/randomize_layout_plugin.c becoming smarter or
more aggressive about changing layout.

Thanks

-Tony