Received-SPF: pass (google.com: domain of linux-kernel+bounces-121471-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 27 Mar 2024 14:58:50 +0000
From: Mark Brown <broonie@kernel.org>
To: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Cc: alsa-devel@alsa-project.org, venkataprasad.potturu@amd.com,
	Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Syed Saba Kareem <Syed.SabaKareem@amd.com>,
	Jarkko Nikula <jarkko.nikula@bitmer.com>,
	Claudiu Beznea <claudiu.beznea@tuxon.dev>,
	"open list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." <linux-sound@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: amd: acp: fix for acp_init function error
 handling
Message-ID: <e4ba58bc-fa5b-4ece-8906-f7cc7cb5b0f4@sirena.org.uk>
References: <20240327104657.3537664-1-Vijendar.Mukunda@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HHnNWzSd/b2J4Dry"
Content-Disposition: inline
In-Reply-To: <20240327104657.3537664-1-Vijendar.Mukunda@amd.com>


--HHnNWzSd/b2J4Dry
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 27, 2024 at 04:16:52PM +0530, Vijendar Mukunda wrote:

> @@ -115,7 +115,10 @@ static int acp_pci_probe(struct pci_dev *pci, const =
struct pci_device_id *pci_id
>  		goto unregister_dmic_dev;
>  	}
> =20
> -	acp_init(chip);
> +	ret =3D acp_init(chip);
> +	if (ret)
> +		return ret;
> +

The return check is good but shouldn't this be a 'goto
unregister_dmic_dev' like the above case so we do cleanup?

--HHnNWzSd/b2J4Dry
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmYENCkACgkQJNaLcl1U
h9CYOwf7BZiqXeDfs5qRdUvEV6cGZnFIAaeLR8VhXpILbSHzmNxBzmFxPAC3BGQI
xKGZ7bBdvf4funwt/P/PKxFh7p0o78PjkO9pzru4987ZlqH19RmzJvcc5+DU7lY0
Phf3ttUIpmZNDdXQi08pvBOLpJFsynY4v+EuUIpTdGLOHNB9k/Y5EKV3ZMV2pWn9
LFqxzfV00O03xEu+q7Dm20GthUd9c+pVRehCB7ZgFABe+39fZAclAnumiDS5WhMO
i/uBEQTku/TMKuedQPP5AwG4kB4ZLIkYihT5X968UG270soc7b8dP9tKcAsbuz9p
WEEvxqDuH8qQZ2/8VT0ipDeTOAbmAQ==
=HydH
-----END PGP SIGNATURE-----

--HHnNWzSd/b2J4Dry--