Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp127837lqo; Wed, 27 Mar 2024 08:38:14 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWWFNIYo/FkRqlU2XaOWCNF+wNPRJdYoOatNSVqVy9Zk6L5kMbnzbrzjNxS+MekViSMPVrFu/651Npk3Gs3mCoYpl1d3bs9z+vRm/WUFA== X-Google-Smtp-Source: AGHT+IEDBRdRxooh+V/Kj+AM3DMTe1nud9jnx4ODERmGHThX+uRL6PZxNWqwTHF/AFm5/seLvAsb X-Received: by 2002:a05:6358:4291:b0:17f:88fb:5bd5 with SMTP id s17-20020a056358429100b0017f88fb5bd5mr3609210rwc.20.1711553893769; Wed, 27 Mar 2024 08:38:13 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711553893; cv=pass; d=google.com; s=arc-20160816; b=o3rjAjo78vHJASyESrlFIYFI8RfeBqjKSyqig/hVoHumBO9WEsj1Z/Z5A/pTMbF9cm 47WLDFqgaai0oIAZgOPc1N3ec4/KvxRZJP6NyGSbzAlUquOY8mQPVJ2XNZVTeBC/3lU4 zIVMicjGXsxv83H7sKKeSPq0px7t0h1kNEQcjItTcm6nJ1r5DyjHhyNTfToKBrktsVRi 8+ryYozMoBO4BQhvS/BsomP1C+6ziKgRT4ON+PFPpDaebYf3NA3FG9LjgxYX7NUKXvht 2Q8WAVhrweIelMU6bCYl19SHiablxlk89X5eRnNr++YYuZdwqYrTu8L152tVvzussw2O /4Sg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=EorSfQReKWZqq0R7YUdCHVPdX/CDiwhRqBh2ZsU073I=; fh=23Wpu/faE0NjOZqZVHLmmvCToX/wpvJKRBWpGYVzEbs=; b=ONK30LKGqfPs6pnA6pFY2V3JjMx2+j0UfcgFo8XSjcfyUn/pDLh4YbBZICPBS758Xv lsK7yusGhhuvZamOeRU4gmw8NlSbF9GtKbSqNSzi9EdaN1z/9x0g+ZtgTPU2xfckC+bs v6Fogxhnd22y5OfXUBmgX10WQdETL54arlyIz6pblWqhZqjO+7CAYCUaH8ZSYgjlikdd 0hH212ehdg1qdy2jwrJRikxRzf+L7l0RaovJVvp/2RmeZhqCBMiu3fgtvfvyd4RsCsU4 ENnMnuYPWJoX7Xn1XR+T7tpQCHvCxHrZjMMyRk5UfCPTAze/aKh4k1A43MPGWwGsdQkO jvOw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-121486-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121486-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e190-20020a6369c7000000b005dc8fe5ef05si12141631pgc.96.2024.03.27.08.38.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:38:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121486-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=omp.ru); spf=pass (google.com: domain of linux-kernel+bounces-121486-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121486-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 28ABA2C4D1A for ; Wed, 27 Mar 2024 15:24:42 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 58206147C7E; Wed, 27 Mar 2024 15:15:18 +0000 (UTC) Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C35C13BC10 for ; Wed, 27 Mar 2024 15:15:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=90.154.21.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711552517; cv=none; b=Oc995ZUeGzZhXN4oHLi+4EjtUTHj1tG75ylu8X7CNz8NVBmilX4QR3NIY0Ou8xF8pKlQAOUK1J45vRFK2BqK6BoAePr1xS0VoMcQJlVZBbmoLw67HgKuVJ/n5HjndBL6131nPTqjO6zf+44jcSHMXsSGROfzjPXqyuEuETee2wY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711552517; c=relaxed/simple; bh=FB9KijKmhBySPWMwoOs2QzeggUljSCO/bu79JB0xETo=; h=Subject:To:CC:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=Hxc0qLFw0Ze1Srx6by7pDQ4tfkKEFhEekK8Mcg0U3vrwHCondns6yzoZVdFnhNaJIJZMHFv3wtw7AuMsYo5+NXpRy4BRlO1tbkN1tlzLXjCbPgSgzlnk8iI0x4qKeycA3k/tXLLVCxG+S+J3iywjXcJLAXlXneWzIhoZRZD7Od4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru; spf=pass smtp.mailfrom=omp.ru; arc=none smtp.client-ip=90.154.21.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=omp.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=omp.ru Received: from [192.168.1.105] (31.173.86.12) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.1258.12; Wed, 27 Mar 2024 18:15:09 +0300 Subject: Re: [PATCH v2] udf: udftime: prevent overflow in udf_disk_stamp_to_time() To: Roman Smirnov , Jan Kara CC: , , Jan Kara References: <20240327132755.13945-1-r.smirnov@omp.ru> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <703e52b1-82f0-13fb-94b8-2d6ff16598e8@omp.ru> Date: Wed, 27 Mar 2024 18:15:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20240327132755.13945-1-r.smirnov@omp.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 6.1.0, Database issued on: 03/27/2024 14:57:27 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 0 X-KSE-AntiSpam-Info: Lua profiles 184448 [Mar 27 2024] X-KSE-AntiSpam-Info: Version: 6.1.0.4 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 13 0.3.13 9d58e50253d512f89cb08f71c87c671a2d0a1bca X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: omp.ru:7.1.1;127.0.0.199:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 31.173.86.12 X-KSE-AntiSpam-Info: Rate: 0 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 03/27/2024 15:01:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 3/27/2024 10:50:00 AM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit On 3/27/24 4:27 PM, Roman Smirnov wrote: > An overflow can occur in a situation where src.centiseconds > takes the value of 255. This situation is unlikely, but there > is no validation check anywere in the code. > > Found by Linux Verification Center (linuxtesting.org) with Svace. > > Suggested-by: Jan Kara > Signed-off-by: Roman Smirnov Reviewed-by: Sergey Shtylyov [...] MBR, Sergey