Received-SPF: pass (google.com: domain of linux-kernel+bounces-121536-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240321102100.2401340-1-ye.zhang@rock-chips.com> <c7b2cb6f-3e14-45c3-9e22-11c0a9422bce@arm.com>
In-Reply-To: <c7b2cb6f-3e14-45c3-9e22-11c0a9422bce@arm.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Wed, 27 Mar 2024 16:29:11 +0100
Message-ID: <CAJZ5v0hE+erpYAiYGbQS_D8u==-ovvut_cyGAMj47Rm5FD7HVg@mail.gmail.com>
Subject: Re: [PATCH v2] thermal: devfreq_cooling: Fix perf state when
 calculate dfc res_util
To: Lukasz Luba <lukasz.luba@arm.com>, Ye Zhang <ye.zhang@rock-chips.com>
Cc: tao.huang@rock-chips.com, heiko@sntech.de, daniel.lezcano@linaro.org, 
	finley.xiao@rock-chips.com, linux-rockchip@lists.infradead.org, 
	linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, rui.zhang@intel.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Mar 22, 2024 at 9:50=E2=80=AFAM Lukasz Luba <lukasz.luba@arm.com> w=
rote:
>
>
>
> On 3/21/24 10:21, Ye Zhang wrote:
> > The issue occurs when the devfreq cooling device uses the EM power mode=
l
> > and the get_real_power() callback is provided by the driver.
> >
> > The EM power table is sorted ascending=EF=BC=8Ccan't index the table by=
 cooling
> > device state=EF=BC=8Cso convert cooling state to performance state by
> > dfc->max_state - dfc->capped_state.
> >
> > Fixes: 615510fe13bd ("thermal: devfreq_cooling: remove old power model =
and use EM")
> > Cc: 5.11+ <stable@vger.kernel.org> # 5.11+
> > Signed-off-by: Ye Zhang <ye.zhang@rock-chips.com>
> > ---
> > v1 -> v2:
> >    - Update the commit message.
> >
> >   drivers/thermal/devfreq_cooling.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/thermal/devfreq_cooling.c b/drivers/thermal/devfre=
q_cooling.c
> > index 50dec24e967a..8fd7cf1932cd 100644
> > --- a/drivers/thermal/devfreq_cooling.c
> > +++ b/drivers/thermal/devfreq_cooling.c
> > @@ -214,7 +214,7 @@ static int devfreq_cooling_get_requested_power(stru=
ct thermal_cooling_device *cd
> >
> >               res =3D dfc->power_ops->get_real_power(df, power, freq, v=
oltage);
> >               if (!res) {
> > -                     state =3D dfc->capped_state;
> > +                     state =3D dfc->max_state - dfc->capped_state;
> >
> >                       /* Convert EM power into milli-Watts first */
> >                       rcu_read_lock();
>
> Thanks, LGTM
>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

Applied as 6.9-rc material, thanks!