Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp132033lqo; Wed, 27 Mar 2024 08:45:21 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCU1nsW5SpGFnfGLaWkkesv2yiHbc1wCqBZXo8fGtZXBWJV8sZXnxoIY/iRrg1//UTzoSb4jofDV3PQo9q6vhdtXFDIgTpGjd3da7AxA9A== X-Google-Smtp-Source: AGHT+IHCDfl6ZWYqOumL70YTcyEuFtyXzPZrx/5BJUCjK8OkpDeuuz3xBvNnTT7D2u51T7Il1Ed6 X-Received: by 2002:a67:e98a:0:b0:477:8524:4aaf with SMTP id b10-20020a67e98a000000b0047785244aafmr510427vso.3.1711554320922; Wed, 27 Mar 2024 08:45:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711554320; cv=pass; d=google.com; s=arc-20160816; b=0LqoBkVVJq1sRJOyJCseHqfrMtUzBtO77wg7vfGthSIejZWAIgaB+KNK88n6xju7sB mNfVw1qjUHHLeO/0F0TliLi1WW3krHsGJk+4zXWr1Qb33oZ6F4gldelnS8oPfwRfKvPZ lp4d15UoKtbZFgtbtl2k1f/7xvnEsJpJIZRUDi3st9X7wW0oScoDEQhjOkpxgu3Nk8QA Tkmm1D7lbikGpNiB4bLDeQa7yU4mVSOq6DLMxjmrovcGQuZJ8K21BKEVZS1wJb1QrMwU J93nBOZwGOkblsjgbXsewqIG8xGQlZlB5Lzlc7nJMEIcm0/z9czRZIq+R9v/kYHYYA1R JYLA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=iTJtIyvEyMm+72lIccKfoSkvR084yL6HclVWwEjXWLI=; fh=rywUcXLZ1LiJat4C2y14Ljqut9xP+FZ6qf/N5USr7jQ=; b=S0k/Auwxyg12v5QoB3e7PHttYiuCzoyUr1YNqNSbBYU9AvrIdatC1t95ygtGh+2aWm chjW5ffS+3qEBUM/fHc+odTclu52AtbIvpzJ/FSFKNZOAJHpJc90v2lScfmMMild9OR4 bKDPPZSTOnnnbPE2+hdRKxd6pTSTBjQUh3EW0MAxiMa/pMxk8XpzfrgSvmEFKqcEGdjy BqvyptOz+38IJToPEmJBpO7ohjOmplF1qIqZvg6STaLh5LKXTjqNWo3KzROzX+a4nEg2 BDXlEmHI1Z+iCXepoGH1h5D30JAR5I7vAKAyff1+qYRcn18TQkgs2htw/wWhNtBIONkv 03sw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V1ETZVaO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-121552-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121552-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id u19-20020a05620a023300b0078a5b5856fbsi5870953qkm.687.2024.03.27.08.45.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 08:45:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121552-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=V1ETZVaO; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-121552-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121552-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A30531C31202 for ; Wed, 27 Mar 2024 15:45:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33A1012EBCF; Wed, 27 Mar 2024 15:43:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V1ETZVaO" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5A3DB12DDA6; Wed, 27 Mar 2024 15:43:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554199; cv=none; b=mjCTqzsAjzdiRCIAN7kqbqNvQdLKPgEoGc4r9iAoDKyk+1vU6MrlV4yO1mC7cf/HAXrICMoPzBXUFjWEi0xqNhhRrATZbuXvF5OrZgYrDojNGarYTgy9MSUnKJiha20dU9UPfL6SeuY73kiCgimNEni7e2ELyyD2Oo1qaxvqJpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711554199; c=relaxed/simple; bh=aBbxarP4jaK4Vd3GsndlzhtjPh19wImbPPVLqBPo3Zc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=L6O7TfMYRFNMHTc6inPIFc3z9mT6azMMuyK2gwfMms58hja5iq5M/kUEBaDu6IjY/rANWrbqt2DfXMuvsPOvT5p4EI376f+c21FwTXK9JVkh3VmMTCmJUmaz5yTyWkGCHNdQ9VwGWl88QFXpTwsqi8UCmCv2f/TMTwfMaCgdFWg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V1ETZVaO; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id AEEE2C4166A; Wed, 27 Mar 2024 15:43:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711554198; bh=aBbxarP4jaK4Vd3GsndlzhtjPh19wImbPPVLqBPo3Zc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V1ETZVaOGmLgyK6y5BEngFQ7ogBt81FdTsOEwzKmc+Z6S7n2IMIb04Oqx4EEsellz TleDgc+tLzLHY2Dqb8AjQygzL0RPVJ4hNknke0FDWVQHVTkbv1jmR/IFad4Wjd6LE1 wudwH2HdkvVWozDsCxoypt6vwZ71yHa5FozIppzux2irppfwjQcPdQniivxasEmx65 fnw3hxCNdlcfxSEN4AxjbFRpj3L8VSwbMDs1SqUgqAWmM85nRNhqMldIg0K1WnpXqh PKUk+WLuQj2+XOQVxNuaEYhO3bMKbey8Vw2pnki3yu9QX8z7a3Wqb3qJFQS9gQU6bF kVxdD0sGNFKnQ== Date: Wed, 27 Mar 2024 10:43:16 -0500 From: Rob Herring To: Raymond Hackley Cc: linux-kernel@vger.kernel.org, Bjorn Andersson , Konrad Dybcio , Krzysztof Kozlowski , Conor Dooley , Stephan Gerhold , Nikita Travkin , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH 2/2] dt-bindings: qcom: Document samsung,fortuna Message-ID: <20240327154316.GA3453016-robh@kernel.org> References: <20240326141222.200452-1-raymondhackley@protonmail.com> <20240326141222.200452-3-raymondhackley@protonmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240326141222.200452-3-raymondhackley@protonmail.com> On Tue, Mar 26, 2024 at 02:12:58PM +0000, Raymond Hackley wrote: > Document common binding samsung,fortuna used by the following > Samsung Galaxy Grand Prime devices below: > - SM-G530FZ (msm8916-samsung-grandprimelte) > - SM-G530H (msm8216-samsung-fortuna3g) > - SM-G530W (msm8916-gprimeltecan) Commit messages should answer "why?". Why do you need this? Please test this binding change against your dts changes. I think you will find it fails. > > Signed-off-by: Raymond Hackley > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 66beaac60e1d..2db776d78d22 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -204,6 +204,7 @@ properties: > - samsung,a5u-eur > - samsung,e5 > - samsung,e7 > + - samsung,fortuna > - samsung,fortuna3g > - samsung,gprimeltecan > - samsung,grandmax > -- > 2.39.2 > >