Date: Fri, 18 Jan 2008 01:03:37 -0800
From: Yinghai Lu <Yinghai.Lu@Sun.COM>
Subject: Re: [PATCH] X86: fix typo PAT to X86_PAT
In-reply-to: <20080118081040.GB16597@elte.hu>
To: Ingo Molnar <mingo@elte.hu>
Cc: venkatesh.pallipadi@intel.com, LKML <linux-kernel@vger.kernel.org>
Message-id: <200801180103.37771.yinghai.lu@sun.com>
Organization: Sun
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: 7BIT
Content-disposition: inline
References: <200801171950.32458.yinghai.lu@sun.com>
 <20080118081040.GB16597@elte.hu>
User-Agent: KMail/1.9.6 (enterprise 20070904.708012)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 958
Lines: 30

On Friday 18 January 2008 12:10:40 am Ingo Molnar wrote:
> 
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
> 
> >  config MTRR
> >  	bool "MTRR (Memory Type Range Register) support"
> > -	depends on !PAT
> > +	depends on !X86_PAT
> >  	---help---
> >  	  On Intel P6 family processors (Pentium Pro, Pentium II and later)
> >  	  the Memory Type Range Registers (MTRRs) may be used to control
> 
> thanks. But, i think we should rather do the following: if X86_PAT is 
> eanbled then /proc/mtrr should be read-only. There's no problem 
> _looking_ at MTRR contents, as long as we do not try to modify them. Hm?

anyway 

depends on !PAT

need to be removed.

it seems when PAT is used, some code still touch MTRR.

YH
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/