Received-SPF: pass (google.com: domain of linux-kernel+bounces-121646-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 27 Mar 2024 16:45:56 +0000
From: Conor Dooley <conor@kernel.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Damien Le Moal <dlemoal@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, linux-ide@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] dt-bindings: ata: ahci-da850: Convert to dtschema
Message-ID: <20240327-dumpster-capital-fcb7d205b294@spud>
References: <20240327064354.17384-1-animeshagarwal28@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="VU9LhsKx0E9NZ6tS"
Content-Disposition: inline
In-Reply-To: <20240327064354.17384-1-animeshagarwal28@gmail.com>


--VU9LhsKx0E9NZ6tS
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 27, 2024 at 12:13:51PM +0530, Animesh Agarwal wrote:
> Convert the ahci-da850 bindings to DT schema.
>=20
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
>=20
> ---
> Changes in v3:
> - Fixed line length issue on line 20
> - Removed unneccessary '|' character

Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

> Changes in v2:
> - Added description for reg property items.
> ---
>  .../devicetree/bindings/ata/ahci-da850.txt    | 18 ---------
>  .../bindings/ata/ti,da850-ahci.yaml           | 39 +++++++++++++++++++
>  2 files changed, 39 insertions(+), 18 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/ata/ahci-da850.txt
>  create mode 100644 Documentation/devicetree/bindings/ata/ti,da850-ahci.y=
aml
>=20
> diff --git a/Documentation/devicetree/bindings/ata/ahci-da850.txt b/Docum=
entation/devicetree/bindings/ata/ahci-da850.txt
> deleted file mode 100644
> index 5f8193417725..000000000000
> --- a/Documentation/devicetree/bindings/ata/ahci-da850.txt
> +++ /dev/null
> @@ -1,18 +0,0 @@
> -Device tree binding for the TI DA850 AHCI SATA Controller
> ----------------------------------------------------------
> -
> -Required properties:
> -  - compatible: must be "ti,da850-ahci"
> -  - reg: physical base addresses and sizes of the two register regions
> -         used by the controller: the register map as defined by the
> -         AHCI 1.1 standard and the Power Down Control Register (PWRDN)
> -         for enabling/disabling the SATA clock receiver
> -  - interrupts: interrupt specifier (refer to the interrupt binding)
> -
> -Example:
> -
> -	sata: sata@218000 {
> -		compatible =3D "ti,da850-ahci";
> -		reg =3D <0x218000 0x2000>, <0x22c018 0x4>;
> -		interrupts =3D <67>;
> -	};
> diff --git a/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml b/D=
ocumentation/devicetree/bindings/ata/ti,da850-ahci.yaml
> new file mode 100644
> index 000000000000..ce13c76bdffb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ata/ti,da850-ahci.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/ata/ti,da850-ahci.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI DA850 AHCI SATA Controller
> +
> +maintainers:
> +  - Animesh Agarwal <animeshagarwal28@gmail.com>
> +
> +properties:
> +  compatible:
> +    const: ti,da850-ahci
> +
> +  reg:
> +    items:
> +      - description: Address and size of the register map as defined by =
the AHCI 1.1 standard.
> +      - description:
> +          Address and size of Power Down Control Register (PWRDN) for en=
abling/disabling the SATA clock
> +          receiver.
> +
> +  interrupts:
> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    sata@218000 {
> +        compatible =3D "ti,da850-ahci";
> +        reg =3D <0x218000 0x2000>, <0x22c018 0x4>;
> +        interrupts =3D <67>;
> +    };
> --=20
> 2.44.0
>=20

--VU9LhsKx0E9NZ6tS
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZgRNQwAKCRB4tDGHoIJi
0jkWAQCSSLpUzexLRjqLIKY2mVH4S1mYreX+yuIXE/k7/qbSdAD6Aw0jdUN0qVr+
7PdP3mgYcHF9msvjCUyaFVIC2MedoAQ=
=rjer
-----END PGP SIGNATURE-----

--VU9LhsKx0E9NZ6tS--