Received-SPF: pass (google.com: domain of linux-kernel+bounces-121671-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
        "llvm@lists.linux.dev" <llvm@lists.linux.dev>,
        Ariel Elior
	<aelior@marvell.com>, Manish Chopra <manishc@marvell.com>
CC: "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni
	<pabeni@redhat.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers
	<ndesaulniers@google.com>,
        Bill Wendling <morbo@google.com>,
        Justin Stitt
	<justinstitt@google.com>,
        Simon Horman <horms@kernel.org>,
        Konstantin
 Khorenko <khorenko@virtuozzo.com>,
        Sudarsana Reddy Kalluru
	<sudarsana.kalluru@cavium.com>,
        Netdev <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXTERNAL] [PATCH 3/9] qed: avoid truncating work queue length
Thread-Topic: [EXTERNAL] [PATCH 3/9] qed: avoid truncating work queue length
Thread-Index: AQHagCfC+qakUE/9NUWNrCxJqKFS87FLnkwQgAAZ6oCAABoNIA==
Date: Wed, 27 Mar 2024 17:08:21 +0000
Message-ID: 
 <CO1PR18MB4666CD328AFA8B8EE49B389AA1342@CO1PR18MB4666.namprd18.prod.outlook.com>
References: <20240326223825.4084412-1-arnd@kernel.org>
 <20240326223825.4084412-4-arnd@kernel.org>
 <CO1PR18MB4666DF3B7684D340C3A3646DA1342@CO1PR18MB4666.namprd18.prod.outlook.com>
 <6242198a-8559-4465-918a-36442ea03e32@app.fastmail.com>
In-Reply-To: <6242198a-8559-4465-918a-36442ea03e32@app.fastmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?pJiH66A9yOeYcXXz2KyJ7km7JoQgZGLeupEHEugplWI7pX54wNtK/qo+6XTv?=
 =?us-ascii?Q?wvnFAgheHqFZ95i9khCZDveDZ2HEwjgCYVNJ3T31So3QxT4sfAAlK7npf/Ka?=
 =?us-ascii?Q?3aExjmTfu00VJAV3ChwR4i3BfA866+hpsPE7caTMbn9bFCvI538y9gWENoEq?=
 =?us-ascii?Q?tTvMEtI58amqaJdjGk01HR7KSuP66hBtgG/kQIXDoD02c3SXZyHs10q8rC21?=
 =?us-ascii?Q?PpY0uCscOrkFNA4jNL4Z2+PDWsBTyvfS0xzvwMEh9VqjPAxMslXzgCJqXli6?=
 =?us-ascii?Q?7+LI+H/cd262nyD78n7Xzku0u6ncSfxaePTRmSoSOY6E5lvfO3/IwddGtd8T?=
 =?us-ascii?Q?j4Sx+KVd3t1xx+jHiQ3lXgI4nVIklY+oGyORzaGWzC32MtvikH2kSbFmmT5D?=
 =?us-ascii?Q?7c82WP4JZ17S3jPI/wDoBHND8j0s5DCxtGeur3QocRMkhS1NdzrZHkRY0okZ?=
 =?us-ascii?Q?jzhS2HbONxNEDzDVFArPBL415FgCdlkMMtzXmK9e40mI2yEBSHMIOpV1iISy?=
 =?us-ascii?Q?zbfGLjqk3zOy8nGsaCTjCUEdA27w3O1V885A+tWD645uoXB0B1C9PxV4ar+9?=
 =?us-ascii?Q?7NQOK1m6WHWCIPuo8GwFgzpUt7ZRwHMOjOhlWhNYhlEPZXAnw0ingOHL280Q?=
 =?us-ascii?Q?QV8R8o2upHIl5zgS0YbhOixV7QCa8GzNuygKsiyL+QKLedeNZi/M4IJ2vuPx?=
 =?us-ascii?Q?jvltEqFsFhRCNq6hdEeZqrJRS1oaXeRz9B62QyCbDqhkkQpzSF8IisbYcmIq?=
 =?us-ascii?Q?kps1fWBmOgcgGpfiqOEhFQJGC2xvwzFUr/v2CbQcPzicgsWVv0Rl1h9DVBCz?=
 =?us-ascii?Q?6wQOOwZDJdNXMLwRFqe8EtsSciAhOBZk9WfIQHyRaDZt02qc9QZ1FgRVYp3s?=
 =?us-ascii?Q?vdL2bn1e7J7GDLlbKG9I7bIhF+mm9BmRlVhXqLyLnU07xHxnK0WuXrFRClEl?=
 =?us-ascii?Q?REV+dmNrGdfBWFIa8NqfVQfMkzzPPAb1QQmpMESw7ppUCcS19GopmKepIqxX?=
 =?us-ascii?Q?Dxm97egUIYQmft6r6hJdMDWoDrZ2W8/kRzcKjyYpr1TukJnu2cjuwYMv+h0E?=
 =?us-ascii?Q?z4fUS5Wlo5g0XevIjDHIeztCk4c3zy5xiWpojSY7HB3BqYBsh3yYv5Uxzcv4?=
 =?us-ascii?Q?Ig026inyFHQdK9fvXll3SOxHSp1uwONUHDrjeH7PYER6ZyOt3BVJeQ8qMTfC?=
 =?us-ascii?Q?hGu6l6qW473/xZ5mgYZrYLYRSDZiwClwMoF/lE6nvNCWTyuX8j4+YvIah0Ns?=
 =?us-ascii?Q?OQl9uwW8ZPbvAaldtTYVFpyBt1XD4khQa1YPVXqBKTOrNBOTLmQXqLWkoDeF?=
 =?us-ascii?Q?ngEyGk3PQpMvkhnhsBnsGjuH6QXzARDv770nCTbfFdGfbAmpLc0qBiSw/6TP?=
 =?us-ascii?Q?oZ4cesHc13wC24jwWyMihjvB4Dteo3ragauqBSeidDn2aaQbI7a9gJI5faUL?=
 =?us-ascii?Q?F5IFWoRPNKv00sImGbAcH61hrVVcKQx0tD46f3o3pqxB2RrUDjNwao+zDV4a?=
 =?us-ascii?Q?T3T6MINhtGWTvimHS+x8wvmFKl5nhBIn3oTIxwKdaVTXAofPpoZMBfUg9l3t?=
 =?us-ascii?Q?tRnAmfiMgl90ONT372lR8tzuZaqGOI4sBWjTCbtT?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR18MB4666.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 019c2e2a-3f18-46f5-3401-08dc4e808160
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Mar 2024 17:08:21.2505
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gZ7+wPCJKqPh0L/U6X3OW5/i95UXQNEe756hPX5oA9s5+7xZuenNVvrL8PoDLNYRnp7sEOPrxuN/iYWZw7/CUg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR18MB5146
X-Proofpoint-ORIG-GUID: ibsyrP8y627W6eK70XDI9Ue7-4QGo-mO
X-Proofpoint-GUID: ibsyrP8y627W6eK70XDI9Ue7-4QGo-mO
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-27_13,2024-03-27_01,2023-05-22_02

Hi,

>-----Original Message-----
>From: Arnd Bergmann <arnd@arndb.de>
>Sent: Wednesday, March 27, 2024 9:05 PM
>To: Subbaraya Sundeep Bhatta <sbhatta@marvell.com>; Arnd Bergmann
><arnd@kernel.org>; llvm@lists.linux.dev; Ariel Elior <aelior@marvell.com>;
>Manish Chopra <manishc@marvell.com>
>Cc: David S . Miller <davem@davemloft.net>; Eric Dumazet
><edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni
><pabeni@redhat.com>; Nathan Chancellor <nathan@kernel.org>; Nick
>Desaulniers <ndesaulniers@google.com>; Bill Wendling <morbo@google.com>;
>Justin Stitt <justinstitt@google.com>; Simon Horman <horms@kernel.org>;
>Konstantin Khorenko <khorenko@virtuozzo.com>; Sudarsana Reddy Kalluru
><sudarsana.kalluru@cavium.com>; Netdev <netdev@vger.kernel.org>; linux-
>kernel@vger.kernel.org
>Subject: Re: [EXTERNAL] [PATCH 3/9] qed: avoid truncating work queue lengt=
h
>
>On Wed, Mar 27, 2024, at 15:04, Subbaraya Sundeep Bhatta wrote:
>
>>>-		snprintf(name, NAME_SIZE, "slowpath-%02x:%02x.%02x",
>>>-			 cdev->pdev->bus->number,
>>>-			 PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id);
>>>+		hwfn->slowpath_wq =3D alloc_workqueue("slowpath-
>>>%02x:%02x.%02x",
>>>+					 0, 0, cdev->pdev->bus->number,
>>>+					 PCI_SLOT(cdev->pdev->devfn),
>>>+					 hwfn->abs_pf_id);
>>
>> Confused. This should be alloc_workqueue("slowpath-%02x:%02x.%02x",
>> cdev->pdev->bus->number, PCI_SLOT(cdev->pdev->devfn), hwfn->abs_pf_id,
>> 0, 0);
>> Right?
>
>I still think my version is the right one here, see the
>prototype:
>
>__printf(1, 4) struct workqueue_struct *
>alloc_workqueue(const char *fmt, unsigned int flags, int max_active, ...);
>
>so the first argument in the format, while the printf arguments
>start after the flags and max_active arguments that are still both
>set to zero.
>
My bad. Got it

Thanks,
Sundeep

>      Arnd