Received-SPF: pass (google.com: domain of linux-kernel+bounces-121649-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <09fdfc0a-285e-4f1b-9d2a-d7b9b97dbbad@intel.com>
Date: Wed, 27 Mar 2024 17:49:27 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v6 02/21] lib/test_bitmap: add tests for
 bitmap_{read,write}()
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Yury Norov
	<yury.norov@gmail.com>
CC: "David S. Miller" <davem@davemloft.net>, Eric Dumazet
	<edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni
	<pabeni@redhat.com>, Alexander Potapenko <glider@google.com>,
	<nex.sw.ncis.osdt.itp.upstreaming@intel.com>,
	<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
References: <20240327152358.2368467-1-aleksander.lobakin@intel.com>
 <20240327152358.2368467-3-aleksander.lobakin@intel.com>
 <ZgQ_rP5KnMfL-0b2@smile.fi.intel.com>
From: Alexander Lobakin <aleksander.lobakin@intel.com>
Content-Language: en-US
In-Reply-To: <ZgQ_rP5KnMfL-0b2@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a3BGTVVPMnhudFN1NmJyTmticTFWT0tub1FOMXhPaENmc0d5NUFJd3ZoRFdI?=
 =?utf-8?B?TEJnc2lMRFVuL1FTSHcyd3k5TytqcXhkUVN1V2ZZNnpJcW9VTzNSVXJNM1l5?=
 =?utf-8?B?MVdLeXJGem42NExkWUg1Uk5WN2VBWG5GVnZaNnB5Vy9SMDg0dXhRa213eFNu?=
 =?utf-8?B?RVhvZEdSRW5ncVM5WmFxWXowSVZlNHl4Zytya1Fkd0lWSU9Qc0hiME9TWUJU?=
 =?utf-8?B?U04waHE3aWJOR2pheFVucFZUWGY1b1drNENmaGJ3QmZPbFRObXYwcWJROVdC?=
 =?utf-8?B?djBUcFdRYjQ1WWVCOGZ6THZlUXdFZnZyQkZFYnNDbTZZVi8yMEJrcDZOSFZh?=
 =?utf-8?B?bGFUUkcwUE5rbGIxL1VTWGpiLytZM0ZFempuWGl3emJ2SjZmT2RGRk1PMUtx?=
 =?utf-8?B?UXlqWHRXOS9jaVozS3J4TVV2dEs5ZTFQMHR4b1hnM1c3SWJWV3YrTDlXVUl6?=
 =?utf-8?B?WnNTUkVMa2ZBckRkZiszS2JjOUw0U3lkQWRmMFd5b1hGTVgwOGg1MGoyRG5u?=
 =?utf-8?B?cjVna2J5SEV1Ukc2eE9SdVhyT2o2aFEzbEtvYnBtRFZ3VHZTblNvQUZobUl3?=
 =?utf-8?B?Um05MFNENnM0UVBzaCtTVWhXVys0amNFS2ovY0VJUmJGSGhxOWFEaTFEcEx6?=
 =?utf-8?B?Q0VoN2VsZ3BSdmxMbFFtSkRXV2d0NjVlNHVOV2sxeDMrZllpMDc1aHh5U0xt?=
 =?utf-8?B?UUpxTWc1TEgyWE5QcjJlSDh2UW0rY0U2OTJpNUZHSVBzbDBDZFMvNmxETDV1?=
 =?utf-8?B?T1ZQU0dxY1ppWFFBVEhQWmFHVXd4OHk4anErdFhhSlFwTGRJT1ZleWdtcm1W?=
 =?utf-8?B?VXl0WXJLaTJia1diZ1BKcjRndWtvdlYreUdHRi9uaG9uVjJQZTVkM25aUmVv?=
 =?utf-8?B?MCtNakNNWXQxdEVKaC9NdlZnZzdWd0gxWlgrTS9WQmFzNksrTGFKdTJrM1A2?=
 =?utf-8?B?NXVFTlg4MzQ3YXo4YWJWM0YyQkRpamY2QWJYTWdnSGU2SlRNVWNDNlFtaDNs?=
 =?utf-8?B?czJiN3RwTUJhWVB2dld5UDRPT1laWURnRlVwcE4zY25yYlJvTW5CdGl3RXgy?=
 =?utf-8?B?YjR1cmtkbVdrK3NYL3JtSTVLeVNGMlpIMUd5K1FQaEFVYml2aFZ2ajB6c0Qz?=
 =?utf-8?B?UEV2YTFHSjgrRjRBcjVMYUhFS1RUTk5ZdmdkZWlyTllhNGVNZDNPMG1OU1c4?=
 =?utf-8?B?Z1RydUY0YklvY2lvM1lHNDU4Tm93ZTBwdzRCMVVSWjdpVjdaUmYvNkRXeDl4?=
 =?utf-8?B?VzBiRzNKcUJTeUsrM0NFNFRWTHhGbHdjSkJQVURZTGo4d29EMVQrM2d5Z2VN?=
 =?utf-8?B?a2RTcUgyRS9yWVg3VlRpNGJRMkYzTG1aRjJ5SDJDTVhYcjJZRWEvMHcxYWZO?=
 =?utf-8?B?a0laZHRvRnpOejFOcjhUSnF0enJzaEZVTko5SWdDelNJZDZlVGNEZ0hFT21s?=
 =?utf-8?B?NjBGV3Jxam9kMVJmSE11MEgrSzJ2d200dmhhenFRYUR5Q2VtWWJsbnpyS2R5?=
 =?utf-8?B?ZWVZd1ZwZ2E0a1lJNGlFVyt3NGdhNE1Ba1ptOWRWNFJ5dEZKakdOUnhzaVNr?=
 =?utf-8?B?cUltVS9INDM2RXprbXpiRjdhUWxBTHRzK1MrWm5hOUozYXlROXZCOUVwaE9W?=
 =?utf-8?B?N0MwNTZMSlN2RmRPcWk0RVBhWENsVTUrYlhLcU5zUTErRXNab29sS2Nwckg3?=
 =?utf-8?B?czF2aVljbGVTaFpINW9WczloeWJWZFpPMjA4V2hycktuNURpZDlaUVQzbHF0?=
 =?utf-8?B?WlJNWlIrVXpsUEV0SUR4R1BVaE9rNmhnY3grTXpYMEdoZ2lZenRUbjZTTkF2?=
 =?utf-8?B?OXNCemtQemVnQkZZNUJYdXFCRVl1U0J2a3RVNlFhazJQZXNWNTNDTC9MVDZq?=
 =?utf-8?B?c09XS2YvYVU0M283QlM4RjR4QUZIUE8weUJyY1RMTHRmQWhQWG5YMGZCTVFH?=
 =?utf-8?B?aTZlWnJxcGxwTGE4SFhtS3h6WUlpak0rRGFubkxYY0FaSFFpM0t3b0VhNUdz?=
 =?utf-8?B?end6bXYrejdLZUYxL1p5L2FyRG9walZFNHhHM2R0QUJpYUxiaFE2NHg4emNW?=
 =?utf-8?B?TG1LaW00WlFtb1U0YmtXZWFyQjlCakJUaEN0T1Rxc2RmNjl0L3FKY0ZuaFVW?=
 =?utf-8?B?alBUZTJ5aXVCNFhIMEhpckUySU1tZDFIR0s3d3hIekJycDFtdHZVc0pvempu?=
 =?utf-8?B?L1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 235fce09-520a-473c-bff8-08dc4e7de61c
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB8718.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 16:49:42.0308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jLDC0Wec4wTv1x1rJJJy6bUdEtTlx548t6hVhVguszDXIsxpd8YVIJHSJPoV49h7XULxm+t1BuVjPcy9mdK69dtEVpcygJk3nx17u+6oTr4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6873
X-OriginatorOrg: intel.com

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed, 27 Mar 2024 17:47:56 +0200

> On Wed, Mar 27, 2024 at 04:23:39PM +0100, Alexander Lobakin wrote:
>> From: Alexander Potapenko <glider@google.com>
>>
>> Add basic tests ensuring that values can be added at arbitrary positions
>> of the bitmap, including those spanning into the adjacent unsigned
>> longs.
>>
>> Two new performance tests, test_bitmap_read_perf() and
>> test_bitmap_write_perf(), can be used to assess future performance
>> improvements of bitmap_read() and bitmap_write():
>>
>> [    0.431119][    T1] test_bitmap: Time spent in test_bitmap_read_perf:	615253
>> [    0.433197][    T1] test_bitmap: Time spent in test_bitmap_write_perf:	916313
>>
>> (numbers from a Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz machine running
>> QEMU).
>>
>> Signed-off-by: Alexander Potapenko <glider@google.com>
>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Acked-by: Yury Norov <yury.norov@gmail.com>
> 
>> Signed-off-by: Yury Norov <yury.norov@gmail.com>
> 
> This is a bit strange.
> Can you explain the SoB chain in this patch and similar which have Yury's SoB?

Yury gave me them in the previous thread ¯\_(ツ)_/¯ I didn't ask why.

> 
>> Signed-off-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> 

Thanks,
Olek