Received-SPF: pass (google.com: domain of linux-kernel+bounces-121685-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 27 Mar 2024 17:19:18 +0000
To: Wedson Almeida Filho <wedsonaf@gmail.com>, rust-for-linux@vger.kernel.org
From: Benno Lossin <benno.lossin@proton.me>
Cc: Miguel Ojeda <ojeda@kernel.org>, Alex Gaynor <alex.gaynor@gmail.com>, Boqun Feng <boqun.feng@gmail.com>, Gary Guo <gary@garyguo.net>, =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>, Andreas Hindborg <a.hindborg@samsung.com>, Alice Ryhl <aliceryhl@google.com>, linux-kernel@vger.kernel.org, Wedson Almeida Filho <walmeida@microsoft.com>
Subject: Re: [PATCH v2 10/10] rust: kernel: remove usage of `allocator_api` unstable feature
Message-ID: <2b148cfb-0557-46de-b39f-f2506eb17afd@proton.me>
In-Reply-To: <20240327023531.187880-11-wedsonaf@gmail.com>
References: <20240327023531.187880-1-wedsonaf@gmail.com> <20240327023531.187880-11-wedsonaf@gmail.com>
Feedback-ID: 71780778:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 27.03.24 03:35, Wedson Almeida Filho wrote:
> From: Wedson Almeida Filho <walmeida@microsoft.com>
>=20
> With the adoption of `BoxExt` and `VecExt`, we don't need the functions
> provided by this feature (namely the methods prefixed with `try_` and
> different allocator per collection instance).
>=20
> We do need `AllocError`, but we define our own as it is a trivial empty
> struct.
>=20
> Signed-off-by: Wedson Almeida Filho <walmeida@microsoft.com>
> ---
>  rust/kernel/alloc.rs         | 4 ++++
>  rust/kernel/alloc/box_ext.rs | 3 +--
>  rust/kernel/alloc/vec_ext.rs | 4 ++--
>  rust/kernel/error.rs         | 4 ++--
>  rust/kernel/init.rs          | 3 +--
>  rust/kernel/lib.rs           | 1 -
>  rust/kernel/str.rs           | 3 +--
>  rust/kernel/sync/arc.rs      | 4 ++--
>  rust/kernel/workqueue.rs     | 3 +--
>  9 files changed, 14 insertions(+), 15 deletions(-)

Reviewed-by: Benno Lossin <benno.lossin@proton.me>

--=20
Cheers,
Benno