Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp206325lqo; Wed, 27 Mar 2024 10:40:20 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCV9Zr/rII0x3BQ0Qm5dMgsZVDB8967OpJq7dYFJSu8C3w5U5s7dztgzplHg3cJgTCMNo/F+eYiexo6k+dhXg+pqMidSgYgjU0RBNzeLnw== X-Google-Smtp-Source: AGHT+IFAnpUYcGB2aMbHz5fV5xhYaLK72m7YGybSqHr0GMa21/ujcMXq8zIdenKDDg+vMayX7gS9 X-Received: by 2002:a17:907:9812:b0:a45:f209:d2cb with SMTP id ji18-20020a170907981200b00a45f209d2cbmr281405ejc.28.1711561220651; Wed, 27 Mar 2024 10:40:20 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711561220; cv=pass; d=google.com; s=arc-20160816; b=0MC6FJjpm63G6QfQHcO9NyVcVd3YfOU450OQkOwoDsmUhz16EXjIVlnC/IW5MYPjTn +pIQwfzJyTd3KedxVW9Pkhd/vocSjtcvno4+6rZ0vn9Pu4XWEQ5qSFMtj04IBFFU0p4q VFOKtgYUorS2bXZZZhyD0Dw168WWg6PEXTm6PpvvkEL0u4iLOi/GuWaVjSgm/R8DPyox pmSPcTz2ay7GkO7uEniSe+pKdYBPNcIZ1LK37a6t9Sjvdu8ke8bTh1tTJoKXhmuRa4Kg XpxaEEWS8+/gUP+zneaJi69C9Ze5GyN2RLwEYLZP8ymXCH2D3oBaBUA2fODv5fbJgHJ8 7xLQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=9gUhvWDGuBI65NBfJdGMw/ZAutbEHQFUXBDUQkIrlrs=; fh=sKAvjEFwp/EjTapXp2SoQL7PzbgC1FV2o6zkkCq15LE=; b=vMegfPN3E0DMhpxBZ7A7HDn8s71isO+M+exlXc2V+MfNuR/dPebjr6m1V5k+CTQyvt O+VnfN7lCPfVp5J0UhgpLni0ViOgQyNr1nBZ4Jclz4nU7F4oO23AOMWlGDC94LETjFMi pcVWRtqpZcwcUexii1448UfW6Z5+iXMFqC5Nuh+PUYqJxeX6OJ5Cin1nZ2VmqX2ViTmv 5UpPswt+1fogG4RDSMMCxhd4yxjwH0P9aBV4Ot6eKkosnAAd82h1WEa3JBspaZH5D4wr shnsSUDMmzLTjjUDTq/WfUCSLRSJy3iGU1ea3enxE/ulqg0OCcoFOFZhqGMLjm+syduC K1KQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Lyan0XKk; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-121708-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121708-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id gs8-20020a1709072d0800b00a4df4418bcasi1982088ejc.283.2024.03.27.10.40.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 10:40:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121708-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=Lyan0XKk; arc=pass (i=1 dkim=pass dkdomain=linux-foundation.org); spf=pass (google.com: domain of linux-kernel+bounces-121708-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121708-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 656A11F2699C for ; Wed, 27 Mar 2024 17:40:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 55C5814D6E7; Wed, 27 Mar 2024 17:40:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Lyan0XKk" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E53412E1F0; Wed, 27 Mar 2024 17:40:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711561211; cv=none; b=DefaHdq3BTh2bEImWUWaJED67SbWbohjzGec8h67/qS9AgfuTWog7PgGgL+rxp1tgcdiVLxR9Ky1yCRAN9dGwvhc/CN9H5BVokA5T3J7lbXZLd6DcbrptNdVbPMN7NheTiomTs4KesUnt2ymAgIfqqOaqfSHIcbReqvm1I6CSgo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711561211; c=relaxed/simple; bh=I6x60ia+rggB1OgVHo+pcCe2/5EmZUntXUlWS6xFGsQ=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=m5cb3blqgbItv5QQMCzeIEwIVmCJU+Tz05RpnNoFAL43GT0X8ezwQ01gbqDs3jtWLcEuU3glxZiCZFgenKfLMqUaobQuW7WwjBxGdHcJPbPjaQUGv5yZZy+xSCsTBxJD/6u60iGPs4rD46r1Z2QSsjRxGZFeTuBzubk3W5mNkCM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Lyan0XKk; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB2EFC433C7; Wed, 27 Mar 2024 17:40:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1711561211; bh=I6x60ia+rggB1OgVHo+pcCe2/5EmZUntXUlWS6xFGsQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Lyan0XKkyPAmuDpmWQRdO4kPwUWsHKKFPRzR+jFMTZhBNdgDY1mzOh8Zvhp4h94Hf VQ0ynNWRsVmi8yXVhWA+xbqA28k23Dd1JQMjKNX4Jw0ahspmVHeKybdifIdb4XAofD UjdseAN13zD79wSDoh/4LweFnooobhxtunWjgEkM= Date: Wed, 27 Mar 2024 10:40:10 -0700 From: Andrew Morton To: Kemeng Shi Cc: willy@infradead.org, jack@suse.cz, bfoster@redhat.com, tj@kernel.org, dsterba@suse.com, mjguzik@gmail.com, dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 0/6] Improve visibility of writeback Message-Id: <20240327104010.73d1180fbabe586f9e3f7bd2@linux-foundation.org> In-Reply-To: <20240327155751.3536-1-shikemeng@huaweicloud.com> References: <20240327155751.3536-1-shikemeng@huaweicloud.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Mar 2024 23:57:45 +0800 Kemeng Shi wrote: > This series tries to improve visilibity of writeback. Well... why? Is anyone usefully using the existing instrumentation? What is to be gained by expanding it further? What is the case for adding this code? I don't recall hearing of anyone using the existing debug instrumentation so perhaps we should remove it! Also, I hit a build error and a pile of warnings with an arm allnoconfig build.