Received-SPF: pass (google.com: domain of linux-kernel+bounces-121835-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <85b023d3-1522-4f82-86d2-8728c71b120c@oracle.com>
Date: Wed, 27 Mar 2024 18:34:15 +0000
Subject: Re: [PATCH] selftests: iommu: add config needed for iommufd_fail_nth
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Muhammad Usama Anjum <usama.anjum@collabora.com>,
        Nicolin Chen <nicolinc@nvidia.com>, kernel@collabora.com,
        iommu@lists.linux.dev, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org, Kevin Tian <kevin.tian@intel.com>,
        Shuah Khan <shuah@kernel.org>
References: <20240325090048.1423908-1-usama.anjum@collabora.com>
 <31fcc276-acd6-4277-bd6c-4a871c7fb28a@collabora.com>
 <20240326150340.GE8419@ziepe.ca>
 <56cc8b9e-c1cf-4520-ba45-b1237e8b7b64@collabora.com>
 <20240327114958.GG8419@ziepe.ca>
 <51f493a9-08e7-44d8-ae4a-58b2994ea276@oracle.com>
 <f78b685d-a147-4b59-beb2-cde9d34ce22a@collabora.com>
 <e9cb60bf-5035-4fed-9b36-ca2edf048fe8@oracle.com>
 <20240327182050.GA1363414@ziepe.ca>
Content-Language: en-US
From: Joao Martins <joao.m.martins@oracle.com>
In-Reply-To: <20240327182050.GA1363414@ziepe.ca>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?Zi9HRGRRNFpRTExvNiswbHFJZHo2M1djSHdNeEFzNFI3VzhpWmZBd3ZqdEZz?=
 =?utf-8?B?WDMxUVludmEzRC9NQ3JULy91TUx4cmxXZjhSWkdSUG9jVTU1cHprOThTdks0?=
 =?utf-8?B?N2wzUnZVOHRPbStrdVovZld5aVJCazRMYVhMQ0ZzR04ra1VsV2tKY2V1Tmxm?=
 =?utf-8?B?anNpand5ZnpDdzZacnZFVE10eFNQelFuSzFkVzcxZ2xEOC8zNFJWd1Zwcjhh?=
 =?utf-8?B?djh5L2J0VWZod1ZuNDZ3Qjdrb2NLMmZZWlhnSDVBTlFHSTRDVzUwclZobEJ2?=
 =?utf-8?B?M0REMXFWRk0wbFVtK1E1ajZoT0syNU56eVZESlMyTlJnUWpTd2xpakRTbXVI?=
 =?utf-8?B?WWhaUk5qWS9PbkVvdm9mWWNWbG5oUys3TG5oQ2J0Qmp1ZVdrcUF2VElRbjVo?=
 =?utf-8?B?c29QWC92TmFDZkdVN1ZvNTVMaExOVmRVamdXV05BUXNpNGZweWppayt0d0Rv?=
 =?utf-8?B?K1djSDhUeSsrazNXMnhzL0xJZ0x6Z3JNcURPeTQwQmpIYkYwQTZZYUtUZWNB?=
 =?utf-8?B?NGN3ZEdoTXFUUmROZ0k4djZqd1MxR2YzcHJQU2tSMHZCUGRBWVd3aVk4dmtP?=
 =?utf-8?B?c09sc1d5Q2d0R3AvcUFPaU9VRmx2ZTQwRVBmaFlqaEdvSnFXWHZpTERuenZH?=
 =?utf-8?B?enZxT0k5ZnNYTXM2T0hnaE5tSHFjVmtDSVU4RWRCVU5WditSNVUrTXdQRG5O?=
 =?utf-8?B?OHZyTEpOMUZGeGt3cHczdGw1VVZpTnJBZHlLL0lQUG1ZUjdHVGJweFNUV01I?=
 =?utf-8?B?a3JiM3VWU09DSG5YQldsMFYyWlZLS3ZiUzQ3b21GR0g1dlM4TUZTZnFTaEh2?=
 =?utf-8?B?eVhQSy9jekdocnFJY3hKRlFlWm52YjQ4SDFwL0ZNdlVsYldqVXJ4b0NhSk9T?=
 =?utf-8?B?K3ZHTHNWUWNLQStaUVYrMmZObjZ4N1dUcnNJOXBXNEpCRU5WbDMyNGdLV2w1?=
 =?utf-8?B?SlhUSHkraGtWckZRNVVZVTVjam5wS3BwbkdIekUzbzQ4S1NZZnZaK3ZrRU9y?=
 =?utf-8?B?OXZRYUxwTnJ0NVlUa1FSSlBoTVFRVThWUENOZklBcXlUaUJNWStab01NYUti?=
 =?utf-8?B?ckwrVi85dHN0VjY3MFBpM1hJNjRtSGhvbTdReis2NGRlTDgwM2lMZDJRSEp6?=
 =?utf-8?B?MUhLTzhIZHpCTlRkbjRwRHU4eDFZb0dOT1FmUXJ4Um9uWnNuZEJZMnV1TEdO?=
 =?utf-8?B?aFpHYnQ4d042TEJMcWIyMFg1Zm4rK21PRTIvSDFRQ2d6WHJjU2xNWGhZS1lZ?=
 =?utf-8?B?ZVpiUnl0YlNta0JLM0x4NDBJaFdWZXFDL3hXcWxlYXVhOUF4ems2VysrLyt3?=
 =?utf-8?B?NTRIaWlRakl3RlcrbWx1N3Y2K3dYRHNZSG9pY1RWYTVadDV2Wjl0bWpjRnVz?=
 =?utf-8?B?SnNjN0hUUVl2RWdmZFVzMThIWXpTdXJZNG5NcXd0aTJBalIxVHlsSGVwN1li?=
 =?utf-8?B?SVJiOWFROElDZXJNUmdSTnVaVEdIZ2dmRE1qVElTYVVFOTNXcDMyL294eGZC?=
 =?utf-8?B?bUlGdzBaSml6b0ZGbC9kbHI5dU5aUzFXNXRTNzRjMithWXphMXBRb0U4YUhO?=
 =?utf-8?B?aEovVlNvRkdIU1ZxZmFnU1Z5YWEzOS9JZEhFNE55TUk0VWVvSkxSMjArZDZj?=
 =?utf-8?B?RnhHOUZiUStVRm1pejQrQmpQaGcwNzZNM2tvZjRmVDJJM2o0aFc3TEd5K2tS?=
 =?utf-8?B?RmJ1eEQ3OTVIOHNoc2p2di9xSTQ3c1RoSy83QWFiSVhkWDZYaE5kY2xVSVMy?=
 =?utf-8?B?a0R4cVUyTTU0YllVU0xhRlkzQVFHR3hKd0pDd2krR3JuNldxVGViejR2TTkv?=
 =?utf-8?B?ZEhQMmYxZGxTejgxVThKc3ZiRUZ6dklXNVBUMEtiSGxGZ1l1T1l0UGxBblpt?=
 =?utf-8?B?YndUcCtPQVR2ems1NW8vUTZjalVXeGowWUlQN1pKbFRmdllDT0Q1cC81elRa?=
 =?utf-8?B?czZtVUtBZHQ2aURrTmdjbThNL2NnMnZiVHpIblJxMXF1VUZjN3dXK3l1alpn?=
 =?utf-8?B?dHJiVzZGNWYxbkQ5NWpqbDBRR2g2dDFIa0FUV05xb0pZV1BKRWNnYnkrN1dp?=
 =?utf-8?B?a1ZUT3NhbThmWEZYWER0U0NjR3dYSHhuNjFZbnl5eDAwNmxWOE84Q3crQTNK?=
 =?utf-8?B?ZmV5dWpVU2lwT2VTWDNFNjhJd1lWaXJlVFV3bjV0aWU5M3Q1Y2t0VEZFK0Qx?=
 =?utf-8?B?TFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	ZuE7jUJN/sprYe7t+GKZpkGlT7WYne8v/NH1iNiv2IFyg4aL2xWqJE+aqNj8l4mIDr6mWuTk3v52ZGq13L0f5+NQSy/CaZKgkB3gmgKdZBkxUHIDHHfjvUIN7RGgeOTypGwo1S27zklAVoML4D2NoS2/K2ltKa8fSBZ4Xfc5kdYCXdBj+oKNl6V+t1GxCNE5D9FTb4CM4kSgSwosZlOnHMGBEH41aiRD0X5b1wiHiNQWRryWGzfzfcmrhsmqizxY/gMZkjtmqbf8/CbzuvzRPxW3APY6HpngLYUpSvA25Fu5JL7JKK7TGBX/48vtOgPFeE/ifh5AEb8F/t5YSZoFxrQn7T0AFBFxa8Y8UbzaGeSLLiyLraFCVrpugxjMOvxQD4y5HRUrUgf+TyCfILhTEJB+htHMqWYduVBxJXXmLDVDiyWcMxPF7jQ2ZWbzZrniip2cWGxXZciU5AwMHdsoS2ZvYXYF+w2k5G2+pyiyMktZR9XARqC31MDPUhrQqzn7Ti15Ia9w2TiFtGdt/ChPoixWuZrK0QJ8iQJHY4KyxRoq6IQJE8RN97BhOmp0io+Y7IHUmaYaqBZM3Pr+OCp5PenZm/mM177bpl53ZF+09W4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 33457d0e-70a6-4fbb-ec48-08dc4e8c849f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB5893.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 18:34:20.9818
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: revGfU3uh5AAb3inOIdpq9VVbHHPE6ScdWnyT3hV3A0MeQAPwMy2QWLddEeyc6SQlzKasnfuqzy2fA9qJVkFTX8LZXUEkdY6GfBVYVgqsHc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB7004
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-27_15,2024-03-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 suspectscore=0 mlxlogscore=872 mlxscore=0 adultscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2403210000 definitions=main-2403270130
X-Proofpoint-GUID: cz39ALRNhKoAHK0EpRbkGBs-nuhwEgyz
X-Proofpoint-ORIG-GUID: cz39ALRNhKoAHK0EpRbkGBs-nuhwEgyz

On 27/03/2024 18:20, Jason Gunthorpe wrote:
> On Wed, Mar 27, 2024 at 06:09:37PM +0000, Joao Martins wrote:
>> On 27/03/2024 17:49, Muhammad Usama Anjum wrote:
>>> On 3/27/24 7:59 PM, Joao Martins wrote:
>>>> On 27/03/2024 11:49, Jason Gunthorpe wrote:
>>>>> On Wed, Mar 27, 2024 at 03:14:25PM +0500, Muhammad Usama Anjum wrote:
>>>>>> On 3/26/24 8:03 PM, Jason Gunthorpe wrote:
>>>>>>> On Tue, Mar 26, 2024 at 06:09:34PM +0500, Muhammad Usama Anjum wrote:
>>>>>>>> Even after applying this config patch and following snippet (which doesn't
>>>>>>>> terminate the program if mmap doesn't allocate exactly as the hint), I'm
>>>>>>>> finding failed tests.
>>>>>>>>
>>>>>>>> @@ -1746,7 +1748,7 @@ FIXTURE_SETUP(iommufd_dirty_tracking)
>>>>>>>>         assert((uintptr_t)self->buffer % HUGEPAGE_SIZE == 0);
>>>>>>>>         vrc = mmap(self->buffer, variant->buffer_size, PROT_READ | PROT_WRITE,
>>>>>>>>                    mmap_flags, -1, 0);
>>>>>>>> -       assert(vrc == self->buffer);
>>>>>>>> +       assert(vrc == self->buffer);// ???
>>>>>>>>
>>>>>>>> On x86:
>>>>>>>> # Totals: pass:176 fail:4 xfail:0 xpass:0 skip:0 error:0
>>>>>>>> On ARM64:
>>>>>>>> # Totals: pass:166 fail:14 xfail:0 xpass:0 skip:0 error:0
>>>>>>>>
>>>>>>>> The log files are attached.
>>>>>>>
>>>>>>> You probably don't have enough transparent huge pages available to the process
>>>>>>>
>>>>>>>       echo 1024 > /proc/sys/vm/nr_hugepages
>>>>>> After making huge pages available, the iommufd test always passed on x86.
>>>>>> But there are still failures on arm64. I'm looking into the failures.
>>>>>
>>>>> Oh that is really strange. Joao? Nicolin?
>>>>>
>>>> Definitely strange, I'll have a look.
>>>>
>>>> So it set the expected number of dirty bits as that assert doesn't fail, but it
>>>> is failing when we check that even bits are set but not odd ones. Like it's
>>>> hasn't set those bits.
>>>>
>>>> For mock tests there should be no difference between x86 and ARM assuming the
>>>> typical 4K page-size. Maybe this is 64k base pages in ARM? That's the only thing
>>>> that I can think of that affected mock domain.
>>> The config is attached. The defaults are being used i.e., 4k page.
>>
>> Looks like CONFIG_IOMMUFD_DRIVER is not defined :(
>>
>> Thus no bits are being set.
> 
> Oh! 
> 
> --- a/drivers/iommu/iommufd/Kconfig
> +++ b/drivers/iommu/iommufd/Kconfig
> @@ -37,6 +37,7 @@ config IOMMUFD_TEST
>         depends on DEBUG_KERNEL
>         depends on FAULT_INJECTION
>         depends on RUNTIME_TESTING_MENU
> +       select IOMMUFD_DRIVER
>         default n
>         help
>           This is dangerous, do not enable unless running
> 
> 
> ???

Yeap. It probably needs a:

Fixes: a9af47e382a ("iommufd/selftest: Test IOMMU_HWPT_GET_DIRTY_BITMAP")