Received: by 2002:ab2:6991:0:b0:1f2:fff1:ace7 with SMTP id v17csp262244lqo; Wed, 27 Mar 2024 12:13:16 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWlYCtqf8gRVc2MMJZX5dmWyzg+x3Fy/ooYAKzxzql8HLVdNMIP2vTJEV+DWPIO4V8Mlvl6WQePaUf/FUs7GImOqSGRYr9ICNDOy8i99Q== X-Google-Smtp-Source: AGHT+IGde/7doUwIDk80FKhang1DSH6DoqaHNZ35WH+9yvBRJuu5EGYq3+mMh0BS0x6F1awH/q8m X-Received: by 2002:a17:903:11d1:b0:1e1:a53:c366 with SMTP id q17-20020a17090311d100b001e10a53c366mr766495plh.22.1711566796330; Wed, 27 Mar 2024 12:13:16 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711566796; cv=pass; d=google.com; s=arc-20160816; b=ET1CARnXyKPHlOLQJNAvePOZc2d5sq/6b/V0giLr9hilCVjabDDjzK2eVe7QY77Um2 EyIvirURDBSreZRiaRxH6M3gLLMsoq6ItBRLHJ192m7ZjqiRPkSswIc4RE1VKfLqVqa5 zkPm/wFPkWtJLMGprwNN4Sva1VSgSLPfLmseRAT+keeg1FG+w8DFlzklCvYor6jnYzCh rT1ro8yiF2qRVSzoKwan/plNeMOJ1SVjji5Ticu4IIxb4jWG5rF+/oVUDRsIWxQORgHm ACV2xzynpR3fESxOk/jeb1wBF60j80NbZSDbsBZ09zTyC/0au8j4vtTRxs4Umo6tCfun h3Cg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=OvYxg7uKiViFMj0Fb1A7MA/yt/o2WxqhbpEx4QUdMtg=; fh=NRwlJ284ToFbSKBkOTsblqGNTTWdNBBA2dEQ7V5r8oc=; b=fU2/w8xkQl3UhvIe1L3uyS9Z0sn75IBm6k1ETgQ52UPHHeIdzkVubYcgy9N/ihvJZV FZA5w4aJEaHVdxrC4d2XFuvvNm528Fb828aFsXmr+hNGAu78rB+xyqoF2lySj+SKrl1g SEL+cQJq210pR56pK63rMo4zN0E9N37sDrYX1deIXdyleIAKfH4/Khm+Kkmc3FAOE9hG MxYfGt5TdB1ESaETHrLFgcMUPxN1oDq32Y7LnRGca28LNb/cDaT2KyiW9wtFpOoIkze3 G+/k18WHf/aOEytXAeLxvC9UoKEqoS9ucDX3ZgF+DnEVjiAjrgPshrtacC/af4Zd1JgJ vhGw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="eGsYtM/w"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-121346-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121346-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id d3-20020a170903230300b001deffb0ccfasi10066383plh.240.2024.03.27.12.13.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 12:13:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-121346-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="eGsYtM/w"; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-121346-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-121346-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 2D373B2A11E for ; Wed, 27 Mar 2024 14:38:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E647015696B; Wed, 27 Mar 2024 13:10:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="eGsYtM/w" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E6F8134415 for ; Wed, 27 Mar 2024 13:10:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711545028; cv=none; b=TKGigzhqOhIvjugPmSe66gbwQoDhb1loPOITkJlOUS8wjBLX4w0WYzxjMGSM3NhzAkTRrCQP1xmhHmxMcFPlC7dDSLi4G7fmSEBi72if+djIz9Z/2xhTY2JqKx5YIaZd0vkWwFj+puQ1mH4xJgOb8Vmj4xmzZ1OKu3c79iZs7sc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711545028; c=relaxed/simple; bh=H3xadqQfDw/NU4PTfDU+D7Sbt/ALnmmUzI9ke2A9X7E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Wmn800Atln27lTIn/gFYrIBDZex++FK8auu6ZhsjShwzr/jb5WI1xesOOWys7+4wvBFHvBy6BWvSm6puzfyaDzEl+vqlox7U2z3qJouBSbWLwWJz8YXaQzO70euQ7SK9Pd6vdObYq6NA8OGHhJrv65bVcOrMf1UxIF0E6EH8qto= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=eGsYtM/w; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1711545027; x=1743081027; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=H3xadqQfDw/NU4PTfDU+D7Sbt/ALnmmUzI9ke2A9X7E=; b=eGsYtM/w9ALUKledNdg4DTWMbWfLOJ24I7JKsHHL388DY6Xg/x36TmaU gfk99o4VgWhHcW/4AMZxRFbcNSAO5Mr6WU1cgY0+tKiFjp/R6ztsVSpZX A+Eq3hlUQqg80m3VNPcNryPoXuKtzAei1OaCHHZaxDyEm45mlohDgCZL2 wHxAlsggHavsImawKFyEbQf7qRJcY0Sm0ek4QCElRQCg1c9ZJHTADyi8K f8uU2eV5SkmYbrd/vXlb6R43szCrOiecULOaW+1DL2ZrbHr8fXLBYN5Qn nT2LVuIGUehO3A4nd07DlDzjnHf4HmCji9PamgOpSo88B/ki1eYWzQBvr g==; X-CSE-ConnectionGUID: kS+KjJitQpGMfyK36krjoQ== X-CSE-MsgGUID: X58SCv0nRMeMAea7kLVJhQ== X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="6581055" X-IronPort-AV: E=Sophos;i="6.07,158,1708416000"; d="scan'208";a="6581055" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 06:10:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,11025"; a="914912955" X-IronPort-AV: E=Sophos;i="6.07,158,1708416000"; d="scan'208";a="914912955" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Mar 2024 06:10:23 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rpT2q-0000000GdiM-49gT; Wed, 27 Mar 2024 15:10:20 +0200 Date: Wed, 27 Mar 2024 15:10:20 +0200 From: Andy Shevchenko To: Shahar Avidar Cc: gregkh@linuxfoundation.org, elder@linaro.org, robh@kernel.org, parthiban.veerasooran@microchip.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/3] staging: pi433: Fix includes, comments & macros. Message-ID: References: <20240327063156.96307-1-ikobh7@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240327063156.96307-1-ikobh7@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Mar 27, 2024 at 08:31:53AM +0200, Shahar Avidar wrote: > This patchset continues with some cleanups: > > 1. Untangle include hierarchy. > 2. Delete a misleading comment. > 3. Make use of general macro instead of magic number. > v2->v1: > Undo macro update. Remove its inaccurate comment instead. It's your responsibility to carry on the given tags for unchanged patches. I believe I gave a tag to two out of three patches. -- With Best Regards, Andy Shevchenko