Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp75184lqh; Wed, 27 Mar 2024 15:26:47 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVuwmRhGRQ22d7UWwvKhfqQKHozMVJIWTnkra9XORsqNDOWvuPuKAPDou+bVtC/VvKL2v+/eH/M3clc9cK7BPF1ErEeaX9NK7cjG0PAxA== X-Google-Smtp-Source: AGHT+IFLFz9S0XJRLeAvla05dUi2JO4pwM1wws5nquzAZblzF3rlVtUadZ82FzeYds0qOiybelbf X-Received: by 2002:a05:6512:485:b0:513:c223:f0e4 with SMTP id v5-20020a056512048500b00513c223f0e4mr636949lfq.10.1711578407640; Wed, 27 Mar 2024 15:26:47 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711578407; cv=pass; d=google.com; s=arc-20160816; b=vfoQErie+DIp7kDnYTPt4rtekg+KvRFy/gMPHZpGOcPUe4BKtd9IGek78wSyKdL4Yh kwYPOuxInIJG2osSKtf63Q6yG26JushRNpOD3JUcHu1+CAfpJd099iNFfQyw5EB5R5ui wQ3pTabXu3A5lGbRRTTjDbOe3hkutYIIz6+1GSDskChXhfT79J+PxvZR8UyJPHTHORwD MWBCEkphEp0H4/fagkIG1RSK651gL5EBkJqfzB75s8H1Mt6E+IAqhpqewrUIQLtLRE6d TARngSC/EET0ePQofjVpd051C83TW8x+fOCQVpcb2NFO9wQzGZgH7HG+bAf85HQjilNe 3ylw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=KW1mmB+UsQBWu80vviFCvkS83K6yY9xI4ffO4IjmdFk=; fh=sX11liakLT8PowH2ltAqXJKmySswDeI0fhK7/UC79fU=; b=vGXImiyTM15z8rYG2n2pR6vX/TM35/6MLRXYCZNEhTQYpUjCgvxsUwxWRxFYib04t4 x16uVCiBKFSWFqd3/9SdIT3aWAntsS4CYVQ+zBLHPyzQqrS5VT3ccXRP22lmbGn/JlsL FjOzZDsQupomj2FYUnxw2NzETa0oIHZHzxiaz7giC1zlYmW+Fi3aH7HALQmpWTwqPzTU TWK7vQBZmzdStAknhgOOPbdkpfgFJ/qg9phjPw5JGKdxvtd6HAJA5necYYdgBfz8KLVM kiJIWuyrM6y0ZC1QHmfbLECNypxQqqLm5nWiaVWDHH+FoyJexGKw+gyYlCzgeEZV4oX3 aWbg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=u0ItyWUb; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-122092-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-122092-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id r20-20020a170906549400b00a4a33a2d861si15893ejo.752.2024.03.27.15.26.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 15:26:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-122092-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=fail header.i=@luigi311.com header.s=x header.b=u0ItyWUb; arc=pass (i=1 spf=pass spfdomain=luigi311.com dkim=pass dkdomain=luigi311.com); spf=pass (google.com: domain of linux-kernel+bounces-122092-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-122092-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5CF7F1F2D80B for ; Wed, 27 Mar 2024 22:26:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0817B154C04; Wed, 27 Mar 2024 22:26:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b="u0ItyWUb" Received: from mail-108-mta71.mxroute.com (mail-108-mta71.mxroute.com [136.175.108.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9C5A15443F for ; Wed, 27 Mar 2024 22:26:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=136.175.108.71 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711578370; cv=none; b=axEXvAyhgJ1Y4dDZH4alxPdjVPUaSOSetBEM0CDJVB8QBEuAlT/snhPWaubfmYyYvb072yfNaFjlm/YfJH0iOiNOaYaM/mIoriHrjj6uFF7fXkM0X9cQTas4Yq0IntVgvpvC3FYu7Isyy5vk8p8lFD0nauyQ3N6heOZ1+n/USDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711578370; c=relaxed/simple; bh=3Os/T7XYPPuIQ9wkr2Su5Kx7M9odE7Rv2QP5TKP3BkE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=JaADIRyNbdSVHcC9XaSJiEIuEvkSBJh+lgawFz2mAFcPTNqjZjwok8QAGkg2xtwoN/ufSJc2GqhgQah3bVOXCMGbQ+IkT7SUU+5m+0G6Skb0t/EAlyHxoiScnfPTztELM0twRt6ld6v2oJxutm2QXGzTCLTlpcZjfXs4Vsc58ak= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com; spf=pass smtp.mailfrom=luigi311.com; dkim=pass (2048-bit key) header.d=luigi311.com header.i=@luigi311.com header.b=u0ItyWUb; arc=none smtp.client-ip=136.175.108.71 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=luigi311.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=luigi311.com Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta71.mxroute.com (ZoneMTA) with ESMTPSA id 18e8200738e0003bea.00f for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Wed, 27 Mar 2024 22:20:51 +0000 X-Zone-Loop: 31b83f8dc0273189f4f836ccd920158c119f6c7ab151 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=luigi311.com; s=x; h=Content-Transfer-Encoding:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KW1mmB+UsQBWu80vviFCvkS83K6yY9xI4ffO4IjmdFk=; b=u0ItyWUb09UfcJxkaIveclCfXh xBOlan1n/02oKFXfvTm1s80u8WWKXF/2XsJUUc4r04bycRw+nrXanaRi7LA2/Z+7uDZuwITZ4GL6r 4qTyvTEAjeIK2t8ofXNg0LY70w20wWaA/XjhhuLGvRgBKErQYUJxED7hV8L/fXTUSAAfvVlCtHrCz Qg5CGjGpOw85bi9JkaxzCc/eRQ0rw6fA6//7GKM8TU/phxx7ueujmMi3hEq0tuIuY2TJqIVyL4HIt oVNl5uQnN7uFT377WZaE94XlhJKX1nyBNotWQ0/7mZNmOl5EwrezJ+QQ/+bSW1Hux86eWwrorPB3l s2jHPlmw==; From: git@luigi311.com To: linux-media@vger.kernel.org Cc: dave.stevenson@raspberrypi.com, jacopo.mondi@ideasonboard.com, mchehab@kernel.org, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, sakari.ailus@linux.intel.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, x@xnux.eu Subject: [PATCH 03/23] media: i2c: imx258: Disable digital cropping on binned modes Date: Wed, 27 Mar 2024 16:20:15 -0600 Message-ID: <20240327222035.47208-4-git@luigi311.com> In-Reply-To: <20240327222035.47208-1-git@luigi311.com> References: <20240327222035.47208-1-git@luigi311.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Authenticated-Id: personal@luigi311.com From: Dave Stevenson The binned modes set DIG_CROP_X_OFFSET and DIG_CROP_IMAGE_WIDTH to less than the full image, even though the image being captured is meant to be a scaled version of the full array size. Reduce X_OFFSET to 0, and increase IMAGE_WIDTH to the full array. Signed-off-by: Dave Stevenson --- drivers/media/i2c/imx258.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/imx258.c b/drivers/media/i2c/imx258.c index 4a7048d834c6..0ae4371940ca 100644 --- a/drivers/media/i2c/imx258.c +++ b/drivers/media/i2c/imx258.c @@ -340,11 +340,11 @@ static const struct imx258_reg mode_2104_1560_regs[] = { { 0x0404, 0x00 }, { 0x0405, 0x20 }, { 0x0408, 0x00 }, - { 0x0409, 0x02 }, + { 0x0409, 0x00 }, { 0x040A, 0x00 }, { 0x040B, 0x00 }, { 0x040C, 0x10 }, - { 0x040D, 0x6A }, + { 0x040D, 0x70 }, { 0x040E, 0x06 }, { 0x040F, 0x18 }, { 0x3038, 0x00 }, @@ -459,11 +459,11 @@ static const struct imx258_reg mode_1048_780_regs[] = { { 0x0404, 0x00 }, { 0x0405, 0x40 }, { 0x0408, 0x00 }, - { 0x0409, 0x06 }, + { 0x0409, 0x00 }, { 0x040A, 0x00 }, { 0x040B, 0x00 }, { 0x040C, 0x10 }, - { 0x040D, 0x64 }, + { 0x040D, 0x70 }, { 0x040E, 0x03 }, { 0x040F, 0x0C }, { 0x3038, 0x00 }, -- 2.42.0