Received-SPF: pass (google.com: domain of linux-kernel+bounces-122101-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <67ba2ece-6b46-4ae1-a944-a38f84360d0f@intel.com>
Date: Wed, 27 Mar 2024 15:31:01 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/2] tracing: Include Microcode Revision in mce_record
 tracepoint
To: Avadhut Naik <avadhut.naik@amd.com>, <linux-trace-kernel@vger.kernel.org>,
	<linux-edac@vger.kernel.org>
CC: <rostedt@goodmis.org>, <tony.luck@intel.com>, <bp@alien8.de>,
	<x86@kernel.org>, <linux-kernel@vger.kernel.org>, <yazen.ghannam@amd.com>,
	<avadnaik@amd.com>
References: <20240327205435.3667588-1-avadhut.naik@amd.com>
 <20240327205435.3667588-3-avadhut.naik@amd.com>
Content-Language: en-US
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <20240327205435.3667588-3-avadhut.naik@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SkRMME5NcFBSWHBqR0ZvUjdNaUMyT2ZNdEVtdkY2SmtiR3ZxcDRxRXhqTTdp?=
 =?utf-8?B?L2d4RjUwVGpWd0wvODIzODNyb0RsaUljTE9LOTBYY29zdElDMGJvZHBNT3Ns?=
 =?utf-8?B?RytZVHhWc2pkZTI5ZFVUZXFoV2pVdHhFT21qa2VpS0tWa0V6YVZaWXlHVnRi?=
 =?utf-8?B?L0ZFdXdDUkxPcW9LMGl5NTFDb2s3TVNYSTl1WGlnNU9UcGQ2eEJ6R3hiVElq?=
 =?utf-8?B?WVdLdTZRNTBGaTBtSUhIZXV6VmNDYkZIZnRpNmtKRFFrL002VEoyUG9TZmRi?=
 =?utf-8?B?L2sxU3RRQjJGVENuaDZjd3N3NlJlYmZ6UUMwQStsQU5qRElUVVBXMTNEZkRQ?=
 =?utf-8?B?L1VtandISnA3bGR1bDZ5TnA5cXFaMnFmMUM0SndwenpROGRXbmtZUGsycDVa?=
 =?utf-8?B?ZUdkdHpoaHVzRUdyb0k1SE8xT2ZmYnNVK0RsMExSbnBXOUk2cVJrZ0ZodlZN?=
 =?utf-8?B?SHlyOUwzNHU2Y1BBRDBKRkhCQkhXcSt4anpMa1Q0ZlNKdTdQS3Q4cGxHQnFn?=
 =?utf-8?B?OW9UWHkxLytvRDkya1hBa3pwQ1U3dFZlMjhIZ2drVlQ4eVNsb2ZxUEdoRTlo?=
 =?utf-8?B?TkFIcnRVcnlzVTQyckF1MjZCT1ZZaW9UNWl3dGg2cFZpM0JFbHl6elVJVXdF?=
 =?utf-8?B?NWdWYmFWYlExT21LeW1KbitRMFZSMnVEYWVQbFF6MFdldGVwT3NvNEVMUFBG?=
 =?utf-8?B?cFJQYUxXR0tta2ZEOVpFT0tzbk1LdDhxV1RkWGpPdmVuV295U2xzRGllR3RY?=
 =?utf-8?B?Ujc1KzVwREl5RXNPREdxcUt6NUNqUk4rMVFONDg5clFjTi9RcndvZFJHdVBH?=
 =?utf-8?B?b2NtUTlEdkFCNXlaYTRxUjZSQVk2WXFPbWZ3Q3dTaEIzb1dSaTA1d1ZFSno3?=
 =?utf-8?B?ajFuRWd2dmNBNmViNEJiZUpDd28rbjVFRk9RTnVwNXVHYVE1UGM3TG1QbEhE?=
 =?utf-8?B?REpHRXdhZ3dCalJiMmJwU1NLbnBUdTVkejlPRVEreXFwLyt3R0FIaUdpaFBP?=
 =?utf-8?B?TmJRN2phRGZCMWdVbkg2ZHBOM0JkSUcrdG5NVlpYNHFTSGtpUjdMRkZCNzA0?=
 =?utf-8?B?M1g5MGJnYUJkSmhuMlhGVVBSVVRXODdZbG5vdTl6UzB0MHBYdFExQnBmN2ly?=
 =?utf-8?B?SkxCQXBaT1A3Zkc0ZVVQY1FBS254NWliN0g0SXExMzRCS09JaDVRYVZ5Qklw?=
 =?utf-8?B?WDQyRWE2N2pLMjVJWjE4NDlXdkhwU0cxdHZvM2VESndmVFdNWGgvRW1wcnJD?=
 =?utf-8?B?ZEtsYU1nRmE4S2piYWF2UWEyZnA1T0FraTZpZCtoZUdzbm9uSGx4VStCdEhK?=
 =?utf-8?B?UDZrR3lyck5oOUQ1SHBkcWxQZU03VW1PbHcvVkZtUDRLTUJjRVdJSHo3NVBN?=
 =?utf-8?B?a01KT3QyQWFKOUhhTVJJRTlVT05ZL2tVSnhiRm9WY04rWVE1ZlZRN0VDc2Fp?=
 =?utf-8?B?UFhza2M1TTFyTHJCenZZakJ4UUdEb2wvSUlHM3RvWko1TXQzN2hVM2U1T2Nk?=
 =?utf-8?B?ODR4RE1KUGZ2c2dDMXJBY0VWWmplUFNrRm50dkpVOGtVT2x6M05tbnJsTlhX?=
 =?utf-8?B?MDJBNjNhSEtTOUxTcEQycUlVcnlVQURITkNkWG11bTc3aXNsTVBQUy9yaGp1?=
 =?utf-8?B?bGhWMmVpaGxEK0tOSjM0NmtYWTYwMTR5QmtFTjEwZHhaWElabm0zNkI1SHhp?=
 =?utf-8?B?bjRXNDNWR3UrVGpSa0UxVjJUZi95MWZzRWV4M2dJVGFZbitMVkVUT1pHZmJM?=
 =?utf-8?B?MnJBVG9TVEtVZjJ1a3BqRHppOTBkdmhEZ2xkQ2hxR3IvMUxMSXFBanJCMXpT?=
 =?utf-8?B?bktTcVlKakduTVA2aFN6UlRzQTgxZXByckowVW1VQmtnTFhmNVU1aFBNUXlo?=
 =?utf-8?B?Mm91MytLK29LTVNkQXVnTjJTbTdhSWYrZzVnK3ZkRzJMbjZWYVY5RjRsM3FO?=
 =?utf-8?B?QkJud0d0ZnNiTTBaajZnU1ljTmxRYVMrYjNPT0FMQ3RJZTNGYllHMFhSTzhU?=
 =?utf-8?B?WnUrRjNTQkUrM2ozN0JoTzRkMi9xekwxMU01SjVRYjV6WXhnNTA2RXlCWmto?=
 =?utf-8?B?ZzdmcWVTc280RVRRaU52Q3B4bU9mSm1SWngxNVZIbElLWXNFNU9CdUEyV3hv?=
 =?utf-8?Q?24ZfSgkMafVsF/hg3t7zfXGMZ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 82d31ec3-16f0-49a1-ef38-08dc4ead95eb
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 22:31:03.2224
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Od0B9wUpVxKIe9Fo5JgjQna1NzS/V+/OeMelMO4GYJbcs5ZFl2KkJCpbDeRoDfD1cNsxArJ96o873XU8dLzQqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB6817
X-OriginatorOrg: intel.com

On 3/27/2024 1:54 PM, Avadhut Naik wrote:

> -	TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x",
> +	TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x, MICROCODE REVISION: %x",

Nit: s/MICROCODE REVISION/MICROCODE/g

You could probably get rid of the word REVISION in the interest of
brevity similar to __print_mce().

	pr_emerg(HW_ERR "PROCESSOR %u:%x TIME %llu SOCKET %u APIC %x microcode
%x\n",
		m->cpuvendor, m->cpuid, m->time, m->socketid, m->apicid,
		m->microcode);


-Sohil