Received-SPF: pass (google.com: domain of linux-kernel+bounces-122185-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240326100740.178594-1-davidgow@google.com>
In-Reply-To: <20240326100740.178594-1-davidgow@google.com>
From: Rae Moar <rmoar@google.com>
Date: Wed, 27 Mar 2024 19:32:20 -0400
Message-ID: <CA+GJov6wuRDu2JiUsw0qtWehpbUPnxM=fK-dJxVMtOr0TejP+A@mail.gmail.com>
Subject: Re: [PATCH] kunit: configs: Enable CONFIG_DAMON_DBGFS_DEPRECATED for --alltests
To: David Gow <davidgow@google.com>
Cc: SeongJae Park <sj@kernel.org>, Mark Brown <broonie@kernel.org>, 
	Johannes Berg <johannes.berg@intel.com>, linux-kselftest@vger.kernel.org, 
	kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org, 
	Shuah Khan <skhan@linuxfoundation.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 26, 2024 at 6:07=E2=80=AFAM David Gow <davidgow@google.com> wro=
te:
>
> This is required, as CONFIG_DAMON_DEBUGFS is enabled, and --alltests UML
> builds will fail due to the missing config option otherwise.
>
> Fixes: f4cba4bf6777 ("mm/damon: rename CONFIG_DAMON_DBGFS to DAMON_DBGFS_=
DEPRECATED")
> Signed-off-by: David Gow <davidgow@google.com>

Hello!

This looks good to me. And it takes away the issue with
CONFIG_DAMON_DBGFS. But since this is deprecated now, should we move
to the DAMON sysfs tests instead in the future? No need to let that
stall this patch though.

Reviewed-by: Rae Moar <rmoar@google.com>

Thanks!
-Rae

> ---
>
> This is breaking all UML alltests builds, so we'd like to fix it sooner
> rather than later. SeongJae, would you rather take this yourself, or can
> we push it alongside any other KUnit fixes?
>
> Johannes: Does this conflict with the CONFIG_NETDEVICES / CONFIG_WLAN
> fixes to all_tests.config? I'd assume not, but I'm happy to take them
> via KUnit if you'd prefer anyway.
>
> Thanks,
> -- David
>
> ---
>  tools/testing/kunit/configs/all_tests.config | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing=
/kunit/configs/all_tests.config
> index aa5ec149f96c..f388742cf266 100644
> --- a/tools/testing/kunit/configs/all_tests.config
> +++ b/tools/testing/kunit/configs/all_tests.config
> @@ -38,6 +38,7 @@ CONFIG_DAMON_VADDR=3Dy
>  CONFIG_DAMON_PADDR=3Dy
>  CONFIG_DEBUG_FS=3Dy
>  CONFIG_DAMON_DBGFS=3Dy
> +CONFIG_DAMON_DBGFS_DEPRECATED=3Dy
>
>  CONFIG_REGMAP_BUILD=3Dy
>
> --
> 2.44.0.396.g6e790dbe36-goog
>