Received-SPF: pass (google.com: domain of linux-kernel+bounces-122189-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <a2362908-feab-416c-b5ae-13d560089ee6@gmx.de>
Date: Thu, 28 Mar 2024 00:35:06 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v1 1/1] platform/x86: quickstart: Miscellaneous
 improvements
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>,
 =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
References: <20240327215208.649020-1-andy.shevchenko@gmail.com>
Content-Language: en-US
From: Armin Wolf <W_Armin@gmx.de>
In-Reply-To: <20240327215208.649020-1-andy.shevchenko@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:l58OXnBeQuA=;2opCUHfijmXnrgZCra7bo1x24q9
 drV/WbAc3kzibNjBAHaPVqajBh0AlVaJazNdmPJzc4AJg0mZF4kzDtbhJyCLY0RTNVfCN987Q
 TB8FhOzynXc3gLaxP0ZXeiTOjIkcIgEPdH6VOtIQ5joCTxvOY7Y0E6JjzsXfB1JbeBVKRicrV
 JV/kEMjEaWcQZnGcrrTnGiTO9loa1OmvmzIkek0pQNBrGsmsGIEhmgVFzQygYrrRQfIzD5Ak6
 GKUGS2eiL1OiKKwEBdMBIR9X86orUH1z7+3EYD1dOg2608XXM/3t3jRpFhhYpDZ0XZg+gBUvC
 7i7ablI3HVWhK1qicrV5XjsI2yMEwqK/buqIbqa8qxJ0/vz/DHNXqNizJ1Fm7zHXFAevdUe2E
 vOHxLcXmvx5cPJTZZcqs5dO1vAaXlznMIzpfJleQg8PAEW/If0POWP9nKvGT9JHznWcu1Qv3o
 SMVbpRD5VXiSRU1y6pUZItZPl1NRlPyVVGhBkWqn+5cECCV8PIU8oQ8BvfC8ianlggloofjvw
 jyQPZrDZSsmm/9O8ttoJ1CcF44WjQk0VpLjjAIbBuV9S4TLzGeh1FZROUg91k1qrHP9NAYWn4
 32DXPzWaLnJj0LTQEDjDeHbnvp3tHJrZ2ZZJHJkNy34gX9uu3AjHvDCFaZYi9mY/TuaakoSG3
 Ofstmekxyhq9bR+ikWKNWwOwVxKujywgxhc7NO71MfGehxqhOzC+IEqT6TEZmtGvccBRclgjY
 fpbWK0TXE3jG2V5rugOSaxm2vViC3PaGpSroX7Kw+aqkxJ+6MWSZP7XVJCEZndhnECWNdskty
 jGxHMca1oTMvacghNOQx88lh0QM1HGZue9vtt9MoDUhq8=

Am 27.03.24 um 22:52 schrieb Andy Shevchenko:

> There is a mix of a few improvements to the driver.
> I have done this instead of review, so it can quickly be
> folded into the original code (partially or fully).
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@gmail.com>
> ---
>   drivers/platform/x86/quickstart.c | 16 ++++++++++------
>   1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/platform/x86/quickstart.c b/drivers/platform/x86/qu=
ickstart.c
> index ba3a7a25dda70..f686942662ccc 100644
> --- a/drivers/platform/x86/quickstart.c
> +++ b/drivers/platform/x86/quickstart.c
> @@ -1,6 +1,6 @@
>   // SPDX-License-Identifier: GPL-2.0-or-later
>   /*
> - * quickstart.c - ACPI Direct App Launch driver
> + * ACPI Direct App Launch driver
>    *
>    * Copyright (C) 2024 Armin Wolf <W_Armin@gmx.de>
>    * Copyright (C) 2022 Arvid Norlander <lkml@vorapal.se>
> @@ -10,15 +10,18 @@
>    * <https://archive.org/details/microsoft-acpi-dirapplaunch>
>    */
>
> -#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> -

Hi,

that is the reason for removing this?

>   #include <linux/acpi.h>
> +#include <linux/device.h>
> +#include <linux/errno.h>
>   #include <linux/init.h>
>   #include <linux/input.h>
>   #include <linux/input/sparse-keymap.h>
> -#include <linux/kernel.h>
> +#include <linux/mod_devicetable.h>
>   #include <linux/module.h>
>   #include <linux/platform_device.h>
> +#include <linux/pm_wakeup.h>
> +#include <linux/printk.h>
> +#include <linux/slab.h>
>   #include <linux/sysfs.h>
>   #include <linux/types.h>
>
> @@ -165,7 +168,8 @@ static int quickstart_probe(struct platform_device *=
pdev)
>   	data->dev =3D &pdev->dev;
>   	dev_set_drvdata(&pdev->dev, data);
>
> -	/* We have to initialize the device wakeup before evaluating GHID beca=
use
> +	/*
> +	 * We have to initialize the device wakeup before evaluating GHID beca=
use
>   	 * doing so will notify the device if the button was used to wake the=
 machine
>   	 * from S5.
>   	 */
> @@ -202,7 +206,7 @@ static int quickstart_probe(struct platform_device *=
pdev)
>   }
>
>   static const struct acpi_device_id quickstart_device_ids[] =3D {
> -	{ "PNP0C32", 0 },
> +	{ "PNP0C32" },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(acpi, quickstart_device_ids);