Received-SPF: pass (google.com: domain of linux-kernel+bounces-122199-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 27 Mar 2024 16:58:35 -0700
From: Isaku Yamahata <isaku.yamahata@intel.com>
To: "Edgecombe, Rick P" <rick.p.edgecombe@intel.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Yamahata, Isaku" <isaku.yamahata@intel.com>,
	"Zhang, Tina" <tina.zhang@intel.com>,
	"seanjc@google.com" <seanjc@google.com>,
	"Yuan, Hang" <hang.yuan@intel.com>,
	"Huang, Kai" <kai.huang@intel.com>, "Chen, Bo2" <chen.bo@intel.com>,
	"sagis@google.com" <sagis@google.com>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
	isaku.yamahata@linux.intel.com
Subject: Re: [PATCH v19 052/130] KVM: x86/mmu: Track shadow MMIO value on a
 per-VM basis
Message-ID: <20240327235835.GI2444378@ls.amr.corp.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <34d7a0c8724f4fce4da50fe3028373c31213aa8a.1708933498.git.isaku.yamahata@intel.com>
 <ccca711ccd0cb52739041580a26d4ea240760b10.camel@intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <ccca711ccd0cb52739041580a26d4ea240760b10.camel@intel.com>

On Tue, Mar 26, 2024 at 03:31:05AM +0000,
"Edgecombe, Rick P" <rick.p.edgecombe@intel.com> wrote:

> On Mon, 2024-02-26 at 00:25 -0800, isaku.yamahata@intel.com wrote:
> > From: Isaku Yamahata <isaku.yamahata@intel.com>
> > 
> > TDX will use a different shadow PTE entry value for MMIO from VMX.  Add
> > members to kvm_arch and track value for MMIO per-VM instead of global
> > variables.  By using the per-VM EPT entry value for MMIO, the existing VMX
> > logic is kept working.  Introduce a separate setter function so that guest
> > TD can override later.
> > 
> > Also require mmio spte caching for TDX.
> 
> 
> > Actually this is true case
> > because TDX requires EPT and KVM EPT allows mmio spte caching.
> > 
> 
> I can't understand what this is trying to say.

I'll drop this sentence as the logic moved to
"069/130 KVM: TDX: Require TDP MMU and mmio caching for TDX".


> >  {
> > +
> > +       kvm->arch.shadow_mmio_value = shadow_mmio_value;
> 
> It could use kvm_mmu_set_mmio_spte_value()?

Yes.
-- 
Isaku Yamahata <isaku.yamahata@intel.com>