Received-SPF: pass (google.com: domain of linux-kernel+bounces-122200-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 27 Mar 2024 17:02:05 -0700
From: Isaku Yamahata <isaku.yamahata@intel.com>
To: Binbin Wu <binbin.wu@linux.intel.com>
Cc: Isaku Yamahata <isaku.yamahata@intel.com>,
	"Edgecombe, Rick P" <rick.p.edgecombe@intel.com>,
	"Huang, Kai" <kai.huang@intel.com>,
	"Zhang, Tina" <tina.zhang@intel.com>,
	"seanjc@google.com" <seanjc@google.com>,
	"Yuan, Hang" <hang.yuan@intel.com>, "Chen, Bo2" <chen.bo@intel.com>,
	"sagis@google.com" <sagis@google.com>,
	"isaku.yamahata@gmail.com" <isaku.yamahata@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Aktas, Erdem" <erdemaktas@google.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"isaku.yamahata@linux.intel.com" <isaku.yamahata@linux.intel.com>
Subject: Re: [PATCH v19 058/130] KVM: x86/mmu: Add a private pointer to
 struct kvm_mmu_page
Message-ID: <20240328000205.GJ2444378@ls.amr.corp.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <9d86b5a2787d20ffb5a58f86e43601a660521f16.1708933498.git.isaku.yamahata@intel.com>
 <50dc7be78be29bbf412e1d6a330d97b29adadb76.camel@intel.com>
 <20240314181000.GC1258280@ls.amr.corp.intel.com>
 <bfde1328-2d1c-4b75-970f-69c74f3a74f9@intel.com>
 <ada65e3e977c8cde0044b7fa9de5f918e3b1b638.camel@intel.com>
 <20240315010940.GE1258280@ls.amr.corp.intel.com>
 <35090f7e-4f4d-403c-b95e-f09248fc272d@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <35090f7e-4f4d-403c-b95e-f09248fc272d@linux.intel.com>

On Wed, Mar 27, 2024 at 09:49:14PM +0800,
Binbin Wu <binbin.wu@linux.intel.com> wrote:

> 
> 
> On 3/15/2024 9:09 AM, Isaku Yamahata wrote:
> > Here is the updated one. Renamed dummy -> mirroed.
> > 
> > When KVM resolves the KVM page fault, it walks the page tables.  To reuse
> > the existing KVM MMU code and mitigate the heavy cost of directly walking
> > the private page table, allocate one more page to copy the mirrored page
> 
> Here "copy" is a bit confusing for me.
> The mirrored page table is maintained by KVM, not copied from anywhere.

How about, "maintain" or "keep"?

> 
> > table for the KVM MMU code to directly walk.  Resolve the KVM page fault
> > with the existing code, and do additional operations necessary for the
> > private page table.  To distinguish such cases, the existing KVM page table
> > is called a shared page table (i.e., not associated with a private page
> > table), and the page table with a private page table is called a mirrored
> > page table.  The relationship is depicted below.
> > 
> > 
> >                KVM page fault                     |
> >                       |                           |
> >                       V                           |
> >          -------------+----------                 |
> >          |                      |                 |
> >          V                      V                 |
> >       shared GPA           private GPA            |
> >          |                      |                 |
> >          V                      V                 |
> >      shared PT root      mirrored PT root         |    private PT root
> >          |                      |                 |           |
> >          V                      V                 |           V
> >       shared PT           mirrored PT ----propagate---->  private PT
> >          |                      |                 |           |
> >          |                      \-----------------+------\    |
> >          |                                        |      |    |
> >          V                                        |      V    V
> >    shared guest page                              |    private guest page
> >                                                   |
> >                             non-encrypted memory  |    encrypted memory
> >                                                   |
> > PT: Page table
> > Shared PT: visible to KVM, and the CPU uses it for shared mappings.
> > Private PT: the CPU uses it, but it is invisible to KVM.  TDX module
> >              updates this table to map private guest pages.
> > Mirrored PT: It is visible to KVM, but the CPU doesn't use it.  KVM uses it
> >               to propagate PT change to the actual private PT.
> > 
> 
> 

-- 
Isaku Yamahata <isaku.yamahata@intel.com>