Received-SPF: pass (google.com: domain of linux-kernel+bounces-122268-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <b961254e-f556-4186-91e2-76f312604e53@intel.com>
Date: Thu, 28 Mar 2024 09:19:52 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [kvm-unit-tests Patch v3 01/11] x86: pmu: Remove duplicate code
 in pmu_init()
To: Dapeng Mi <dapeng1.mi@linux.intel.com>
CC: Jim Mattson <jmattson@google.com>, Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Zhenyu Wang <zhenyuw@linux.intel.com>,
	"Zhang, Xiong Y" <xiong.y.zhang@intel.com>, Mingwei Zhang
	<mizhang@google.com>, Like Xu <like.xu.linux@gmail.com>, Jinrong Liang
	<cloudliang@tencent.com>, "Mi, Dapeng1" <dapeng1.mi@intel.com>
References: <20240103031409.2504051-1-dapeng1.mi@linux.intel.com>
 <20240103031409.2504051-2-dapeng1.mi@linux.intel.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <20240103031409.2504051-2-dapeng1.mi@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KytwYzVIRC9MSnI3VUtGakZSZUN2UTNCSFAveGh1aFhVa1pLdWkzUk4xQ2cz?=
 =?utf-8?B?VWZoeG9ObGo5TllzaUhnZ2FvSUkrcWpnbkIyVFBKbVpyVDhEa2M0Q3dNQSsy?=
 =?utf-8?B?TzRzdzNsaGIyUG9CazE3TDhwV2M4bGtjQWl3RzB5TmJhamNBMnA5TFgwM1NG?=
 =?utf-8?B?a3NWZEh3NS9KTHcrRUtzM093MHN6SmpQdmppTXNpTFhIeGRLY2EvTGdJTldE?=
 =?utf-8?B?cDdHSDVCN1B1ei9wakNjT1lReCt5UlkxYUVHR1kwUzh1bVhvQjNyaVFxb3cz?=
 =?utf-8?B?ZDhYTjlqeU9QSlVtTktRRmU1VUJjNXpyNDFTQ3F0N2p4U2hVSGRWYjhySXdU?=
 =?utf-8?B?NTFOTDBYcm95aFpqZXVpdkdOTUlHRGFUQWVCZWkwTjZJKzRBVm5GQjhZZ0Vk?=
 =?utf-8?B?ZjhzVC9iWmlPZlJLV3Zuc3RNV1d5V0ptd0kvS0NsTGtVR1l6ajBnOHdpSERY?=
 =?utf-8?B?WjNhTjJ0TW5Bbnl3ek9ub29xU09WWDJUeEF5azF4b1llQ2ZUckFZUmQ0Y0Ji?=
 =?utf-8?B?MFpQbTdEZFBKREdhV2orbWNOWjk5UHlrTXh5VE5DcHo2VmpGTFp6eFhRR2FG?=
 =?utf-8?B?MlZ0dnlSdGlhN1h1K2cwais0S2dKbjh4OEkvNTFXbVJVekNGdmdpYmY0Wm9p?=
 =?utf-8?B?aXA1T3hKdmcrRHoxVUFtSUhYblh2TFh2ZHdRQ251QldWbXNFaWxHZUVSNHNZ?=
 =?utf-8?B?SEtKdGkwMjB3VmdWdm5mYk40TFNkWEZCbGFIVWU1RHgvUEZRYWw4RWhESmRK?=
 =?utf-8?B?NkQxTU1WN0FEVGRGamtXVFl5Sld0OUd2cnhkRkJMbFhybkR6MDB5U2dxVlZ6?=
 =?utf-8?B?aS9ta0ZFR2ZuMVBlWXlocVI3Z01MSEwrWE5NTlBpSnJ1cXVVNFVOZENtdWU1?=
 =?utf-8?B?ZFg4dE14dDVnVnVLbFR1UjVMRGhzV29XeGs1aVFPcUdBc2d5SnRQd0JTQWZ6?=
 =?utf-8?B?RTc0UXJBVU9WZW1jTCsxV2JoNWwxcEpsSXdnRnBrOHRJUjl4NDNXdDdSR21Y?=
 =?utf-8?B?YVFYNCs3bE9LRUZwbW8zQnBuVkd0WTlzSEFXSFBDa1FNMUMzSFg0UnZyeHZX?=
 =?utf-8?B?OU5BWU0rRWZZbkFDWlYwTzhrTllpU3ZwT2o0WmwxOTA4OFNKR0t4UEdXSlFy?=
 =?utf-8?B?ejJaWmQ2WGFmUGx0Zk1QY0dsU3Jscm50UU9CSGovRjJMWjhhUk9BT2F0L3JK?=
 =?utf-8?B?dXJrUXdSV3lqOCtlcUpESjkrd1J2ZlNDMFRONmQrMzNUZTlYMXJycnBlY1BB?=
 =?utf-8?B?dU4xWnRuVUJGWU56UU9Td092cUZyejNvdFBYOFMvL0xyRU11ZHVjTlVEOE9V?=
 =?utf-8?B?QXQ3TTBtbUlCSVlFVG1oYzM5S1BPZStXTzMzbWdjUFhTVGNkY0xWVXlIcXBs?=
 =?utf-8?B?SXlZaTllTnptN0pnN2pQYnhGNEx3ZDNoMDR3Z1dUN1JDT3poNHZaQkdpakto?=
 =?utf-8?B?VW9iS3ViSFhBdWJYU3g5V0NnczlDL1QvampNeFRXQ3dpMFBGOTdHbXBlSjkv?=
 =?utf-8?B?SnF6VTVKYngrR3pGUmw3dFYyeHRIa3Fzb0hCei9jL2VhYjltWUUyL04yUXFO?=
 =?utf-8?B?eURIMklLOGNUQzBMeGU4Z29paXhJaVdkY3dqQzloTXVoN0xQNzNKREx3WnVJ?=
 =?utf-8?B?bi94ZmRlS0tIakJtMEo4elNLU2N2TStSVTFBcWMyNUdjL3NMZ2hTOW82OTRj?=
 =?utf-8?B?RWV2MlN5U0kySEVpTzFwNTZrSENzMHYxZDNKcElZNjMxay8rRHRwWUFpVFJM?=
 =?utf-8?B?bi9IYWhpTzZ1MG9CRlcxcDJQK2JUVkFVR0V2SGFpOEtOOUUwZW5aeVNodis3?=
 =?utf-8?B?RzQ0MDJCcFJKRE5oYmlxVTZINFNTMmxXcXVFRms1QWlmbEtiUDFFVHJOY0hs?=
 =?utf-8?B?dTdIT0xHUFU3UUdYL3N3N1FRcklYNTJ4U1M3MmFsYnp2TDhUU21JaDJOaFRW?=
 =?utf-8?B?c2M3aFJxV3R2NFdsME5VK0RyQVRGK3Z0cTRwdHhkRmRveHZORE5rWFd0Rmov?=
 =?utf-8?B?TTg2ZUE5VWhFMnBTcEQ3N3BXZXk0T09vTjR4SnF3WVBzMWF6eDVDNGo5M1hV?=
 =?utf-8?B?N3lzSE8wVWpnNDlHdER5VDJuM20xckJRTTNMVnBrZllXM0gzay8yU1JYbHFJ?=
 =?utf-8?B?STdrZlp0NVd6bi84aVhFNkZYcjFvQk1qczZQUlZvWmZaWlBaTjV4L3FDdDJh?=
 =?utf-8?B?Vmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cd8a18a-ad96-4d70-3846-08dc4ec530e5
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 01:20:02.2702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 0kbeS6g66JFriueM3Ivu2vU5ZWR7+ywQIjLXndTy+VSwFlLEeWOfHIsagbbUFD9BtyZrqGoZIPmKYbkP4W7Suw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4894
X-OriginatorOrg: intel.com

On 1/3/2024 11:13 AM, Dapeng Mi wrote:
> From: Xiong Zhang <xiong.y.zhang@intel.com>
>
> There are totally same code in pmu_init() helper, remove the duplicate
> code.
>
> Signed-off-by: Xiong Zhang <xiong.y.zhang@intel.com>
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>

Jim has already added RB tag for this patch in v2, you may add it here.

> ---
>   lib/x86/pmu.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/lib/x86/pmu.c b/lib/x86/pmu.c
> index 0f2afd650bc9..d06e94553024 100644
> --- a/lib/x86/pmu.c
> +++ b/lib/x86/pmu.c
> @@ -16,11 +16,6 @@ void pmu_init(void)
>   			pmu.fixed_counter_width = (cpuid_10.d >> 5) & 0xff;
>   		}
>   
> -		if (pmu.version > 1) {
> -			pmu.nr_fixed_counters = cpuid_10.d & 0x1f;
> -			pmu.fixed_counter_width = (cpuid_10.d >> 5) & 0xff;
> -		}
> -
>   		pmu.nr_gp_counters = (cpuid_10.a >> 8) & 0xff;
>   		pmu.gp_counter_width = (cpuid_10.a >> 16) & 0xff;
>   		pmu.gp_counter_mask_length = (cpuid_10.a >> 24) & 0xff;