Received-SPF: pass (google.com: domain of linux-kernel+bounces-122271-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Armin Wolf <W_Armin@gmx.de>
To: hdegoede@redhat.com,
	ilpo.jarvinen@linux.intel.com
Cc: corbet@lwn.net,
	linux-doc@vger.kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/4] platform/x86: xiaomi-wmi: Drop unnecessary NULL checks
Date: Thu, 28 Mar 2024 02:23:35 +0100
Message-Id: <20240328012336.145612-3-W_Armin@gmx.de>
In-Reply-To: <20240328012336.145612-1-W_Armin@gmx.de>
References: <20240328012336.145612-1-W_Armin@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:ufHgX651t2I=;kgTXljFyEPj8G2vsPH+Dlk2+pKX
 pVqH5y71ysJnPVe93Yg+ElYtPtYWG4/5mCTYcoIsC7lOZlEL50TybkPJyTk3EJlwV6EWEbS2U
 KWdA0eYfnZqkFWsc9gTwFjssYor2XP/ZvM9XIQ9jau/1LnszyGszeXtUrums1XAYkHJBagZg/
 ekdwMMV9oc2OaQORq2VLWl5Fn4kHu/4ktTq3poAnNfXpI75S+D5icGbSMr2mQcKlWnUVS8Dsp
 3f0G7HTLnsWgoORpXssIsBJR7qcR7fj8X95XYxTwfNqiq08kNo6FWz1ActZyVQ7kvC6BBfI5i
 ZdBVm2dEUwMfxCfWHI4lTrNFOGLk2SRAH23jE0PGgz1/EO6en5K60lb48SuvMdrtWW6C0mP3I
 UlCUB01cj+6rWF0s4zeINo2QHhgq6eJs7CbMWupRuqgBOdH1Iu2d7tik8ryNCmnEE/EzTxlTX
 lxloXR2KehQuVdDqrbcrvPeB02bcBbcVUlKFqLO4U7bER9OTuV8yVGNknCTB1V7cc1geYlOoW
 kKrIjoR2xXYZvBt16l7g/9HsbjQTSPcIFRTD7bPFKwuj9Go+btuXYnWqoHB2VGtQw2v2XRNOZ
 0GnU4Tf1fK0T35KdVFHEDyfobsEjv+peP6OGqaKMynbdp7sIk5tNWKlN2SXaaViL5G4yDIMFg
 +IpQTekivZN3mWGuLtDTfMOoDCjLQSZLsWr8/xJx6GiaMhrnJxPvOUQvYQ+gr9WtbfC6sx1Pv
 t5/RA3ltwteX3YGRtXNLk3kAgDmZB7gZDMMR2lyOf81WjEwbxc7XV9yLmUNyCypTd/iqB023H
 9DcWfymGiPaCNHIR/Uj9rZfhKPXt2tOFIDv04HahCObzc=

The WMI driver core already makes sure that:

- a valid WMI device is passed to each callback
- the notify() callback runs after the probe() callback succeeds

Remove the unnecessary NULL checks.

Compile-tested only.

Signed-off-by: Armin Wolf <W_Armin@gmx.de>
=2D--
 drivers/platform/x86/xiaomi-wmi.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/platform/x86/xiaomi-wmi.c b/drivers/platform/x86/xiao=
mi-wmi.c
index 7efbdc111803..cbed29ca502a 100644
=2D-- a/drivers/platform/x86/xiaomi-wmi.c
+++ b/drivers/platform/x86/xiaomi-wmi.c
@@ -38,7 +38,7 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, con=
st void *context)
 	struct xiaomi_wmi *data;
 	int ret;

-	if (wdev =3D=3D NULL || context =3D=3D NULL)
+	if (!context)
 		return -EINVAL;

 	data =3D devm_kzalloc(&wdev->dev, sizeof(struct xiaomi_wmi), GFP_KERNEL)=
;
@@ -66,14 +66,7 @@ static int xiaomi_wmi_probe(struct wmi_device *wdev, co=
nst void *context)

 static void xiaomi_wmi_notify(struct wmi_device *wdev, union acpi_object =
*dummy)
 {
-	struct xiaomi_wmi *data;
-
-	if (wdev =3D=3D NULL)
-		return;
-
-	data =3D dev_get_drvdata(&wdev->dev);
-	if (data =3D=3D NULL)
-		return;
+	struct xiaomi_wmi *data =3D dev_get_drvdata(&wdev->dev);

 	mutex_lock(&data->key_lock);
 	input_report_key(data->input_dev, data->key_code, 1);
=2D-
2.39.2