Received-SPF: pass (google.com: domain of linux-kernel+bounces-122274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <359fe9cf-d12b-4f75-8cae-7ce830ec76d9@intel.com>
Date: Thu, 28 Mar 2024 09:23:35 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [kvm-unit-tests Patch v3 06/11] x86: pmu: Remove blank line and
 redundant space
To: Dapeng Mi <dapeng1.mi@linux.intel.com>
CC: Jim Mattson <jmattson@google.com>, Paolo Bonzini <pbonzini@redhat.com>,
	Sean Christopherson <seanjc@google.com>, "kvm@vger.kernel.org"
	<kvm@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, Zhenyu Wang <zhenyuw@linux.intel.com>,
	"Zhang, Xiong Y" <xiong.y.zhang@intel.com>, Mingwei Zhang
	<mizhang@google.com>, Like Xu <like.xu.linux@gmail.com>, Jinrong Liang
	<cloudliang@tencent.com>, "Mi, Dapeng1" <dapeng1.mi@intel.com>
References: <20240103031409.2504051-1-dapeng1.mi@linux.intel.com>
 <20240103031409.2504051-7-dapeng1.mi@linux.intel.com>
Content-Language: en-US
From: "Yang, Weijiang" <weijiang.yang@intel.com>
In-Reply-To: <20240103031409.2504051-7-dapeng1.mi@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SlpYdFJqNk1qeStoNXg4ZDlhOVdDa2E3NXFHYllQUWV6ejVKZmhDOUlyb29r?=
 =?utf-8?B?Z2dWMmx2MEZEcEdyOEZoZktMZnBIekpTZUFrSFNRSzN0OWZ1VVhmMlVKRk5O?=
 =?utf-8?B?S1lGV0kyRlozejVUQnBuMGNtQnFUaVVuQmJYaTZENENXZC8zZ1dYV3NpWkM4?=
 =?utf-8?B?bUF6TkFING15K1B3a1pWZEY5clE5VGkzQUJ0N0F6QzVVT09XalpINzZVeWZG?=
 =?utf-8?B?dytKdFZsMk1iUnRFZzBaanRPamVaV3E5ZkRYUHE3MnE2OW9xS0d2NTVPUERw?=
 =?utf-8?B?YU44eWppY0VTTzFrem11VDhvWSt5QUVRMHJzWGo0RmdxQ3A3VU1Va215QjF2?=
 =?utf-8?B?dEM2UkdrVFNWR05kVHl2MWc5aDhhTG5jaTYyWGNGQkZ5ODFGZWxpRjNTekN1?=
 =?utf-8?B?Y2I5NkpjZGlDaU9iS2wzLzNwUXI2M0k4Y1dSTmtXeDQ3a1UxUEhtdVBkeEJl?=
 =?utf-8?B?TTI4L0IxYW0ydEp5UktjWUJEUnkzTFNhQkxTdUNGZ1ZyK3FkZ3NzendYNGFY?=
 =?utf-8?B?bEtlZDVBeHhhRnJiWStkZUNwNVA1eFd3bFVpNEF5RXNweHl1allGbzQrU2M5?=
 =?utf-8?B?ZzM5b0R6L0h6RzNGeDltcTNGejVpbEQvTjdwRVlHSzF5UDdhSWN6LzdDd0gy?=
 =?utf-8?B?M1BEVzdJRnlrbE1Bb0VpMFp2eWpiazNiazJmT1JyQlpKWEMwY3pJSi9LODR6?=
 =?utf-8?B?ajUycWZCTHNhaUNGK0RDbm1BOUsvVDFEcEYxM203dUMydnRoUkxsS0dUMG5p?=
 =?utf-8?B?WU05cXM1TU9qZTBQN25yeTBoOXFwMFJ0M25ZOEhmZWFtRlVoVWdOcmNqRVNm?=
 =?utf-8?B?cWwwV2VWODhNeFRNakF4Z3RhWGVyT2dTb2ZOckZRQ2lya2Z0cEZpMFlaVS9B?=
 =?utf-8?B?SXMzbkx3aHEwei9iUU4wMFZyanVNaFlONlJCVFdWWlVlb05EcndNdVZPWmlj?=
 =?utf-8?B?OXhneHBsN0k0K1kzTm9vQ2NXZVRkUTFwMlFEMTlna1I1Ry9Pd3B2a2pObFZ6?=
 =?utf-8?B?YnBjZnluQko3eUlIdXFKM2RqZjNTdzhaZXlLUVIzMWZsK0pnajhrWlFJM0hT?=
 =?utf-8?B?dGlTNGxJRk1od0hWZ1E2anpLbzJCYzVtV1FWTko5WUdGTUZkV2k1Vmp2TlM1?=
 =?utf-8?B?ekhOam84YktXaXB6VTljOHlSdWVNWDlGMkxSOTcwdkxtbVVkcWQ2Zy9oTTYx?=
 =?utf-8?B?YzBSL2phYVU0eENPME1ZT2FNbDF6SUZPbTdid1RBbFA3MG5nN2xuZVJzck9n?=
 =?utf-8?B?djJqSXc1dUo4OHVIMVJlKzNnTWJiTEhTYXZJK2V5WjBpMFpkWlFDaXUzM21x?=
 =?utf-8?B?YjNKSzdacU5rV2VFQzQzc2NMb0lIQk54eS91YzJGOWluVGtJVm5QV1BwT1JP?=
 =?utf-8?B?a3ZJdXUrUEllRmhIWVp4bFRQN21UbEVCUFdzTzkrZ3EyYk5qR05QWXdmWGt5?=
 =?utf-8?B?aEplV0IxVGp6azdwcGN2Sm9ObHBiM0tHSFRsN1hBcmhnSzNKajRBQ3lPK0lL?=
 =?utf-8?B?RkRvMlo3WjNkdllSSHFna0NLUGhZUEJJdnZqSWxSRThxZzA2ZkphYWRNTVVU?=
 =?utf-8?B?MzBGWEwyNjcvUm5kWWR0bDloZ2hOZ1YrU1ZHbHhPM2hnMG93K2ZiSkVYYjl5?=
 =?utf-8?B?bE44S1RDbnErQVM2WUVEemZjSUswVVZPOUgvTlpadmhxRU5WK3Bia283ek9G?=
 =?utf-8?B?aDRGaDBaTXpkZWQwaGpDUGNDZ3NGTUtqbWpjbDBVUVJuWlFWem9XbXFuVVND?=
 =?utf-8?B?NkpaSzlBZGVjMmgrOHBTczhWRUxXSFRVTkdreWxBM1hwTitCaUN2TzBuWE9Y?=
 =?utf-8?B?WEVlSGJPNzVXUlFHS3Qya0dCclJEZHJoYkRKc0JldkhHQ3RIN2RCdEZwVzRP?=
 =?utf-8?B?MmtQeWFQYS94K3lrWFBBY1libTJiRzlNMG51WWxkTWdRVlJMaW9zVGFMcEN2?=
 =?utf-8?B?MG96N3Uvdm5oN21BKzVnZEU0MUF1ZHMwa2lITCsrRXNON2xSVjUxTi9qTjZ4?=
 =?utf-8?B?TEZndUp1bWNwMnRZazNCY1I4QUpET2hZMU5DZjdpbktTUWZMcCtlOUlLTmhT?=
 =?utf-8?B?ajNBOG80VEdTQ1A2U1YwS0ZoQ1dZVkRWbjJaL3hSZVpDbllDMHZyd0dkazhM?=
 =?utf-8?B?TjJJemd0K21WVmZ6Ri95MnhxZlJzMEhJVTN4QTBwS3FVUkYwenZXUXAvcmYw?=
 =?utf-8?B?NHc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 2704decd-7bd5-4a2b-ae9a-08dc4ec5b623
X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB4965.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 01:23:45.4162
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: xQxCkxWjjiQ/PNk0hoViqxqbYGsbHllQSjcNYsD3kRRfTdjm7Y+nyokveoVDLWx+V5NID0G/awYfK8VFcS2ACA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB8720
X-OriginatorOrg: intel.com

On 1/3/2024 11:14 AM, Dapeng Mi wrote:
> code style changes.
>
> Signed-off-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> ---
>   x86/pmu.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/x86/pmu.c b/x86/pmu.c
> index a2c64a1ce95b..46bed66c5c9f 100644
> --- a/x86/pmu.c
> +++ b/x86/pmu.c
> @@ -207,8 +207,7 @@ static noinline void __measure(pmu_counter_t *evt, uint64_t count)
>   static bool verify_event(uint64_t count, struct pmu_event *e)
>   {
>   	// printf("%d <= %ld <= %d\n", e->min, count, e->max);
> -	return count >= e->min  && count <= e->max;
> -
> +	return count >= e->min && count <= e->max;

I don't think it's necessary to fix the nit in a separate patch, just squash it in some patch with
"Opportunistically ...."

>   }
>   
>   static bool verify_counter(pmu_counter_t *cnt)