Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp161866lqh; Wed, 27 Mar 2024 19:25:41 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVcrhe89EwUEt38lFODyZjhBar9Xw95E3iB9ilWANkxpmboBRyLGSQbU0PCUALZf8Lf3nQSweqXG+5gE7bqFZ6B5ic3Z7lwE97ETvP+1g== X-Google-Smtp-Source: AGHT+IGiMERdMbJu5meF4ODhCpMYqON/yuRaZ0UeznWdQxQKz/tCMfSiy35/40usNPoqxHIwNT+Y X-Received: by 2002:ac8:7f52:0:b0:431:5b18:5c5c with SMTP id g18-20020ac87f52000000b004315b185c5cmr1574244qtk.38.1711592741303; Wed, 27 Mar 2024 19:25:41 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711592741; cv=pass; d=google.com; s=arc-20160816; b=Zxt4UK/EGrO7zCVXoip5Vjnj+luknZdY9xLVX0cndl10x8fhK47WoT5uLcLfYDpqXc yxAaw+jJ9leSbGsphT0wPPqpNg80fHtFsf/AXX3TF9fyrIyxpPxBSPCuY1lIMpgy8dKG P7yqWqP9NamQH7q8LlBZ/WfcH1b/e+4FIe0yOBQn5wkSwhDnSkm9OGYfBg8kvFBX/t33 1pls9BvSrn/VMmxnKA06lnRGHX8phPUbvhKKKICRsh5KparR8JvBdd9JanaxdPa0J2I1 kzeIgif6K6hQqwR4iacQAttiybWOzI9GyuUyTbvJrZlfGA9Wga6aW8EJzPgM10UjuyxN 7NUw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:dkim-signature:date; bh=dVrUwsE3K2gkHszUejGPBHKGdhDZo6IS90T9be1UVRk=; fh=65+fBig2PNSbXrIqnpck4extSIg6rNgQnXOSUidBTZQ=; b=oNtUJfW28zVAtRxzjwH8YFKryb3oMLwxumoXPwbxjVtLQVjgLWlP0oRy+5eWZn0qx1 7Q3edsosfjPeWud6wwyolFzGfal6OgFOdtnjeoHAza76jneGoOfqu9MsUgptrb5ew3S6 GJ3i9K/oyMmMjrVBGM3xI1Uw24Ax/UHhWXf49FhsQeySpgOuooxnI3wzusAt7kopnWXO OFL4iTmiEdrz6xhFAOiRuqjP5hcWYVkZbAV+zvVveBefFjWzfuVaoJeBK4wvRymawt1Z O7xHP1S2zct6V0sAf2YZP5pkOMFwQcj9GJFZIh++/uDPS25vqusxPyl4+oYb1hOZvUmO lWOQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@jookia.org header.s=key1 header.b=G2OD3wfV; arc=pass (i=1 dkim=pass dkdomain=jookia.org dmarc=pass fromdomain=jookia.org); spf=pass (google.com: domain of linux-kernel+bounces-122334-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-122334-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=jookia.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u16-20020ac858d0000000b004313fb72cd0si465366qta.354.2024.03.27.19.25.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Mar 2024 19:25:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-122334-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@jookia.org header.s=key1 header.b=G2OD3wfV; arc=pass (i=1 dkim=pass dkdomain=jookia.org dmarc=pass fromdomain=jookia.org); spf=pass (google.com: domain of linux-kernel+bounces-122334-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-122334-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=jookia.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 0B8261C29ACF for ; Thu, 28 Mar 2024 02:25:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0CD2E288DF; Thu, 28 Mar 2024 02:25:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=jookia.org header.i=@jookia.org header.b="G2OD3wfV" Received: from out-186.mta1.migadu.com (out-186.mta1.migadu.com [95.215.58.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 026AE15EA2 for ; Thu, 28 Mar 2024 02:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.186 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711592732; cv=none; b=OgjNCw8letcdvIFNYKI6Oaxi6j0CmZROeS5zu1PazMflRABhR35X6uSdh8Y2jFRTfGhE2oeDMekUgISp0hw4t7pulGX5MTeQS1vk42KgZAQhUcxglp8Nb/qzT3DHwe1IeROWj6i1rFtwV61BScJXXZHM96iWq7qE5ZMSogxM45c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711592732; c=relaxed/simple; bh=F+2PBUITY1EMreS647dj+r5aRdhFyJY4oSvc7+Zjjm0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=R3HRn7ogMI88MfAAhBHLtVSzRKwQtyxr0xKBFgwBPsWiAim36VcOcCNfJHYk8xeqnFe/ZmtFfBDuPSk6x0I3AsOHJx3DASEwFpCY3HlUMAlPigUmGNNFMneoi+IFjv2N58qoPAJJMIboXMkEodDWHJW8w8VybDQBMc7FRH+M/ZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jookia.org; spf=none smtp.mailfrom=jookia.org; dkim=pass (2048-bit key) header.d=jookia.org header.i=@jookia.org header.b=G2OD3wfV; arc=none smtp.client-ip=95.215.58.186 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=jookia.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=jookia.org Date: Thu, 28 Mar 2024 13:21:21 +1100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1711592727; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dVrUwsE3K2gkHszUejGPBHKGdhDZo6IS90T9be1UVRk=; b=G2OD3wfVYM0ss3YS0/hftkRoFZurKH//5tklL8kaS1+kbz7cV9JwDJQEkjafN9YyOYVga7 iAtKt0h33dl4cqSGD9SpSVTKa5a2HZFKJDwhvXdHdu1Yg7PgnU5u12HM9DNO8jaFkGLDZ/ l9XiKSjm9JUd8hL3hHyG4+jDBX2AueMmetrPawbPGyroTIuOvJ57QrH3B6qjM0jWZT8sQI YPCpwn8je+YSB8wN/v/oXVTFgKH7oL468NXorJ23NSdPiuRDKz32jVPRoh6x2/wi9MavwN 1doruKSlm1g2UntpnxUDvOn5+QJWriuYDpi/056MOyPWY/gjhSTeMT/JE5WaMg== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Jernej =?utf-8?Q?=C5=A0krabec?= Cc: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Chen-Yu Tsai , Samuel Holland , linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: sunxi: sun4i-i2s: Enable 32-bit audio formats Message-ID: References: <20240326-sunxi_s32-v1-1-899f71dcb1e6@jookia.org> <23447395.6Emhk5qWAg@jernej-laptop> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <23447395.6Emhk5qWAg@jernej-laptop> X-Migadu-Flow: FLOW_OUT On Wed, Mar 27, 2024 at 08:53:32PM +0100, Jernej Škrabec wrote: > I wish it would be that simple. SUN4I_FORMATS is cross section of all I2S > variants that are supported by this driver. If you check A10, you'll see that > it doesn't support S32. > > If you want to add support for S32, you'll have to add new quirk for each > variant. Yes, A10 doesn't support it. But it should error out in hw_params due to get_sr not supporting 32-bit, no? > > Best regards, > Jernej John.