Received-SPF: pass (google.com: domain of linux-kernel+bounces-122390-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 27 Mar 2024 20:55:37 -0700
From: Isaku Yamahata <isaku.yamahata@intel.com>
To: Chao Gao <chao.gao@intel.com>
Cc: isaku.yamahata@intel.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org, isaku.yamahata@gmail.com,
	Paolo Bonzini <pbonzini@redhat.com>, erdemaktas@google.com,
	Sean Christopherson <seanjc@google.com>,
	Sagi Shahar <sagis@google.com>, Kai Huang <kai.huang@intel.com>,
	chen.bo@intel.com, hang.yuan@intel.com, tina.zhang@intel.com,
	isaku.yamahata@linux.intel.com
Subject: Re: [PATCH v19 070/130] KVM: TDX: TDP MMU TDX support
Message-ID: <20240328035537.GN2444378@ls.amr.corp.intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <56cdb0da8bbf17dc293a2a6b4ff74f6e3e034bbd.1708933498.git.isaku.yamahata@intel.com>
 <ZgTgOVNmyVVgfvFM@chao-email>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ZgTgOVNmyVVgfvFM@chao-email>

On Thu, Mar 28, 2024 at 11:12:57AM +0800,
Chao Gao <chao.gao@intel.com> wrote:

> >+#if IS_ENABLED(CONFIG_HYPERV)
> >+static int vt_flush_remote_tlbs(struct kvm *kvm);
> >+#endif
> >+
> > static __init int vt_hardware_setup(void)
> > {
> > 	int ret;
> >@@ -49,11 +53,29 @@ static __init int vt_hardware_setup(void)
> > 		pr_warn_ratelimited("TDX requires mmio caching.  Please enable mmio caching for TDX.\n");
> > 	}
> > 
> >+#if IS_ENABLED(CONFIG_HYPERV)
> >+	/*
> >+	 * TDX KVM overrides flush_remote_tlbs method and assumes
> >+	 * flush_remote_tlbs_range = NULL that falls back to
> >+	 * flush_remote_tlbs.  Disable TDX if there are conflicts.
> >+	 */
> >+	if (vt_x86_ops.flush_remote_tlbs ||
> >+	    vt_x86_ops.flush_remote_tlbs_range) {
> >+		enable_tdx = false;
> >+		pr_warn_ratelimited("TDX requires baremetal. Not Supported on VMM guest.\n");
> >+	}
> >+#endif
> >+
> > 	enable_tdx = enable_tdx && !tdx_hardware_setup(&vt_x86_ops);
> > 	if (enable_tdx)
> > 		vt_x86_ops.vm_size = max_t(unsigned int, vt_x86_ops.vm_size,
> > 					   sizeof(struct kvm_tdx));
> > 
> >+#if IS_ENABLED(CONFIG_HYPERV)
> >+	if (enable_tdx)
> >+		vt_x86_ops.flush_remote_tlbs = vt_flush_remote_tlbs;
> 
> Is this hook necessary/beneficial to TDX?
> 
> if no, we can leave .flush_remote_tlbs as NULL. if yes, we should do:
> 
> struct kvm_x86_ops {
> ...
> #if IS_ENABLED(CONFIG_HYPERV) || IS_ENABLED(TDX...)
> 	int  (*flush_remote_tlbs)(struct kvm *kvm);
> 	int  (*flush_remote_tlbs_range)(struct kvm *kvm, gfn_t gfn,
> 					gfn_t nr_pages);
> #endif

Will fix it. I made mistake when I rebased it. Now those hooks are only for
CONFIG_HPYERV.
-- 
Isaku Yamahata <isaku.yamahata@intel.com>