Received-SPF: pass (google.com: domain of linux-kernel+bounces-122397-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240328022136.5789-1-21cnbao@gmail.com>
In-Reply-To: <20240328022136.5789-1-21cnbao@gmail.com>
From: Barry Song <21cnbao@gmail.com>
Date: Thu, 28 Mar 2024 17:22:14 +1300
Message-ID: <CAGsJ_4xfCL3kVDDRNCba2f3+EvOMTGpBW8hkS71ZcvB5UeWZwA@mail.gmail.com>
Subject: Re: [PATCH v4 0/2] codingstyle: avoid unused parameters for a
 function-like macro
To: akpm@linux-foundation.org, mac.xxn@outlook.com
Cc: apw@canonical.com, broonie@kernel.org, chenhuacai@loongson.cn, 
	chris@zankel.net, corbet@lwn.net, dwaipayanray1@gmail.com, 
	herbert@gondor.apana.org.au, joe@perches.com, linux-kernel@vger.kernel.org, 
	linux@roeck-us.net, lukas.bulwahn@gmail.com, sfr@canb.auug.org.au, 
	v-songbaohua@oppo.com, workflows@vger.kernel.org, linux-doc@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 28, 2024 at 3:21=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrot=
e:
>
> From: Barry Song <v-songbaohua@oppo.com>
>
> -v4:
>  * fix Xining's email address, s/ma.xxn@outlook.com/mac.xxn@outlook.com/g

Hi Andrew,

Apologies for the oversight. Could you please apply these two patches to re=
place
the ones in the mm-nonmm-unstable branch? We need to correct Xining's email
address regardless.

>  * fix some false positives of checkpatch.pl
>  * downgrade from ERROR to WARN in checkpatch.pl
>
>  Thanks for Joe's comments!
>
> -v3:
>  https://lore.kernel.org/all/20240322084937.66018-1-21cnbao@gmail.com/
>
> A function-like macro could result in build warnings such as
> "unused variable." This patchset updates the guidance to
> recommend always using a static inline function instead
> and also provides checkpatch support for this new rule.
>
> Barry Song (1):
>   Documentation: coding-style: ask function-like macros to evaluate
>     parameters
>
> Xining Xu (1):
>   scripts: checkpatch: check unused parameters for function-like macro
>
>  Documentation/process/coding-style.rst | 16 ++++++++++++++
>  scripts/checkpatch.pl                  | 30 ++++++++++++++++++++++++++
>  2 files changed, 46 insertions(+)
>
> --
> 2.34.1
>

Thanks
Barry