Received-SPF: pass (google.com: domain of linux-kernel+bounces-122410-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240326074033.17002-1-quic_priyjain@quicinc.com>
 <9bea167d-edcf-4d66-8ec7-051e97c8dffd@linaro.org> <05d95845-85ce-bf83-57a7-135265a7508d@quicinc.com>
In-Reply-To: <05d95845-85ce-bf83-57a7-135265a7508d@quicinc.com>
From: Amit Kucheria <amitk@kernel.org>
Date: Thu, 28 Mar 2024 10:20:16 +0530
Message-ID: <CAHLCerM-iD0k-gOEtRP0y7J1k_mJpiNp1RUFhJg12V6eN7evSw@mail.gmail.com>
Subject: Re: [PATCH v4] thermal/drivers/tsens: Add suspend to RAM support for tsens
To: Priyansh Jain <quic_priyjain@quicinc.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>, Thara Gopinath <thara.gopinath@gmail.com>, 
	Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, 
	"Rafael J . Wysocki" <rafael@kernel.org>, Zhang Rui <rui.zhang@intel.com>, 
	Lukasz Luba <lukasz.luba@arm.com>, linux-pm@vger.kernel.org, 
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, 
	quic_manafm@quicinc.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Mar 27, 2024 at 3:12=E2=80=AFPM Priyansh Jain <quic_priyjain@quicin=
c.com> wrote:
> On 3/26/2024 4:30 PM, Daniel Lezcano wrote:
> > On 26/03/2024 08:40, Priyansh Jain wrote:
> >> As part of suspend to RAM, tsens hardware will be turned off.
> >> While resume callback, re-initialize tsens hardware.
> >>
> >> Signed-off-by: Priyansh Jain <quic_priyjain@quicinc.com>
> >> ---
> >> V3 -> V4: Make tsens_reinit function specific to tsens v2. Add
> >> NULL resume callback support for platform whose versions < ver_2_x
> >> in tsens ops.
> >> V2 -> V3: Remove suspend callback & interrupt enablement part from
> >> resume callback.
> >> V1 -> V2: Update commit text to explain the necessity of this patch
> >>
> >>   drivers/thermal/qcom/tsens-v0_1.c |  6 +++++
> >>   drivers/thermal/qcom/tsens-v1.c   |  3 +++
> >>   drivers/thermal/qcom/tsens-v2.c   |  1 +
> >>   drivers/thermal/qcom/tsens.c      | 37 +++++++++++++++++++++++++++++=
++
> >>   drivers/thermal/qcom/tsens.h      |  5 +++++
> >>   5 files changed, 52 insertions(+)
> >>
> >> diff --git a/drivers/thermal/qcom/tsens-v0_1.c
> >> b/drivers/thermal/qcom/tsens-v0_1.c
> >> index 32d2d3e33287..7ed85379247b 100644
> >> --- a/drivers/thermal/qcom/tsens-v0_1.c
> >> +++ b/drivers/thermal/qcom/tsens-v0_1.c
> >> @@ -329,6 +329,7 @@ static const struct tsens_ops ops_8226 =3D {
> >>       .init        =3D init_8226,
> >>       .calibrate    =3D tsens_calibrate_common,
> >>       .get_temp    =3D get_temp_common,
> >> +    .resume        =3D NULL,
> >
> > As a static variable it is already set to NULL. Why do you need to
> > explicitly set them everywhere ?
> >
> It was asked in last version to explicitly add (.resume =3D NULL). So
> added this for all the tsens platforms for which resume callback is not
> validated.

Daniel's right, you can lose this bit now that your reinit function
will only work for 2.x.