Received-SPF: pass (google.com: domain of linux-kernel+bounces-122422-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Huang, Ying" <ying.huang@intel.com>
To: Bharata B Rao <bharata@amd.com>
Cc: <linux-mm@kvack.org>,  <linux-kernel@vger.kernel.org>,
  <akpm@linux-foundation.org>,  <mingo@redhat.com>,
  <peterz@infradead.org>,  <mgorman@techsingularity.net>,
  <raghavendra.kt@amd.com>,  <dave.hansen@linux.intel.com>,
  <hannes@cmpxchg.org>
Subject: Re: [RFC PATCH 1/2] sched/numa: Fault count based NUMA hint fault
 latency
In-Reply-To: <e059df52-48fc-4e65-9eb0-c0d197625e6e@amd.com> (Bharata B. Rao's
	message of "Thu, 28 Mar 2024 10:09:50 +0530")
References: <20240327160237.2355-1-bharata@amd.com>
	<20240327160237.2355-2-bharata@amd.com>
	<87r0fvktkn.fsf@yhuang6-desk2.ccr.corp.intel.com>
	<e059df52-48fc-4e65-9eb0-c0d197625e6e@amd.com>
Date: Thu, 28 Mar 2024 13:21:58 +0800
Message-ID: <87msqjkk21.fsf@yhuang6-desk2.ccr.corp.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii

Bharata B Rao <bharata@amd.com> writes:

> On 28-Mar-24 7:26 AM, Huang, Ying wrote:
>> Bharata B Rao <bharata@amd.com> writes:
>> 
>> [snip]
>> 
>>> @@ -1750,25 +1753,20 @@ static bool pgdat_free_space_enough(struct pglist_data *pgdat)
>>>  }
>>>  
>>>  /*
>>> - * For memory tiering mode, when page tables are scanned, the scan
>>> - * time will be recorded in struct page in addition to make page
>>> - * PROT_NONE for slow memory page.  So when the page is accessed, in
>>> - * hint page fault handler, the hint page fault latency is calculated
>>> - * via,
>>> + * For memory tiering mode, when page tables are scanned, the current
>>> + * hint fault count will be recorded in struct page in addition to
>>> + * make page PROT_NONE for slow memory page.  So when the page is
>>> + * accessed, in hint page fault handler, the hint page fault latency is
>>> + * calculated via,
>>>   *
>>> - *	hint page fault latency = hint page fault time - scan time
>>> + * hint page fault latency = current hint fault count - fault count at scan time
>>>   *
>>>   * The smaller the hint page fault latency, the higher the possibility
>>>   * for the page to be hot.
>>>   */
>>> -static int numa_hint_fault_latency(struct folio *folio)
>>> +static inline int numa_hint_fault_latency(struct folio *folio, int count)
>>>  {
>>> -	int last_time, time;
>>> -
>>> -	time = jiffies_to_msecs(jiffies);
>>> -	last_time = folio_xchg_access_time(folio, time);
>>> -
>>> -	return (time - last_time) & PAGE_ACCESS_TIME_MASK;
>>> +	return count - folio_xchg_fault_count(folio, count);
>>>  }
>> 
>> I found count is task->mm->hint_faults.  That is a process wide
>> counting.  How do you connect the hotness of a folio with the count of
>> hint page fault in the process?  How do you compare the hotness of
>> folios among different processes?
>
> The global hint fault count that we already maintain could
> be used instead of per-task fault. That should take care
> of the concern you mention right?

I have plotted the total number of hint faults per second before, and it
changes a lot along the time.  So I don't think it is a good
measurement.

--
Best Regards,
Huang, Ying