Received-SPF: pass (google.com: domain of linux-kernel+bounces-122446-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
References: <20240322085606.993896-1-allencl_lin@hotmail.com>
 <TY0PR06MB56116F0902017225C78EDDDD9E312@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <20240322-mammary-boil-f9a4c347fba1@spud> <20240322183009.GA1227164-robh@kernel.org>
 <20240322-rectified-udder-fef9102f58da@spud> <TY0PR06MB56110ADEA805B68BE2B887069E352@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <20240326-whoever-spotter-1fe7ace35428@wendy> <TY0PR06MB561197578717990F4BEA93D29E352@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <20240326-granite-snipping-7c8b04480b2e@spud> <TY0PR06MB5611AE812B72B349E85118D59E342@TY0PR06MB5611.apcprd06.prod.outlook.com>
 <20240327-pegboard-deodorize-17d8b0f1e31c@spud>
In-Reply-To: <20240327-pegboard-deodorize-17d8b0f1e31c@spud>
From: Allen Lin <allencl_lin@hotmail.com>
Date: Thu, 28 Mar 2024 14:05:17 +0800
Message-ID:
 <TY0PR06MB5611F7123B22C4FDEE319C049E3B2@TY0PR06MB5611.apcprd06.prod.outlook.com>
Subject: Re: [PATCH v1 1/4] dt-bindings: input: Add Himax HX83102J touchscreen
To: Conor Dooley <conor@kernel.org>
Cc: Conor Dooley <conor.dooley@microchip.com>, Rob Herring <robh@kernel.org>, 
	dmitry.torokhov@gmail.com, krzysztof.kozlowski+dt@linaro.org, 
	conor+dt@kernel.org, jikos@kernel.org, benjamin.tissoires@redhat.com, 
	linux-input@vger.kernel.org, devicetree@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: TY0PR06MB5611:EE_|TYSPR06MB7453:EE_
X-MS-Office365-Filtering-Correlation-Id: 9135e4b0-1317-4d51-7f45-08dc4eed13fa
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	ivJPNZxv3QhkC40zxnXC+JfTVrp3MLjocr9rRF3VpBQJISYXivBIfa3ZtKBpKSzowZhoSKAN9fdMWJilSY5JYADI0fi5cW8A+GlqaTtmiUOKaJg/K3EMyGHQ7Cxb3ILO7q+WBDP9hqOPsz0b2lxuix89IbJA90NxXdXuU4OsuifMTKQXvs/YTnFOD2/JKxV9agNvr7arvNS2YDfKYESAD+yWBjCi6wSIR6UfrB6eAmunKDYTV6+n2/6AJdhHccSdOJNpVczAw1uGrA763lRYSkEj1uSIf0m/+K4COJyEDuMkV7Xbkyvj8pNAYlPkezVny5W7s3wmaL3JvHImfsuLS9uCMjFs60e8wOG3tfpZI/ZfkL0NjM4RIZKfy/gBO3W5iYoRXxqC5s6niWAjzyn6dxYB6BMzeJsHMe+GsgaT50pVwKmmYlpl9RiSg8n5jreqmyEAFk41BpZG1TRt0hOzfs6KdKCfDldmlyELhPBvckw8Om/JROGYcILRlog9SopY3BvZTNe557Ke98YdUBtqjhX/AgmckkJIYuagXjWE7e9WiBa6G5jrkL92LPW4ql8LbeL4NdR/Rkwyh49JKJreiiR/KSQm4n4NGgu3TA861DW8j+ZTA+kXsu22Y1j3aprFgEzwvvOhX466U0b4KZ4dQRzhGJR7FO6KxhJ2f13yZCw=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?N3VqeUdITXdCOXAraFdidS9EZHMybjJtYXhaTFVMb1FLVmxkVmttNlpTMXNv?=
 =?utf-8?B?V2I4SE1DNGhCc2lwMXJZNnF3ZklDMVRyQklLVGZWUTBZS2JVUHF3QW43NkpC?=
 =?utf-8?B?cDNyeWE0ektneWNlYUk1dWswZVV5Qk54cGplZWRNTGF5ODdQSmpBbmpwLy90?=
 =?utf-8?B?cFd6SDBHbGlxc0x4NElDSGQwV011OExCdHh4aC9Nd1FleDFSN09MRnhJcVhY?=
 =?utf-8?B?NTNTYUNFKzVNS01helhFbVhNT0JwSjJubEtFejdybFJuSE16Q2xuN05TM3c4?=
 =?utf-8?B?emNDc045R3pKcUQ5cnQrSUU2czdnNmdWVXpSNE9IekNMU1Z5SWx2S2VlVGwr?=
 =?utf-8?B?Y0ZDNW9mNjhXVE9lb3hob1FtTm1TcEV0WGtpMS8yRWwwdHlEaXBJZFBFeXoy?=
 =?utf-8?B?SmdqdWREU3ZQeVdMUzFpS1hPYTFuR0Z6aHl0SHVMVGtXVFphU0ozb1N6NXV1?=
 =?utf-8?B?elV4WEdQMFFxK0w2SFY4R05JdTFJdXhXNnNhM3lYZzhVT09GUDBZMThwUmhr?=
 =?utf-8?B?UnBrOElEbFNpTE9nc1BxRWdmejBSRFlRUGJMOE54amErS1dwMVdIQXNnQ0RO?=
 =?utf-8?B?RkZjaHE2NW9ibVlOOXNEd2VOT081MWdiTnhHSU0wSHd4Q01nVWFaR3Y3NENW?=
 =?utf-8?B?VVRNNkUySEVGZlJYelZIYmdVQ1dyWFVnMzJtUnVHQjcvTTk4K3hudkV0UTBa?=
 =?utf-8?B?RGJralJwSzVrRGJSR3U2U3k4STZ6N1Z6TWhndjZuS0ptM2RFSDJGN1hWR2Ju?=
 =?utf-8?B?YkR6Y0FFcit0b2xiaCtPa2ZOaXVWU1hhWTJLQi9uNUhEeUxsYjlRK3NORkhM?=
 =?utf-8?B?LzN6RDAzbE1oSG1yUWQzQXN0bU9wMWNSVEluK2QwNzZ2OHFMdWpBd3ZiRjJR?=
 =?utf-8?B?Q1A4OGhnYkdIY3NSTkptTlYzZXNOc0EveDhiaEFYQjRUNi93bFd5bG9KV1Fi?=
 =?utf-8?B?UUtzNUJKcDk0a1BTdEt0L3N1VHJlY0RSdk9wTGJrcHgwSzJaVW51L0V3V3dI?=
 =?utf-8?B?QWtNQnVacHdKQ0lGcW9IcGFSNmc0eDVJUFVZbGl6cHI0SjNZc0tmdnNtVGh4?=
 =?utf-8?B?ak5SdE9pQXlwT2RzNExZNVJtNXFaSU43N2tXVzJkQXNFWXUvYUNiQ1VJT1B6?=
 =?utf-8?B?bU9GTWsvQmpZMDh0U3hOaStONzcrS2V6TUtPeTFTdWxwa3E4dlBueGZYUEhm?=
 =?utf-8?B?WkthMlpwV1FrRS9mUnF2OFlIR0FHbE1tS2QyS1NUaTJjbkdRS0w3TFVSbzEv?=
 =?utf-8?B?azVtK1R5YmZjNW9IU2RrSEtseXV6QXpoTU9iK1F1TzBqcVB1d3RXWDhpS05n?=
 =?utf-8?B?ZjBMdm9NMmpaczZmN0gzWjZUMWJ5SU1WNVFIZmlLRWwvb2RGdHU1Z3VtbTJh?=
 =?utf-8?B?SURzOWplN081Y0VRZHVkTWVNK3NoK2tMRjJvdytFQlIrNzlUYXlJK1JCa1BG?=
 =?utf-8?B?M3ljU2F0Mkx4REZXM3NnR0prTlh2YSszaDBXanpXYXJJTmQvVTR6aGlYbXpv?=
 =?utf-8?B?ZmlDMHBlRloySEFxT3pzQ1A0QXRoUmlId29DRmtXMHVTWDVQWExhQ0I5UXRk?=
 =?utf-8?B?dE5Rbm5OeUJmWm8vRWxsc2VKQmo3MXpmNGppcFJVamZMTmlCbFgwaFR5anBR?=
 =?utf-8?B?elZqcUdQb3B4anJOelU1eUNuWlQvTVo2bHI2WnNsUFFmZHI3b0llTSswa2tz?=
 =?utf-8?Q?DpmkkIWWIYPWhMsqFeAk?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-3208f.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 9135e4b0-1317-4d51-7f45-08dc4eed13fa
X-MS-Exchange-CrossTenant-AuthSource: TY0PR06MB5611.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 06:05:33.0481
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYSPR06MB7453

Conor Dooley <conor@kernel.org> =E6=96=BC 2024=E5=B9=B43=E6=9C=8828=E6=97=
=A5 =E9=80=B1=E5=9B=9B =E4=B8=8A=E5=8D=8812:44=E5=AF=AB=E9=81=93=EF=BC=9A
>
> On Wed, Mar 27, 2024 at 03:48:48PM +0800, Allen Lin wrote:
> > Conor Dooley <conor@kernel.org> =E6=96=BC 2024=E5=B9=B43=E6=9C=8827=E6=
=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=883:28=E5=AF=AB=E9=81=93=EF=BC=9A
> > >
> > > On Tue, Mar 26, 2024 at 06:40:28PM +0800, Allen Lin wrote:
> > > > Conor Dooley <conor.dooley@microchip.com> =E6=96=BC 2024=E5=B9=B43=
=E6=9C=8826=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=884:48=E5=AF=AB=E9=
=81=93=EF=BC=9A
> > > > >
> > > > > On Tue, Mar 26, 2024 at 01:46:56PM +0800, Allen Lin wrote:
> > > > > > Conor Dooley <conor@kernel.org> =E6=96=BC 2024=E5=B9=B43=E6=9C=
=8823=E6=97=A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=882:34=E5=AF=AB=E9=81=93=
=EF=BC=9A
> > > > > > >
> > > > > > > On Fri, Mar 22, 2024 at 01:30:09PM -0500, Rob Herring wrote:
> > > > > > > > On Fri, Mar 22, 2024 at 05:54:08PM +0000, Conor Dooley wrot=
e:
> > > > > > > > > On Fri, Mar 22, 2024 at 04:56:03PM +0800, Allen_Lin wrote=
:
> > > > > > > > > > Add the HX83102j touchscreen device tree bindings docum=
ents.
> > > > > > > > > > HX83102j is a Himax TDDI touchscreen controller.
> > > > > > > > > > It's power sequence should be bound with a lcm driver, =
thus it
> > > > > > > > > > needs to be a panel follower. Others are the same as no=
rmal SPI
> > > > > > > > > > touchscreen controller.
> > > > > > > > > >
> > > > > > > > > > Signed-off-by: Allen_Lin <allencl_lin@hotmail.com>
> > > > > > > > >
> > > > > > > > > note to self/Krzysztof/Rob:
> > > > > > > > > There was a previous attempt at this kind of device. This=
 version looks
> > > > > > > > > better but might be incomplete given there's a bunch more=
 properties in
> > > > > > > > > that patchset:
> > > > > > > > > https://lore.kernel.org/all/20231017091900.801989-1-tylor=
_yang@himax.corp-partner.google.com/
> > > > > > > >
> > > > > > > > Those don't look like properties we want coming back.
> > > > > > >
> > > > > > > Oh, I don't want most of them coming back either. There are s=
ome
> > > > > > > supplies in there though that I think we would like to come b=
ack, no?
> > > > > > > Maybe this particular device doesn't have any supplies, but t=
hat doesn't
> > > > > > > really seem credible.
> > > > > >
> > > > > > We will use Firmware-name in Device Tree.
> > > > >
> > > > > > For power supply settings, because there may be other device us=
ing
> > > > > > same regulator.
> > > > >
> > > > > If there are other devices using the same regulator is it more
> > > > > important that you document it so that it doesn't get disabled by=
 the
> > > > > other users.
> > > > >
> > > > > > We plan to define it as an optional property for user to contro=
l in
> > > > > > next release.
> > > > >
> > > > > I don't see how the regulator would not be required, the device d=
oesn't
> > > > > function without power.
> > > > >
> > > > > Thanks,
> > > > > Conor.
> > > >
> > > > I will set power supply as required.
> > > > The description of power supply as below,
> > > >
> > > > properties:
> > > >   vccd-supply:
> > > >     description: A phandle for the regualtor supplying IO power. Sh=
ould be own
> > > >                  by TPIC only.
> > >
> > > What does "owned by TPIC" only mean? Why would the vccd supply not be
> > > allowed to be shared with another device?
> > >
> > > > This works for TP digital IO only, main power is
> > > >                  given by display part VSP/VSN power source which i=
s controlled
> > > >                  by lcm driver.
> > >
> > > What drivers control things doesn't really matter here, we're just
> > > describing the hardware. If there's another supply to the controller,
> > > then document it too please.
> > >
> >
> > Below is IC power sequence introduction.
> > https://github.com/HimaxSoftware/Doc/tree/main/Himax_Chipset_Power_Sequ=
ence
> >
> > TDDI IC, which means Touch and Display Driver is integrated in one IC,
> > So some power supplies will be controlled by Display driver.
>
> If someone was to turn off the supplies, would the touch component stop
> working? The document says that these supplies must be turned on before
> the touch supplies, so I'm going to assume that both are needed for the
> device to function.
>
> > In yaml Document, can we just list power supplies controlled by touch d=
river?
>
> If the touch part of this device needs the supplies to function, then
> you need to mention them, regardless of where they're controlled. All we
> are doing in the binding is describing the hardware. What drivers do
> what depends entirely on what software you're using.
>

OK, I will list all supplies required by the driver in the Yaml
document as shown below,

properties:
  compatible:
    const: himax,hx83102j

  reg:
    maxItems: 1

  interrupts:
    maxItems: 1

  reset-gpios:
    maxItems: 1

  vccd-supply:
    description: A phandle for the regualtor supplying IO power.

  vsn-supply:
    description: Negative supply regulator.

  vsp-supply:
    description: Positive supply regulator.

  ddreset-gpios:
    description: A phandle of gpio for display reset controlled by the
LCD driver.

required:
  - compatible
  - reg
  - interrupts
  - reset-gpios
  - panel
  - vccd-supply
  - vsn-supply
  - vsp-supply
  - ddreset-gpios


Thanks,
Allen