Received-SPF: pass (google.com: domain of linux-kernel+bounces-122447-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 28 Mar 2024 11:35:06 +0530
From: Dhruva Gole <d-gole@ti.com>
To: Tony Lindgren <tony@atomide.com>
CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby
	<jirislaby@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
        Petr Mladek
	<pmladek@suse.com>, Steven Rostedt <rostedt@goodmis.org>,
        John Ogness
	<john.ogness@linutronix.de>,
        Sergey Senozhatsky <senozhatsky@chromium.org>,
        "David S . Miller" <davem@davemloft.net>,
        Andy Shevchenko
	<andriy.shevchenko@linux.intel.com>,
        Ilpo =?utf-8?B?SsOkcnZpbmVu?=
	<ilpo.jarvinen@linux.intel.com>,
        Johan Hovold <johan@kernel.org>,
        Sebastian
 Andrzej Siewior <bigeasy@linutronix.de>,
        Vignesh Raghavendra
	<vigneshr@ti.com>, <linux-kernel@vger.kernel.org>,
        <linux-serial@vger.kernel.org>, Sebastian Reichel <sre@kernel.org>,
        <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v7 7/7] Documentation: kernel-parameters: Add DEVNAME:0.0
 format for serial ports
Message-ID: <20240328060506.zhd7xctahudscoao@dhruva>
References: <20240327110021.59793-1-tony@atomide.com>
 <20240327110021.59793-8-tony@atomide.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240327110021.59793-8-tony@atomide.com>

Hi Tony,

On Mar 27, 2024 at 12:59:41 +0200, Tony Lindgren wrote:
> Document the console option for DEVNAME:0.0 style addressing for serial
> ports.

Thanks, this will really add in more context for people unaware.

> 
> Suggested-by: Sebastian Reichel <sre@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  .../admin-guide/kernel-parameters.txt         | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
> 
> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -785,6 +785,25 @@
>  			Documentation/networking/netconsole.rst for an
>  			alternative.
>  
> +		<DEVNAME>:<n>.<n>[,options]
> +			Use the specified serial port on the serial core bus.
> +			The addressing uses DEVNAME of the physical serial port
> +			device, followed by the serial core controller instance,
> +			and the serial port instance. The options are the same
> +			as documented for the ttyS addressing above.
> +
> +			The mapping of the serial ports to the tty instances
> +			can be viewed with:
> +
> +			$ ls -d /sys/bus/serial-base/devices/*:*.*/tty/*
> +			/sys/bus/serial-base/devices/00:04:0.0/tty/ttyS0
> +
> +			In the above example, the console can be addressed with
> +			console=00:04:0.0. Note that a console addressed this
> +			way will only get added when the related device driver
> +			is ready. The use of an earlycon parameter in addition to
> +			the console may be desired for console output early on.

Reviewed-by: Dhruva Gole <d-gole@ti.com>

-- 
Best regards,
Dhruva