Received-SPF: pass (google.com: domain of linux-kernel+bounces-122456-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <870730a8-cabc-46ab-9ec9-f8e667842203@amd.com>
Date: Thu, 28 Mar 2024 01:16:43 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 2/2] tracing: Include Microcode Revision in mce_record
 tracepoint
Content-Language: en-US
To: Sohil Mehta <sohil.mehta@intel.com>, linux-trace-kernel@vger.kernel.org,
 linux-edac@vger.kernel.org
Cc: rostedt@goodmis.org, tony.luck@intel.com, bp@alien8.de, x86@kernel.org,
 linux-kernel@vger.kernel.org, yazen.ghannam@amd.com,
 Avadhut Naik <avadhut.naik@amd.com>
References: <20240327205435.3667588-1-avadhut.naik@amd.com>
 <20240327205435.3667588-3-avadhut.naik@amd.com>
 <67ba2ece-6b46-4ae1-a944-a38f84360d0f@intel.com>
From: "Naik, Avadhut" <avadnaik@amd.com>
In-Reply-To: <67ba2ece-6b46-4ae1-a944-a38f84360d0f@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?Q3l2NkRCV3dBODYwMGRjWTBETFZ1UUZHOHJ0M1ZYM3E2NTlkQ3FFREo3MnRH?=
 =?utf-8?B?MWt3QmMvWVV3YTFJelhkK2xaUVkzNVo1bG5XUG5ObWU3YThjbnhteSs5dkZC?=
 =?utf-8?B?bVJaNWFTU212YUg2dVJCWUdubzR0VGk5bnZkY3dOMHBxMkRteitadDQ3VXh2?=
 =?utf-8?B?YnZpd2E0STAxR0tmYWt2WXk4dXFmUUpoOWhQUXZxREJLd0thaERGcjdvNEVN?=
 =?utf-8?B?Tm1vN0lWamVBRVZDTDBUNVVMcjYxTkFjOGVFeVRkSEJmd0R1eko5SzBJRW5s?=
 =?utf-8?B?Sk9QdVNGRWw1VXppSGo0dWgycFBFSWhDbU1acXFpWWhTQnJyNGdOeU5jSmll?=
 =?utf-8?B?N2cxd2FPUy9jWDBNTUdDY0xadklYanlzRzhMSGZXdjBhQk8ySE5VdWFqZk1r?=
 =?utf-8?B?enpBeDAxSURlS0w4NGpSY2lmaUNVSEdzaWhOMnEyNjJxVm1FeDBib043ajls?=
 =?utf-8?B?cGF5ZHlZV0ZSbUZLemlCQ29kMHQydytyVUZneE1uY01ueU5GcDQxbm9iRzgz?=
 =?utf-8?B?N25DcGFtTnFyNy9ROU9FS0JLOFJwZWFzbUtEK2Vkb2svSXl6ZzdXVnBHTEFU?=
 =?utf-8?B?MlA2UVdMRVY1QXJKclJCNWlRUXBzbTd0bHM5dUFNcmViWkZNRWY0Si9RcEFt?=
 =?utf-8?B?MmVsamFQNVZvMFN4ZXJCdDlnZjN2Vm9TV1Z6b0xUWVJsMXhacC8yaXJSYUJm?=
 =?utf-8?B?ZzczZjdzT0NZaTdRdk4zM3Jxb29tMEQwcjhWSFA3Z0tWTVRLbzNqZUlTVjNw?=
 =?utf-8?B?Q2hqUTk0eXYvRjNKQS9DeS9CS1Qzdk8xSk93aEVXUFY5K0VDLzJpazI1NHhR?=
 =?utf-8?B?U3B2dzJuM2V0QmR6NG1lTGx2bXpTS0hmOTg0elovYTRUQTZ1bXRDMFF5Q25P?=
 =?utf-8?B?cURpSXZVNmNkQXlZL2pyUjNic2gzQjdDMEJVcjlGaVE5dFE3aytqZzVBQm45?=
 =?utf-8?B?QXpUZ2pqNlR1dWlqcU41Ym9CTnFERTQ1RmZvRlR2a3NlYjcyNnJjMjE1TTBD?=
 =?utf-8?B?cnM2SzY0SGJFY1VuZnJ5MDdPWUJRSlBKZ0pLV0JtZUJ6cHlqMTdhNkxHS2dK?=
 =?utf-8?B?N3Y3NnFOQm9ldk8xMFp6cytIdkFxZllFN3Z0UjUrTXlTYXJMYmZVQzRlUzdo?=
 =?utf-8?B?NXdoTzJpUDlaMTlrSXdRYnp6OVp5SithRVlmZFpxdkRub1d2UUZYT3pRV3Iy?=
 =?utf-8?B?MDJFME5sekFzKytoK29yeHY0cHV3VERiNFMyajRJdmhISDdrZnd4NDJtWUo0?=
 =?utf-8?B?alF4RkRUTU1iMEpSRnZlVDd4M0Z3MG5zamZHWC9qaVBlaWpQTjQwQ1NzTjll?=
 =?utf-8?B?bHY3K0I4djZpNEFETGhlTUVYOUUrVUphVTlzckdZWnp6RTlGbzVVS3JMQ3Mv?=
 =?utf-8?B?ejY3SldxYis2NmJ0d21nMWE1ZGg5dnlWTzdUc1ptbXJFMVE3TDRKc2syS1g2?=
 =?utf-8?B?ZnZzRy9vWGRuRmpEK2o3M2pVNFVISUdQSS94clBYVWh5TkdpcXFMQXBWVzFH?=
 =?utf-8?B?L1V0dWpZc3IraUR4RWw0dWRWb3VlRWZNazFGcFRPclRuSy94NWJUTlVtUCtX?=
 =?utf-8?B?a2wxbGkxamtQNHBYeWQvZG9CVit4QlZGSGUwR2N4YlQyei9oWWpSZEUyZnl0?=
 =?utf-8?B?YW1IMnc4czVTQ2JMTXhtbDM4N3JZTG11RjVNNmVFaWxZdGdsNFU1VURQSGh3?=
 =?utf-8?B?elErTTR0b3MyaVJXenpJVkluQzAxZUk3QWlLdnEweUN1UEdMY09TMWdQOXZ1?=
 =?utf-8?B?UzRlNmFhYmhXSUh2Zzg1ZHF5WHdlNVpibjZPVGZlNmZ0RVNKY20zdGlRMXhW?=
 =?utf-8?B?QStnZzJwczhPbGROQ2lURXFQMXpkbTRSYzVHVksraDhla2NZWHVUSWM1cWky?=
 =?utf-8?B?c2ZHOTJnUDA0ay9DU25hbGlqR3E3emFCaDdxZ3RSSXNvbUZDZlBDZDk4V3Mv?=
 =?utf-8?B?d1FkbHEyQy9QTXF6MjdINVFGVis3aHhkdm4rcWRocFBDYzdoR1lhR0hEVXgy?=
 =?utf-8?B?dFRqT2FEa0QvN1BsUEkvOGd2SjRtQkdTNEt3Z2orU2pVS1NHWG5VL1Q2cUxz?=
 =?utf-8?B?ajgxUkNUdHhMOGNxV1lsM3lSbldsMFFkbjd1UG5MWHJ5TE9yYjBiRE05b0c3?=
 =?utf-8?Q?RZaZZjQSVITtk5IT9jkWc0QHK?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1cbdbdb9-747d-40ce-c64c-08dc4eeea549
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8403.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 06:16:46.3834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gnEGaSGE/NJ3gROlyFbZKdS1Bm+Bd6fRluaHzCzrWm34IaTDybmJDTOSysCq3GnPp8QTh7plG+qE+GLTMQiHAQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7581


On 3/27/2024 17:31, Sohil Mehta wrote:
> On 3/27/2024 1:54 PM, Avadhut Naik wrote:
> 
>> -	TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x",
>> +	TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x, MICROCODE REVISION: %x",
> 
> Nit: s/MICROCODE REVISION/MICROCODE/g
> 
> You could probably get rid of the word REVISION in the interest of
> brevity similar to __print_mce().
> 
> 	pr_emerg(HW_ERR "PROCESSOR %u:%x TIME %llu SOCKET %u APIC %x microcode
> %x\n",
> 		m->cpuvendor, m->cpuid, m->time, m->socketid, m->apicid,
> 		m->microcode);
> 
>
Okay. Will remove "REVISION".
> -Sohil

-- 
Thanks,
Avadhut Naik