Received-SPF: pass (google.com: domain of linux-kernel+bounces-122457-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <d63a6e47-204f-44a4-8789-d4e41de39ec3@amd.com>
Date: Thu, 28 Mar 2024 01:17:43 -0500
User-Agent: Mozilla Thunderbird
Subject: [PATCH v4 2/2] tracing: Include Microcode Revision in mce_record
 tracepoint
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>
Cc: Avadhut Naik <avadhut.naik@amd.com>, linux-trace-kernel@vger.kernel.org,
 linux-edac@vger.kernel.org, rostedt@goodmis.org, tony.luck@intel.com,
 x86@kernel.org, linux-kernel@vger.kernel.org, yazen.ghannam@amd.com,
 Sohil Mehta <sohil.mehta@intel.com>
References: <20240327205435.3667588-1-avadhut.naik@amd.com>
 <20240327205435.3667588-3-avadhut.naik@amd.com>
 <67ba2ece-6b46-4ae1-a944-a38f84360d0f@intel.com>
 <20240327223522.GDZgSfKj1CVyZ0zfxs@fat_crate.local>
From: "Naik, Avadhut" <avadnaik@amd.com>
In-Reply-To: <20240327223522.GDZgSfKj1CVyZ0zfxs@fat_crate.local>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QmJDcFNpTHorN3dqZHFYa1laTFo3TDdSdFF3Ymo2SEZRU043Y3htYnlHemNJ?=
 =?utf-8?B?MzJwdk5zSmlJVE51R0VLVEdrNXRBT3E3bDJwZ1RwcUFvT1BQWmphcS9laGdh?=
 =?utf-8?B?MWh2VVYwa0xBQnlZUEg5NGZESDVtdFBEOERwTEFkdWN3YXpwUDJOQXl5WDZ0?=
 =?utf-8?B?RldXZ3NHL3cycnFUcXVUUWxRMWdvYXFIekczeGh6NEMvUDhyQ0wyQTc3ZVhM?=
 =?utf-8?B?V0ZPb2REWWlMM05ZSnR5UC9WR3BnVndWb2tTRkducWxIemh4eUpQcGFKcDFX?=
 =?utf-8?B?NkVhY0ZPN3lVSTFXaldmUmpPNVZ0eGY4M0Y0c2FQaWlDNU1YK0l4RFVKMUtS?=
 =?utf-8?B?Z3hkQm1YNjk4c1ZPbVhSMTZSOGVNWEtad0FCdFJZMVcyWTBjTmlYQUh0Y3VZ?=
 =?utf-8?B?NVlLWGZQMEhmRjZYcWl5aDV6dWgwZllmNlhra2prMmZxVDY0WW9kbzRuRHZF?=
 =?utf-8?B?dWwzbDVmam5HUXpTczM2YU1FNW50cGpCRWVGdzFIb1FTYy96MTFjdVcvTG1o?=
 =?utf-8?B?V2lzUUlvVFc5YjdBenFlY3R5eFNmSEhFMXREZ1djMEk4QVlraElLL1F3Y3N1?=
 =?utf-8?B?M0tmM1ZvSDBvdEtoUEpxdnpXTHB1TXNIajFNR1hPY0lmSFdsWDBBalRCT1pZ?=
 =?utf-8?B?TUpKZCtEdktwVnFIbzZsRnBMUlVyTHVWT0F5d3h6blRxRVgvUmJ6eFF0d0p5?=
 =?utf-8?B?ZUlsRWpzVVQydWhYa3RKOUxnNHdCTW1LNEErK1g2WlA4blcvUmdIbHRJZ3py?=
 =?utf-8?B?WFpWVVdBczBHUkxoSlFKaUh5b2RycmZmWW1WNFY1WHhXVnNmVlE1ZG9QVWUv?=
 =?utf-8?B?M0d4aEhGaU85cHB0N2hsU3c3dlNQWVBNVGU5L2pBc1J4eWthMUg5aGFtZEhy?=
 =?utf-8?B?b3FKMGt2ckZVQ3BaS0lveGV5UXFmOWhIZm9sRTlFMVg2bnQ0WnhNcEdlVys3?=
 =?utf-8?B?R3JRdVpjUVV3TTVkRWI0S08rY2pWaEMyQjZIWEVScU1HODUwYmRkaFAvOUNR?=
 =?utf-8?B?QmtjN2hiUU85MHRhZ3pQY0FNRUFKWTNhaURUV2Zmc1N1dzNrNTJ3aC90RWZJ?=
 =?utf-8?B?dTRjN2lXbjFPVGgrNDFkbk5qeGRiYjFsVUpkMHd6NGJKZEd2ZUp1NW1ldmVQ?=
 =?utf-8?B?emQwc1UrVWxUajNTQmtYay9nU2swN3VKeitRZmRMTDVoNGpJaEtKRnM5ZG1N?=
 =?utf-8?B?N2hIWXFiRkFNcU5DbHNJcW9ISkVTZGwyQmVFWUdaeGtZMTZTaEVDQlRMZVFj?=
 =?utf-8?B?TXN6TFR5bFBCc3F0TXBzckI3ZXdIbG5tbk9xQ0tvSnFCaHdLZ1g5Ty9xYmtu?=
 =?utf-8?B?eHR3QmluNTBWdzJrRmNDNi9ONFhkSlk3MHV3M2hjWHNiSEMrNHdscHJqRUZU?=
 =?utf-8?B?UVhEbVFxV29UbSs5eUV0N254VXg4VGE2WFlVTDA2SE41TDdkcEVSaHJSQUI5?=
 =?utf-8?B?NkhCQnh0Rjg2d1RPOTlKaVR0TTlyQXdaTjV1Sjdhb0ljelhsUnZBM1JTcXJt?=
 =?utf-8?B?WGFCZ1BUMXRyRTk5NXFpNit1ZXl1QUhScVp1dXpRQ2dGalpISnp2OGtFcVk3?=
 =?utf-8?B?UnFJdlVnTzk0aHYzQjdpVm53WXVQcEk1KzFJOXlXbmdyWlgxMHAyREpYZmxm?=
 =?utf-8?B?ZDlLTkJQYTFWM2ZYenFRa05yM3JZSGdqZlNxTVo3TFI5V0RDV2VHajFndnRp?=
 =?utf-8?B?TFZLVzVDN1doSVJZZ1dXUDNob3ZGOFBlMU5ya1pYOE52NzZNRUY3NU8vN0VV?=
 =?utf-8?B?bDdiUEJLcE5ISmNrQjBvVmhiZE1aa3lCaWtTYm1CdHVwbzM4bzc1aENZMk9k?=
 =?utf-8?B?K0JOZ0hsd2g4bENLTUhlL0k2cUNodGdPaGNjU2RuTFMwZS80Q21xM2d3ZDB4?=
 =?utf-8?B?TUE4K3U1Q0I2czRYT3lENHhUenNUNDFBZ0RtMmY3aWg4T1Y1eWdydnhuS2lV?=
 =?utf-8?B?UjJQdkRGcVR4RGRScjB3UGljRUJ2U0dzNUZKTE9sZjJySXlicjkyMjN1OUta?=
 =?utf-8?B?VG4ySU5Obld5OStVZEJKQi8vS3pKYzRNYnpiNkNkcmw5aDVsNnJCZFlkOVZY?=
 =?utf-8?B?QjNNeS81eTdaZFN2Y2Q5R0NNWWdCVWNHVE8zZmpPRE52K3BuRHhHVERONWlQ?=
 =?utf-8?Q?VF5cjZ8r2k2j/I4firdxO/UEk?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 09ae279e-da56-4e7d-054a-08dc4eeec7ef
X-MS-Exchange-CrossTenant-AuthSource: CH3PR12MB8403.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Mar 2024 06:17:44.4541
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d1IhU2YPDyAdnEO4WPleIvzP+0cj+Rnr4lTsz0qNoF3vhMunCq91YvHTz37SrcH1jXAtWY9Hc4jNx4yNYakDRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7581


On 3/27/2024 17:35, Borislav Petkov wrote:
> On Wed, Mar 27, 2024 at 03:31:01PM -0700, Sohil Mehta wrote:
>> On 3/27/2024 1:54 PM, Avadhut Naik wrote:
>>
>>> -	TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x",
>>> +	TP_printk("CPU: %d, MCGc/s: %llx/%llx, MC%d: %016Lx, IPID: %016Lx, ADDR/MISC/SYND: %016Lx/%016Lx/%016Lx, RIP: %02x:<%016Lx>, TSC: %llx, PPIN: %llx, PROCESSOR: %u:%x, TIME: %llu, SOCKET: %u, APIC: %x, MICROCODE REVISION: %x",
>>
>> Nit: s/MICROCODE REVISION/MICROCODE/g
>>
>> You could probably get rid of the word REVISION in the interest of
>> brevity similar to __print_mce().
> 
> You *definitely* want to do that - good catch.
> 
Will do.

> And TBH, all the screaming words aren't helping either... :)
> 
Are you suggesting to change the ALL CAPS format of words which are
not acronyms to normal Capitalization style? Like Sohit suggested
in his other mail on this thread?

Somewhat like below:

SOCKET -> Socket
PROCESSOR -> Processor
MICROCODE -> Microcode

-- 
Thanks,
Avadhut Naik