Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp260302lqh; Thu, 28 Mar 2024 00:40:33 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCUbyCA+9NBE4Jcd3ZXLPG3b/X9UAezXzQJn4DwINhoCa4/1oyyN3ADKLU+Im94Pvwy/Il52VL8ZqGkG3wWS86ir+jiHcMPaq5YSaTQlgA== X-Google-Smtp-Source: AGHT+IGpQtXFIldqqy9muslbCLacMVCXKsdYD7IE7xnssefji9LH3GjFJnpuKwPfyuhTKlO7ZC8t X-Received: by 2002:a05:6358:648f:b0:181:65c9:a019 with SMTP id g15-20020a056358648f00b0018165c9a019mr1714632rwh.28.1711611632742; Thu, 28 Mar 2024 00:40:32 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711611632; cv=pass; d=google.com; s=arc-20160816; b=Dpwso4mm0C0BtP4acGtZSVeV3uz3Awlcs+7ys7FvuUhouq2UIJ364NH8kWkkmk9Iup 9ChuEFCvcb+X9S3qLM7AiOqwxV2L+R+kZTBeGCR44j5TYwGQvtFVvwUCkzVvjvTiOdh0 m110kA+rPLvg4A3EWCF5Z03pEAjUb9soDJoySdCUkwTEVZ5Y4i9D4y1rwrbFyRRu/U1Z wavpiBUjrhT4OEuADaaQ56AAjOhD+tMHF/AarHtY8ETFvhHD7dpltVHHDdZ62R0x575E gfhr7e/lmeit4s7vX3VVVylbwpI27IAdrQOdpfJlaCOu+r0s8yz4RV7DSRLXxsUdjDwG E6ww== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature :dkim-signature:dkim-filter; bh=/Rj61iC0oZxd7dGL2v5n+B0zL+Y+qY+UXJbpEedJLvQ=; fh=mOOX5XcBy0EnBSoemHi412KM6YbvNA1QIG84WQfcWxM=; b=fj4GNUTQrum4vhoGHvBt/ZIA/EaUAUmsBphRXO2TRFETOKGuCQfqdbfncz4Cj+pW6k AWBt/ix65JVnTplByZy4c2C44xINYAgW1rmpeAcfBQPOBmvcktsMC6Xg7DlSx8o+CF8E 1NuHQlk2XhZPqJo532LyFqobcA5nopnmFDLIqBUt8GIwbrh8+Rggwwhgw42XPD++DxCs DDNkvNry5P3CG14gho0hhjV0mx608BF17MdoJAOX3kMBSvhU0ux1gxhSlvq6aljZeRxo q3KQ2jQHulqp9b4+GhsPgn7TCSiEjdnOCY0hP77NYs3vO+T0mgQX3hMozslsHIflTG8l 2oTQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@syntacore.com header.s=mta-04 header.b=hDEvtKWY; dkim=pass header.i=@syntacore.com header.s=mta-03 header.b=mmVn94K0; arc=pass (i=1 dkim=pass dkdomain=syntacore.com dkim=pass dkdomain=syntacore.com dmarc=pass fromdomain=syntacore.com); spf=pass (google.com: domain of linux-kernel+bounces-122515-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-122515-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=syntacore.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id a11-20020a63cd4b000000b005e83c9ed17fsi881634pgj.797.2024.03.28.00.40.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 00:40:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-122515-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@syntacore.com header.s=mta-04 header.b=hDEvtKWY; dkim=pass header.i=@syntacore.com header.s=mta-03 header.b=mmVn94K0; arc=pass (i=1 dkim=pass dkdomain=syntacore.com dkim=pass dkdomain=syntacore.com dmarc=pass fromdomain=syntacore.com); spf=pass (google.com: domain of linux-kernel+bounces-122515-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-122515-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=syntacore.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4DBBA296B1A for ; Thu, 28 Mar 2024 07:40:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 28D9F51C28; Thu, 28 Mar 2024 07:40:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=syntacore.com header.i=@syntacore.com header.b="hDEvtKWY"; dkim=pass (2048-bit key) header.d=syntacore.com header.i=@syntacore.com header.b="mmVn94K0" Received: from mta-04.yadro.com (mta-04.yadro.com [89.207.88.248]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7180539FC6 for ; Thu, 28 Mar 2024 07:40:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=89.207.88.248 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711611619; cv=none; b=goIWvbbrq5/Qm17UtI/gBAM6IHqVyEGW8Y1n4UXNPlvHMPeESUswC70RL+zH82dqxddsNo6dgKj8TDxXMRyIo6ktfnwH5Dop2sOtDpyoacHbY7CcmVjRStY7enpOVVD6h61xrkrTEQZAXw8cpeGYRAJsFQPYAgpwwkEewkZ06Vg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711611619; c=relaxed/simple; bh=ZbOA7cQBnwcYuFarB35iNEmCOhuX3PT8ziPIpbB6uGo=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=mnrxKFa7LaeZWmW9ocduMLqLCD5E8IpRRoDJGGi/IBZOPh2Z53ohH1i7SILAHI1tYXK2GQv1KTkpVfD3KOWYVSDm2068xGqOs3L0sDkExVsmR94qUdljITjsXJlaOnGJ2nkOKDxutmu7hrBLZuw3/Ub7gmmch6grkYZr1Zs/SDg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=syntacore.com; spf=fail smtp.mailfrom=syntacore.com; dkim=pass (2048-bit key) header.d=syntacore.com header.i=@syntacore.com header.b=hDEvtKWY; dkim=pass (2048-bit key) header.d=syntacore.com header.i=@syntacore.com header.b=mmVn94K0; arc=none smtp.client-ip=89.207.88.248 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=syntacore.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=syntacore.com DKIM-Filter: OpenDKIM Filter v2.11.0 mta-04.yadro.com 6909EC0011 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syntacore.com; s=mta-04; t=1711611128; bh=/Rj61iC0oZxd7dGL2v5n+B0zL+Y+qY+UXJbpEedJLvQ=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type:From; b=hDEvtKWYhFo2AWZSmlNj5ja6wWfNlL51jNz7DCGFhB3Oiw/EurUXBEHYRWVN9+qHv bWJGsm83AaFCb3RfhTEWCnjmasm/ww1uzvBBdidW1Ydai2aFVn1R7kv+Pphu8eYhwi uf+5qKVpPfidLk066sQs0BZZzPdHiPNGEXO7OlF9KJLaUfEjmHiYc2UdKktwB3rA5N vDlXtUCmdkpLCe7tMC1RRP2hHFAEljeAnh+CUMG32smpNVev0KQDfsAYtjwOZjo3rE Spb4VpiFdesRzUBal8lDiTyVE2V/2epU4C53dvwcBL3t4unrAeFN4PAw/Ka0TQk5ls MSQiKqVpIL1sw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=syntacore.com; s=mta-03; t=1711611128; bh=/Rj61iC0oZxd7dGL2v5n+B0zL+Y+qY+UXJbpEedJLvQ=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type:From; b=mmVn94K0zC4przTgvepIALBY9SaSP2N+597VCWMcZV3Hx4tATYRfgRuhQVIYF+rH0 yr28VMLTqPDu+6XKr6RZMqdcDRIwTAnUFQl4kfGCP6dtgOTxN3K/A9E0/YzNItcNEK a8qx6P+qgRBHQbVGph/jnNCk4riPjmHv0CaWGHGGIdcyP4JUbd+IUwxb5ezqOycs0d Pr8DWmhVdYcsBlHtJDoFoYnIdXmLpeRjxljrAHgttR961f2GK7sC4LwrsJGqOB0iCo 9PbENpAvKyS9AvKRg1VbsrFwRT892defzSJR+IqwwfQugf2GWU9FHXyXyXcSEl2nl6 dTbXlez4LiGtw== Message-ID: <352f8101-01c3-45b9-9d53-ef0021cc6f46@syntacore.com> Date: Thu, 28 Mar 2024 10:32:06 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] riscv: Check that vdso does not contain any dynamic relocations To: Alexandre Ghiti , Roman Artemev , Guo Ren , Paul Walmsley , Palmer Dabbelt , Albert Ou , , References: <20240326113831.283025-1-alexghiti@rivosinc.com> Content-Language: en-US, ru-RU From: Vladimir Isaev In-Reply-To: <20240326113831.283025-1-alexghiti@rivosinc.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: T-EXCH-10.corp.yadro.com (172.17.11.60) To S-Exch-01.corp.yadro.com (10.78.5.241) Hi Alexandre, 26.03.2024 14:38, Alexandre Ghiti wrote: > > Like other architectures, use the common cmd_vdso_check to make sure of > that. > > Signed-off-by: Alexandre Ghiti > --- > arch/riscv/kernel/vdso/Makefile | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile > index 9b517fe1b8a8..dd4877f25928 100644 > --- a/arch/riscv/kernel/vdso/Makefile > +++ b/arch/riscv/kernel/vdso/Makefile > @@ -49,7 +49,7 @@ $(obj)/vdso.o: $(obj)/vdso.so > > # link rule for the .so file, .lds has to be first > $(obj)/vdso.so.dbg: $(obj)/vdso.lds $(obj-vdso) FORCE > - $(call if_changed,vdsold) > + $(call if_changed,vdsold_and_check) > LDFLAGS_vdso.so.dbg = -shared -S -soname=linux-vdso.so.1 \ > --build-id=sha1 --hash-style=both --eh-frame-hdr > > @@ -69,7 +69,8 @@ include/generated/vdso-offsets.h: $(obj)/vdso.so.dbg FORCE > # actual build commands > # The DSO images are built using a special linker script > # Make sure only to export the intended __vdso_xxx symbol offsets. > -quiet_cmd_vdsold = VDSOLD $@ > - cmd_vdsold = $(LD) $(ld_flags) -T $(filter-out FORCE,$^) -o $@.tmp && \ > +quiet_cmd_vdsold_and_check = VDSOLD $@ > + cmd_vdsold_and_check = $(LD) $(ld_flags) -T $(filter-out FORCE,$^) -o $@.tmp && \ > $(OBJCOPY) $(patsubst %, -G __vdso_%, $(vdso-syms)) $@.tmp $@ && \ > - rm $@.tmp > + rm $@.tmp && \ > + $(cmd_vdso_check) For some reason I thought that this check is in the common vdso code and just missed hwprobe relocation... Tested-by: Vladimir Isaev > -- > 2.39.2 > Thank you, Vladimir Isaev