Received-SPF: pass (google.com: domain of linux-kernel+bounces-122527-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: "Tian, Kevin" <kevin.tian@intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>, Joerg Roedel <joro@8bytes.org>, "Will
 Deacon" <will@kernel.org>, Robin Murphy <robin.murphy@arm.com>, "Jason
 Gunthorpe" <jgg@ziepe.ca>
CC: "Zhang, Tina" <tina.zhang@intel.com>, "Liu, Yi L" <yi.l.liu@intel.com>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 04/12] iommu/vt-d: Use cache_tag_flush_all() in
 flush_iotlb_all
Thread-Topic: [PATCH 04/12] iommu/vt-d: Use cache_tag_flush_all() in
 flush_iotlb_all
Thread-Index: AQHaflqzlxysz7sOi0aRZ4Pci9LCLbFMypQg
Date: Thu, 28 Mar 2024 07:47:08 +0000
Message-ID: <BN9PR11MB5276A9E7198B3C9E0A61A1A78C3B2@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20240325021705.249769-1-baolu.lu@linux.intel.com>
 <20240325021705.249769-5-baolu.lu@linux.intel.com>
In-Reply-To: <20240325021705.249769-5-baolu.lu@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D0kss5/oAawLJVhS/tu3NwTxbRvQ3UiasYeZ+ydoW9YYDpV10boRweiNVVSX?=
 =?us-ascii?Q?OnYFyQ1NX5xB/aiRXGkXmBvGWNyjpdACLLxv2xXhxvoxBrhVzKclkTul/GpD?=
 =?us-ascii?Q?ssayiuuGgJc4TQDHgDpMG1ybB/BwY/CadLJyA3cCYskEWuz60eJ16/QSfJBY?=
 =?us-ascii?Q?IVbpQ5qevMEBPHEPlwD4opT+Gl0COHze/bpxPbN6sLiuJib+VmJ5vDLA6ki/?=
 =?us-ascii?Q?JY9ZvB9wtH/IGOdKmCPzdnVr3VXrqMh2txbxvE0Dkk2+ntnCwMzP90puCryT?=
 =?us-ascii?Q?xfFjleHOkbfwzD9F2OPDCS/7Rwx++I0qOURj2LgTOCJWQpuEsXm+y8xvtTFx?=
 =?us-ascii?Q?SJ8Jps3qkiS/B/aIFrjznCNPOXCO7azoVTnKflPxUMDmivOsapCs6lzk+BRL?=
 =?us-ascii?Q?r6wP06ucFr2/L6fsL3rRAD8p1NS2EZhsUOsXcczUG1C/9sCbjGEaZqK4saum?=
 =?us-ascii?Q?Y+TXlxnoE5HHg7rrOSZESyCgTQf7iOkIae/NJPAd1c9LqPm96AOwGfueYyEb?=
 =?us-ascii?Q?p6Hm2zaXy7tTZe8vElBndkvFKaTsAGbfSFo+0UWYJQKqXgARaz580pNGPd84?=
 =?us-ascii?Q?lfWLOXxdb4aFB2OsKECZ3EcpPGhe7tjSEAn3eBPEomTsp8h74ESLDB4wBPNk?=
 =?us-ascii?Q?c0jrH8PUmlHf9673sODqaojbeDKF3m6Jpt2v0dE7TjKus3ImiZYLlfb1+d3z?=
 =?us-ascii?Q?xJBCzzhhWHR2lVx79GAly81drAes0caM+C02+NO2g2aSVgsTFWtvskkUcRvz?=
 =?us-ascii?Q?ABU5sJdp7rEprXZaOf9LHIK8540oYLVTsrXyvoFkfUVt5D7uyRnOMkfAiAys?=
 =?us-ascii?Q?1J9UR8qMBcUvdzb4rJewWAjV3MyvVpIKCRA93HeZYqy97w7Rv2XHqvuF3mTA?=
 =?us-ascii?Q?WDRYPjIACqpPPZ3FJi9zlLim0nogc99Xz/z5ubn99MfO/KdQP8fJC2w6Bgtc?=
 =?us-ascii?Q?dIzHzx3Z5GzKIZUPYzqXeiu7e3gFYHq2TLDjsqGadAu+jN+96ioODbFxo7QY?=
 =?us-ascii?Q?nYVphqn3NXkoNSjOeJlXNlvpXQPJQ+aD8BqliRhv+5DpobES0mfjCQylz0oc?=
 =?us-ascii?Q?OsaDQX3UktR9+UhakMqSqAZohCb9TAQHnygxjIiZG/C20BvE7lieheHdkRSF?=
 =?us-ascii?Q?1rO8mRTsOgAvFMha9nQq69DHq52TaUtjRey/6zzFob57TH+5cpy0ZbtqrYTZ?=
 =?us-ascii?Q?JdReKagooKSwQpLd470PRtTNZj0WzCOrLcxg3hSgzf0gWSpLIFoN6qNCAX5v?=
 =?us-ascii?Q?x2LKi4S+en27JBnha247ANuvqa8CkD6xtbVHp7ni27WEC0GQmDBf4jZr8dbD?=
 =?us-ascii?Q?PZYeDc1NEBQE3Q/GU2GrQCSAkfPoDxjdTxz3GWlXgfi0rhCPxRenQzstuIcZ?=
 =?us-ascii?Q?ceysU5ODuEyZugkdg/cPQKhEvEfKq8Xy1hFLg3nTuaSW5uSH4HBhffn8wJ9A?=
 =?us-ascii?Q?WOvSwZ5kCz4Za+X0TET/s0w6JSstSfPpDIgok/1Jba7h+VMafa2iKkZOD6G/?=
 =?us-ascii?Q?MtFOTJBWmIZpW55v4hzKUo7AIoL7xUAJq2ws0jlfiPVCPc20gPiWs090pw/L?=
 =?us-ascii?Q?hCiYLNCAHe/BU8DgIKwAZ4JFJcifccr8Vdy51iuu?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0abe1e53-c1b2-40c8-e02c-08dc4efb44f6
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2024 07:47:08.0465
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: iijArYZQLeWb2xk6LeswuD64nvIWmzgdlPrLXlNzHYQYYecgnwNqDpn6Z8CGVIuOQVsStv1K/h7XNg8wjEtUlQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5054
X-OriginatorOrg: intel.com

> From: Lu Baolu <baolu.lu@linux.intel.com>
> Sent: Monday, March 25, 2024 10:17 AM
>=20
> The flush_iotlb_all callback is called by the iommu core to flush
> all caches for the affected domain. Use cache_tag_flush_all() in
> this callback.
>=20
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> ---
>  drivers/iommu/intel/iommu.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
>=20
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index 93e4422c9b10..4ce98f23917c 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -1560,26 +1560,7 @@ static void parent_domain_flush(struct
> dmar_domain *domain,
>=20
>  static void intel_flush_iotlb_all(struct iommu_domain *domain)
>  {
> -	struct dmar_domain *dmar_domain =3D to_dmar_domain(domain);
> -	struct iommu_domain_info *info;
> -	unsigned long idx;
> -
> -	xa_for_each(&dmar_domain->iommu_array, idx, info) {
> -		struct intel_iommu *iommu =3D info->iommu;
> -		u16 did =3D domain_id_iommu(dmar_domain, iommu);
> -
> -		if (dmar_domain->use_first_level)
> -			domain_flush_pasid_iotlb(iommu, dmar_domain, 0,
> -1, 0);
> -		else
> -			iommu->flush.flush_iotlb(iommu, did, 0, 0,
> -						 DMA_TLB_DSI_FLUSH);
> -
> -		if (!cap_caching_mode(iommu->cap))
> -			iommu_flush_dev_iotlb(dmar_domain, 0,
> MAX_AGAW_PFN_WIDTH);
> -	}
> -
> -	if (dmar_domain->nested_parent)
> -		parent_domain_flush(dmar_domain, 0, -1, 0);
> +	cache_tag_flush_all(to_dmar_domain(domain));
>  }
>=20

this replacement causes a functional change. Now devtlb is always
invalidated while old code doesn't do so for caching mode.

Probably you may want to first clean up all inconsistent devtlb
invalidation policies for caching mode before going to this series...