Received-SPF: pass (google.com: domain of linux-kernel+bounces-122752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Hariprasad Kelam <hkelam@marvell.com>
To: Aleksandr Mishin <amishin@t-argos.ru>,
        Sunil Kovvuri Goutham
	<sgoutham@marvell.com>
CC: Linu Cherian <lcherian@marvell.com>,
        Geethasowjanya Akula
	<gakula@marvell.com>,
        Jerin Jacob <jerinj@marvell.com>,
        Subbaraya Sundeep
 Bhatta <sbhatta@marvell.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric
 Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni
	<pabeni@redhat.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: [PATCH] octeontx2-af: Add array index check
Thread-Topic: [PATCH] octeontx2-af: Add array index check
Thread-Index: AQHagPgKsIiFHV07QkGSwCVqUVX2/A==
Date: Thu, 28 Mar 2024 10:09:37 +0000
Message-ID: 
 <PH0PR18MB4474F0C8213F4DC4E399AE47DE3B2@PH0PR18MB4474.namprd18.prod.outlook.com>
References: <20240328081648.13193-1-amishin@t-argos.ru>
In-Reply-To: <20240328081648.13193-1-amishin@t-argos.ru>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?YRJMDu85EpGM35GL7020lr6i15QxASgRYcFqfJBBm6zfXbSdqywwYcOJVAEP?=
 =?us-ascii?Q?SW4MvgKuuhuaGVLLrUOHdla7F8VNbpHzh/HTVO0mVbsSoyeJgGdjFQaK3sLy?=
 =?us-ascii?Q?io+JDv4nWSgsZNaROChGCKse7BOsq/FSvcbpQag0UecjUdjfglYsZJcRxO/L?=
 =?us-ascii?Q?FrrTDtCPgLfsJ0792HqHND7jD8hyYkClEPrIv5i4lUyXRxJ5YUhHcz9KMqwW?=
 =?us-ascii?Q?rnjau65cB2SUAMOx/BHjfO0yafXFWPtd2C5NRPW1QhoX0H3t9WVYLQgBQ1ES?=
 =?us-ascii?Q?mmNlrYVd8RDn1J8wM3riEH2H6bv3FYzpLcDVq/jTm4eoh5hXqH0+GoyTw0Cy?=
 =?us-ascii?Q?0FlsrfqgaCpIPkfZ06xqaXgxalOmCRgtRgb8BB0CqtixfOdmcCz7dIXf88BV?=
 =?us-ascii?Q?sq911FMAWUijBOVfLNesjL5M/GBYdZr60ahF8HW3a2FzpLEbht1NoOh5gB5s?=
 =?us-ascii?Q?6VwRWa+iolfZ2RfnT6jx6cKP5IH7ghkXcDf5vv1Gu/2q1OavNQEI+e8jCEB8?=
 =?us-ascii?Q?gJMTH0PhF+U3EEjvKfmtuX8i5edNXjpBBL8F0803qlRklOJ0phpf6X8tivmq?=
 =?us-ascii?Q?7pfIkhBqe10TUMeQOsTatu68DwHO1qIu2g/J/+HV+Z47eqNvpE/SWFBI97aE?=
 =?us-ascii?Q?GqsxMr/ijLP+VMJQY4Kd6qhshKGgErP/UUKS0jTbFy6OVGP24XBye8pQkZQj?=
 =?us-ascii?Q?tDOHkAC94y9XunJ78p+w1HM3Lktnytvj2CcwsQvMbASqos1XSXhLgF1AOVK4?=
 =?us-ascii?Q?3XmdAY1ntDW091yWm2/BdsNt8fik8YbMBuMksXuvEXopmFGUzXArl0q+JcE5?=
 =?us-ascii?Q?MlFxtp4s/Fdwc813mRFj+gL4dLmp/s6tJsQp0/Opr2ZbN+6vVi6lEjh2VIY1?=
 =?us-ascii?Q?lksejW2r00NEHmR0ijeYNt+l3ekLzF0B7/mQLiFBnHXv+SSpbzsMWqWOJTuW?=
 =?us-ascii?Q?/VNV/UIRMEYQNt+Veg2IUypqMHkS99JO/95Dhwia7ODXeN6xi2B2npHB7EnQ?=
 =?us-ascii?Q?1+PtoKSb0y0RUq2X0NNFZXjo3/QCFJALpJu+6Hvr6Aj24Rh8xElb8DngaahB?=
 =?us-ascii?Q?G8Zs954/NxsgzI0OIUcQivhNKsZuWtBH4VeCIVZSXbNE3aor2Ity/yru9oR2?=
 =?us-ascii?Q?gFPU7tRqkKSNLYMxbNtpKjBR+CJgI0nuxAOMq316uOv5oscPQmm1oNS8Ve3k?=
 =?us-ascii?Q?33hU6Ro8VPsHrsJ7ysYv0ktfN6JPm28mWa+BS1NPd/q7i41INrTg9k37K7iX?=
 =?us-ascii?Q?38hKbx816E7PYzu3Ta9yQq9mgl5c3cOBkV3TSD7RCrUI3cDtOqD119PtZb0q?=
 =?us-ascii?Q?GEcPqblF5W6K1xyJPfp6Hf0CcxvXxIT+SZf3hWhadsMN+Oqb8vuU9fXZsNvC?=
 =?us-ascii?Q?BijbaZn/e+QyxQ/oFTeWROfCwBKL+APfxTBNTXGlLGdG9BCMu1Yweb3lMKzE?=
 =?us-ascii?Q?dwVn3guvRQ+Bi3VtP6RcOkKVrELqKBaS5+06jVF9TRsAZkhM+f9qPWNGKxkG?=
 =?us-ascii?Q?Y2LdO2wGZgFJe7dmjnja1gnDURNhLu+WCbNAKijZDdGFEJl7UQRO6Cr7lMEe?=
 =?us-ascii?Q?P8efjxEA23QvTlBjGHROHQU5ZGyL0zQjIKmub4V8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: marvell.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR18MB4474.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 67efe4c6-f510-4553-96a3-08dc4f0f2cd2
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2024 10:09:37.4237
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: yRoHNjFp3gGIw0aDk4FOiPNztoSqtNOgQRnWnsdWWCOXzAa78TQ98D7hIIRhuiqulzGM1ZyXrI76EJXhpp7m2w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR18MB3945
X-Proofpoint-GUID: YEjKUNIFnjrGSaRDdy_LkimgwtIg-FXC
X-Proofpoint-ORIG-GUID: YEjKUNIFnjrGSaRDdy_LkimgwtIg-FXC
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-28_10,2024-03-27_01,2023-05-22_02


Hi,

> In rvu_map_cgx_lmac_pf() the 'iter', which is used as an array index, can
> reach value (up to 14) that exceed the size (MAX_LMAC_COUNT =3D 8) of the
> array.
> Fix this bug by adding 'iter' value check.
>=20
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>=20

Since it is a fix, please add "net" to the subject.

Thanks,
Hariprasad k
> Fixes: 91c6945ea1f9 ("octeontx2-af: cn10k: Add RPM MAC support")
> Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
> ---
>  drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> index 72e060cf6b61..e9bf9231b018 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
> @@ -160,6 +160,8 @@ static int rvu_map_cgx_lmac_pf(struct rvu *rvu)
>  			continue;
>  		lmac_bmap =3D cgx_get_lmac_bmap(rvu_cgx_pdata(cgx, rvu));
>  		for_each_set_bit(iter, &lmac_bmap, rvu->hw->lmac_per_cgx)
> {
> +			if (iter >=3D MAX_LMAC_COUNT)
> +				continue;
>  			lmac =3D cgx_get_lmacid(rvu_cgx_pdata(cgx, rvu),
>  					      iter);
>  			rvu->pf2cgxlmac_map[pf] =3D cgxlmac_id_to_bmap(cgx,
> lmac);
> --
> 2.30.2