Received-SPF: pass (google.com: domain of linux-kernel+bounces-122781-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 28 Mar 2024 11:34:04 +0100
From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Jinjie Ruan <ruanjinjie@huawei.com>,
	Russell King <linux@armlinux.org.uk>, Kalle Valo <kvalo@kernel.org>
Subject: Re: [PATCH 4.19 035/148] wifi: mwifiex: debugfs: Drop unnecessary
 error check for debugfs_create_dir()
Message-ID: <ZgVHnFAGan7e+mYK@duo.ucw.cz>
References: <20240324235012.1356413-1-sashal@kernel.org>
 <20240324235012.1356413-36-sashal@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="tkcsipe4i8KMbCTU"
Content-Disposition: inline
In-Reply-To: <20240324235012.1356413-36-sashal@kernel.org>


--tkcsipe4i8KMbCTU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Jinjie Ruan <ruanjinjie@huawei.com>
>=20
> [ Upstream commit 50180c7f8e3de7c2d87f619131776598fcb1478d ]
>=20
> debugfs_create_dir() returns ERR_PTR and never return NULL.
>=20
> As Russell suggested, this patch removes the error checking for
> debugfs_create_dir(). This is because the DebugFS kernel API is developed
> in a way that the caller can safely ignore the errors that occur during
> the creation of DebugFS nodes. The debugfs APIs have a IS_ERR() judge in
> start_creating() which can handle it gracefully. So these checks are
> unnecessary.

Additional error handling does not break anything.

This does not fix a bug, and thus does not belong into stable.

Best regards,
								Pavel
							=09
> +++ b/drivers/net/wireless/marvell/mwifiex/debugfs.c
> @@ -977,9 +977,6 @@ mwifiex_dev_debugfs_init(struct mwifiex_private *priv)
>  	priv->dfs_dev_dir =3D debugfs_create_dir(priv->netdev->name,
>  					       mwifiex_dfs_dir);
> =20
> -	if (!priv->dfs_dev_dir)
> -		return;
> -
>  	MWIFIEX_DFS_ADD_FILE(info);
>  	MWIFIEX_DFS_ADD_FILE(debug);
>  	MWIFIEX_DFS_ADD_FILE(getlog);

--=20
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

--tkcsipe4i8KMbCTU
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZgVHnAAKCRAw5/Bqldv6
8nWfAJ9PHvxLJw8k4iAUnXui+VmjI/BQ4gCeJBZ/PeipfPLhm5EZaYu7SOY+W4c=
=Cb2c
-----END PGP SIGNATURE-----

--tkcsipe4i8KMbCTU--