Received-SPF: pass (google.com: domain of linux-kernel+bounces-122788-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 28 Mar 2024 11:40:26 +0100
From: Pavel Machek <pavel@denx.de>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
	Mikhail Khvainitski <me@khvoinitsky.org>,
	Jiri Kosina <jkosina@suse.com>
Subject: Re: [PATCH 5.10 127/238] HID: lenovo: Add middleclick_workaround
 sysfs knob for cptkbd
Message-ID: <ZgVJGs2OI/4QsJCQ@duo.ucw.cz>
References: <20240324234027.1354210-1-sashal@kernel.org>
 <20240324234027.1354210-128-sashal@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="+xPubCJWfEMGwzQ2"
Content-Disposition: inline
In-Reply-To: <20240324234027.1354210-128-sashal@kernel.org>


--+xPubCJWfEMGwzQ2
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> From: Mikhail Khvainitski <me@khvoinitsky.org>
>=20
> [ Upstream commit 2814646f76f8518326964f12ff20aaee70ba154d ]
>=20
> Previous attempt to autodetect well-behaving patched firmware
> introduced in commit 46a0a2c96f0f ("HID: lenovo: Detect quirk-free fw
> on cptkbd and stop applying workaround") has shown that there are
> false-positives on original firmware (on both 1st gen and 2nd gen
> keyboards) which causes the middle button click workaround to be
> mistakenly disabled.
>=20
> This commit adds explicit parameter to sysfs to control this
> workaround.

Should this go to stable? We have stream of lenovo workarounds, maybe
-stable should wait for upstream to solve this.

Plus it should really have documentation.

Oh and we normally solve this stuff with module parameters, so that it
can be fixed during bootup.

Best regards,
							Pavel

> Fixes: 46a0a2c96f0f ("HID: lenovo: Detect quirk-free fw on cptkbd and sto=
p applying workaround")
> Fixes: 43527a0094c1 ("HID: lenovo: Restrict detection of patched firmware=
 only to USB cptkbd")
> Signed-off-by: Mikhail Khvainitski <me@khvoinitsky.org>
> Signed-off-by: Jiri Kosina <jkosina@suse.com>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

--=20
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

--+xPubCJWfEMGwzQ2
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZgVJGgAKCRAw5/Bqldv6
8jCuAJ91l5476iPTU59SHkJjNcGTxb6i8gCgoecaRojX1warU2+YBOQIBk9uESY=
=vVWE
-----END PGP SIGNATURE-----

--+xPubCJWfEMGwzQ2--