Received-SPF: pass (google.com: domain of linux-kernel+bounces-122841-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 28 Mar 2024 13:38:45 +0200
From: Tony Lindgren <tony@atomide.com>
To: Dhruva Gole <d-gole@ti.com>
Cc: linux-omap@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org, nm@ti.com, vigneshr@ti.com
Subject: Re: [PATCH 2/5] bus: ti-sysc: Add a description and copyrights
Message-ID: <20240328113845.GI5132@atomide.com>
References: <20240327081508.36747-1-tony@atomide.com>
 <20240327081508.36747-3-tony@atomide.com>
 <20240328111907.cknfqe3qpiyeipsp@dhruva>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240328111907.cknfqe3qpiyeipsp@dhruva>

* Dhruva Gole <d-gole@ti.com> [240328 11:19]:
> On Mar 27, 2024 at 10:15:05 +0200, Tony Lindgren wrote:
> > The ti-sysc driver is missing coprights and description, let's add
> > those.
> > 
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> >  drivers/bus/ti-sysc.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
> > --- a/drivers/bus/ti-sysc.c
> > +++ b/drivers/bus/ti-sysc.c
> > @@ -1,6 +1,17 @@
> >  // SPDX-License-Identifier: GPL-2.0
> >  /*
> >   * ti-sysc.c - Texas Instruments sysc interconnect target driver
> > + *
> > + * TI SoCs have an interconnect target wrapper IP for many devices. The wrapper
> > + * IP manages clock gating, resets, and PM capabilities for the connected devices.
> > + *
> > + * Copyright (C) 2017-2024 Texas Instruments Incorporated - https://www.ti.com/
> > + *
> > + * Many features are based on the earlier omap_hwmod arch code with thanks to all
> > + * the people who developed and debugged the code over the years:
> > + *
> > + * Copyright (C) 2009-2011 Nokia Corporation
> > + * Copyright (C) 2011-2012 Texas Instruments, Inc.
> 
> +Nishant
> 
> I am no expert on the copyrights part of it, but who gets copyright from
> 2012 - 2017?

Well this particular driver did not exist until 2017 :) But for the
earlier hwmod arch code reference above, we could make it 2011-2024.

> Also, for TI should we stick to this format as you did above?
> Copyright (C) 2011-2024 Texas Instruments Incorporated
> perhaps?

Sure that works for me.

> But otherwise,
> Reviewed-by: Dhruva Gole <d-gole@ti.com>

Thanks,

Tony