Received-SPF: pass (google.com: domain of linux-kernel+bounces-122885-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3f465638-f96f-4d81-87b2-779897c03b21@redhat.com>
Date: Thu, 28 Mar 2024 13:25:04 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] mm: support multi-size THP numa balancing
Content-Language: en-US
From: David Hildenbrand <david@redhat.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>, akpm@linux-foundation.org
Cc: mgorman@techsingularity.net, wangkefeng.wang@huawei.com,
 jhubbard@nvidia.com, ying.huang@intel.com, 21cnbao@gmail.com,
 ryan.roberts@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <cover.1711453317.git.baolin.wang@linux.alibaba.com>
 <dee4268f1797f31c6bb6bdab30f8ad3df9053d3d.1711453317.git.baolin.wang@linux.alibaba.com>
 <adf36acf-19b9-49fc-b9f3-138fd66de2da@redhat.com>
 <0baa443a-7872-4ded-94c6-06af88a6a943@linux.alibaba.com>
 <760800b1-c708-4c1d-b153-c252ab21938a@redhat.com>
Autocrypt: addr=david@redhat.com; keydata=
 xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ
 dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL
 QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp
 XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK
 Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9
 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt
 WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc
 UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv
 jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb
 B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk
 ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW
 AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q
 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp
 rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf
 wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4
 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l
 pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd
 KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE
 BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs
 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF
 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9
 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz
 Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb
 T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A
 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk
 CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G
 NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75
 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx
 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS
 lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv
 AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa
 N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3
 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB
 boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq
 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f
 XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ
 a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq
 Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6
 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8
 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E
 th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr
 jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt
 WNyWQQ==
Organization: Red Hat
In-Reply-To: <760800b1-c708-4c1d-b153-c252ab21938a@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 28.03.24 13:07, David Hildenbrand wrote:
> On 28.03.24 12:34, Baolin Wang wrote:
>>
>>
>> On 2024/3/28 17:25, David Hildenbrand wrote:
>>> On 26.03.24 12:51, Baolin Wang wrote:
>>>> Now the anonymous page allocation already supports multi-size THP (mTHP),
>>>> but the numa balancing still prohibits mTHP migration even though it
>>>> is an
>>>> exclusive mapping, which is unreasonable.
>>>>
>>>> Allow scanning mTHP:
>>>> Commit 859d4adc3415 ("mm: numa: do not trap faults on shared data section
>>>> pages") skips shared CoW pages' NUMA page migration to avoid shared data
>>>> segment migration. In addition, commit 80d47f5de5e3 ("mm: don't try to
>>>> NUMA-migrate COW pages that have other uses") change to use page_count()
>>>> to avoid GUP pages migration, that will also skip the mTHP numa scaning.
>>>> Theoretically, we can use folio_maybe_dma_pinned() to detect the GUP
>>>> issue, although there is still a GUP race, the issue seems to have been
>>>> resolved by commit 80d47f5de5e3. Meanwhile, use the
>>>> folio_likely_mapped_shared()
>>>> to skip shared CoW pages though this is not a precise sharers count. To
>>>> check if the folio is shared, ideally we want to make sure every page is
>>>> mapped to the same process, but doing that seems expensive and using
>>>> the estimated mapcount seems can work when running autonuma benchmark.
>>>>
>>>> Allow migrating mTHP:
>>>> As mentioned in the previous thread[1], large folios (including THP) are
>>>> more susceptible to false sharing issues among threads than 4K base page,
>>>> leading to pages ping-pong back and forth during numa balancing, which is
>>>> currently not easy to resolve. Therefore, as a start to support mTHP numa
>>>> balancing, we can follow the PMD mapped THP's strategy, that means we can
>>>> reuse the 2-stage filter in should_numa_migrate_memory() to check if the
>>>> mTHP is being heavily contended among threads (through checking the
>>>> CPU id
>>>> and pid of the last access) to avoid false sharing at some degree. Thus,
>>>> we can restore all PTE maps upon the first hint page fault of a large
>>>> folio
>>>> to follow the PMD mapped THP's strategy. In the future, we can
>>>> continue to
>>>> optimize the NUMA balancing algorithm to avoid the false sharing issue
>>>> with
>>>> large folios as much as possible.
>>>>
>>>> Performance data:
>>>> Machine environment: 2 nodes, 128 cores Intel(R) Xeon(R) Platinum
>>>> Base: 2024-03-25 mm-unstable branch
>>>> Enable mTHP to run autonuma-benchmark
>>>>
>>>> mTHP:16K
>>>> Base                Patched
>>>> numa01                numa01
>>>> 224.70                137.23
>>>> numa01_THREAD_ALLOC        numa01_THREAD_ALLOC
>>>> 118.05                50.57
>>>> numa02                numa02
>>>> 13.45                9.30
>>>> numa02_SMT            numa02_SMT
>>>> 14.80                7.43
>>>>
>>>> mTHP:64K
>>>> Base                Patched
>>>> numa01                numa01
>>>> 216.15                135.20
>>>> numa01_THREAD_ALLOC        numa01_THREAD_ALLOC
>>>> 115.35                46.93
>>>> numa02                numa02
>>>> 13.24                9.24
>>>> numa02_SMT            numa02_SMT
>>>> 14.67                7.31
>>>>
>>>> mTHP:128K
>>>> Base                Patched
>>>> numa01                numa01
>>>> 205.13                140.41
>>>> numa01_THREAD_ALLOC        numa01_THREAD_ALLOC
>>>> 112.93                44.78
>>>> numa02                numa02
>>>> 13.16                9.19
>>>> numa02_SMT            numa02_SMT
>>>> 14.81                7.39
>>>>
>>>> [1]
>>>> https://lore.kernel.org/all/20231117100745.fnpijbk4xgmals3k@techsingularity.net/
>>>> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
>>>> ---
>>>>     mm/memory.c   | 56 +++++++++++++++++++++++++++++++++++++++++++--------
>>>>     mm/mprotect.c |  3 ++-
>>>>     2 files changed, 50 insertions(+), 9 deletions(-)
>>>>
>>>> diff --git a/mm/memory.c b/mm/memory.c
>>>> index c30fb4b95e15..36191a9c799c 100644
>>>> --- a/mm/memory.c
>>>> +++ b/mm/memory.c
>>>> @@ -5068,16 +5068,55 @@ static void numa_rebuild_single_mapping(struct
>>>> vm_fault *vmf, struct vm_area_str
>>>>         update_mmu_cache_range(vmf, vma, vmf->address, vmf->pte, 1);
>>>>     }
>>>> +static void numa_rebuild_large_mapping(struct vm_fault *vmf, struct
>>>> vm_area_struct *vma,
>>>> +                       struct folio *folio, pte_t fault_pte, bool
>>>> ignore_writable)
>>>> +{
>>>> +    int nr = pte_pfn(fault_pte) - folio_pfn(folio);
>>>> +    unsigned long start = max(vmf->address - nr * PAGE_SIZE,
>>>> vma->vm_start);
>>>> +    unsigned long end = min(start + folio_nr_pages(folio) *
>>>> PAGE_SIZE, vma->vm_end);
>>>> +    pte_t *start_ptep = vmf->pte - (vmf->address - start) / PAGE_SIZE;
>>>> +    bool pte_write_upgrade = vma_wants_manual_pte_write_upgrade(vma);
>>>> +    unsigned long addr;
>>>> +
>>>> +    /* Restore all PTEs' mapping of the large folio */
>>>> +    for (addr = start; addr != end; start_ptep++, addr += PAGE_SIZE) {
>>>> +        pte_t pte, old_pte;
>>>> +        pte_t ptent = ptep_get(start_ptep);
>>>> +        bool writable = false;
>>>> +
>>>> +        if (!pte_present(ptent) || !pte_protnone(ptent))
>>>> +            continue;
>>>> +
>>>> +        if (vm_normal_folio(vma, addr, ptent) != folio)
>>>> +            continue;
>>>> +
>>>
>>> Should you be using folio_pte_batch() in the caller to collect all
>>> applicable PTEs and then only have function that batch-changes a given
>>> nr of PTEs?
>>>
>>> (just like we are now batching other stuff)
>>
>> Seems folio_pte_batch() is not suitable for numa balancing, since we did
>> not care about other PTE bits, only care about the protnone bits. And
> 
> You should be able to ignore most bits we care about, which case are you
> concerned about folio_pte_batch() would miss. Hand crafting own
> functions to cover some corner cases nobody cares about is likely a bad
> idea.

Note that the reason why I am asking is that folio_pte_batch() can 
optimize-out repeated ptep_get() with cont-ptes.

-- 
Cheers,

David / dhildenb