Received-SPF: pass (google.com: domain of linux-kernel+bounces-122931-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 28 Mar 2024 13:56:55 +0100
From: Lukasz Majewski <lukma@denx.de>
To: Simon Horman <horms@kernel.org>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>, Eric Dumazet
 <edumazet@google.com>, Vladimir Oltean <olteanv@gmail.com>, "David S.
 Miller" <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Oleksij
 Rempel <o.rempel@pengutronix.de>, Tristram.Ha@microchip.com, Sebastian
 Andrzej Siewior <bigeasy@linutronix.de>, Paolo Abeni <pabeni@redhat.com>,
 Ravi Gunasekaran <r-gunasekaran@ti.com>, Nikita Zhandarovich
 <n.zhandarovich@fintech.ru>, Murali Karicheri <m-karicheri2@ti.com>, Jiri
 Pirko <jiri@resnulli.us>, Dan Carpenter <dan.carpenter@linaro.org>, Ziyang
 Xuan <william.xuanziyang@huawei.com>, Shigeru Yoshida
 <syoshida@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 RESEND] net: hsr: Provide RedBox support
Message-ID: <20240328135655.48c8e7d1@wsk>
In-Reply-To: <20240328122549.GJ403975@kernel.org>
References: <20240326090220.3259927-1-lukma@denx.de>
	<20240328122549.GJ403975@kernel.org>
Organization: denx.de
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/i1lim4VRYcicmxtzQ+h1Fh/";
 protocol="application/pgp-signature"; micalg=pgp-sha512

--Sig_/i1lim4VRYcicmxtzQ+h1Fh/
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Simon,

> On Tue, Mar 26, 2024 at 10:02:20AM +0100, Lukasz Majewski wrote:
> > Introduce RedBox support (HSR-SAN to be more precise) for HSR
> > networks. Following traffic reduction optimizations have been
> > implemented:
> > - Do not send HSR supervisory frames to Port C (interlink)
> > - Do not forward to HSR ring frames addressed to Port C
> > - Do not forward to Port C frames from HSR ring
> > - Do not send duplicate HSR frame to HSR ring when destination is
> > Port C
> >=20
> > The corresponding patch to modify iptable2 sources has already been
> > sent:
> > https://lore.kernel.org/netdev/20240308145729.490863-1-lukma@denx.de/T/
> >=20
> > Testing procedure:
> > ------------------
> > The EVB-KSZ9477 has been used for testing on net-next branch
> > (SHA1: 709776ea8562).
> >=20
> > Ports 4/5 were used for SW managed HSR (hsr1) as first hsr0 for
> > ports 1/2 (with HW offloading for ksz9477) was created. Port 3 has
> > been used as interlink port (single USB-ETH dongle).
> >=20
> > Configuration - RedBox (EVB-KSZ9477):
> > ifconfig lan1 down;ifconfig lan2 down
> > ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision
> > 45 version 1 ip link add name hsr1 type hsr slave1 lan4 slave2 lan5
> > interlink lan3 supervision 45 version 1 ifconfig lan4 up;ifconfig
> > lan5 up ifconfig lan3 up
> > ifconfig hsr1 192.168.0.11 up
> >=20
> > Configuration - DAN-H (EVB-KSZ9477):
> >=20
> > ifconfig lan1 down;ifconfig lan2 down
> > ip link add name hsr0 type hsr slave1 lan1 slave2 lan2 supervision
> > 45 version 1 ip link add name hsr1 type hsr slave1 lan4 slave2 lan5
> > supervision 45 version 1 ifconfig lan4 up;ifconfig lan5 up
> > ifconfig hsr1 192.168.0.12 up
> >=20
> > This approach uses only SW based HSR devices (hsr1).
> >=20
> > --------------          -----------------       ------------
> > DAN-H  Port5 | <------> | Port5         |       |
> >        Port4 | <------> | Port4   Port3 | <---> | PC
> >              |          | (RedBox)      |       | (USB-ETH)
> > EVB-KSZ9477  |          | EVB-KSZ9477   |       |
> > --------------          -----------------       ------------
> >=20
> > Signed-off-by: Lukasz Majewski <lukma@denx.de> =20
>=20
> Hi Lukasz,
>=20
> this patch (2) seems to have a build dependency on:
> (1) [v2,RESEND] net: hsr: Use full string description when opening
> HSR network device
> https://lore.kernel.org/all/20240326085649.3259424-1-lukma@denx.de/
>=20
> Which is pending review.
>=20
> With this in mind, I suggest waiting for the review of 1 to be
> completed and then either:
>=20
> * If 1 is accepted, then follow-up by sending v4 of this patch (2)

It has been reviewed by Andrew 2 days ago, so hopefully it will be
merged soon, and then I can prepare v4 of the HSR Redbox support.

> ; or
> * If changes are requested to 1, include 1 and 2 together in
>    a patchset after addressing relevant feedback
>=20
> ...


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

--Sig_/i1lim4VRYcicmxtzQ+h1Fh/
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAmYFaRcACgkQAR8vZIA0
zr1USQf/ePJ/H3ZbaxXuaPYKSe9LvI3xfehs/BHhayjH/IDytSVl7jxEhqJLriGl
Eeaa/3s8p5Dv+P3chcDW9oaPdylamrkUDQQHhEMToDwFhgMTAb3BmzrWQhVyzE6r
/boTH4PJwWTbSIm5PBgl+7Pi4CzHSxqKo4Qm1FNzQEp/kjeGXM3ioRJp+SlPZL09
AY/77g2Ir/tOVuDP2on5m6G496EOeY2w/zwE4ELiqQD2xwEvRu58fETtb58X+cQj
B8bo6WDUvep5N4uS5kv+vJNRShPCQeydN+r530diGzeY3WLOncTfwc99tZM5u+Vi
WD9KHweC9ouEpITpVTnPC+FUr1/Kpw==
=FL86
-----END PGP SIGNATURE-----

--Sig_/i1lim4VRYcicmxtzQ+h1Fh/--