Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp445273lqh; Thu, 28 Mar 2024 06:52:51 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCWgNU7+HtFaxUsRTKS3e42DIIG5eQoVvS70tUFfG67rUvg0y96BqnKSmHMP6UnExqXt9azQi+e5mXWAmvLMpxvJVOu5j0rzbyKPxdLddw== X-Google-Smtp-Source: AGHT+IFwzz1+DJJjpWJfy2NnZYzWJunLC2dVWQMXX+zaLkVCFTwiymE4axaxIwC8y+Qr1BQw/vAy X-Received: by 2002:a05:6a00:1387:b0:6e6:b4f3:19dc with SMTP id t7-20020a056a00138700b006e6b4f319dcmr3279044pfg.7.1711633971406; Thu, 28 Mar 2024 06:52:51 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711633971; cv=pass; d=google.com; s=arc-20160816; b=NYTozp9YqwSnLbOQgIag9DDx/2Rhrv5/Dk4V15S05NM8Rvr9wcdFLrfGdNq0gnd58P l+wQzRrmlhx1UGcy/stoLEgkpfpAybBZlfkUx7CB7tYiwNkA73Xrxdjlf7aF4vyQShN0 xRdyYirZL8agJOYkXQq5FCoYofftv0ruEQNrRkn1sNdhYXMn95SoWBZJPHWDybRKVbn9 918p/9TxUToh17PNsAiB4XPNv6fU8a84qWFqb1YSFLxZNi1YMeUR1Iol+SrQ4Ixv2imf N5RfBcZvwM4b2DKyR5MHoXvk+O4SjziQMQNHuytcb4V2lCn1GxNDYXWztDfE5J2zXBX9 fzJw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=hJzM10F8UeQVL35/YaFyCs8OYR61pn71qwqEwN7zhfU=; fh=NbtzYSGyln1NBy3dwjrRwMhypQlB/UwbJ7oBc05rlIE=; b=okShWVZxSZWWrx36SvmG6nl7ICO+EkhbVWUiPRUrjbjVYCnOWMklWj5UWjVltTHiPJ SPaOYTbWVLdoEj8jvOZbKsWMlbw+HOiZgU9hoalPDhrVPExksyOSWayz0WdrtMTMzapR wuX/QrQBP/w6Rs5+J5tNYVSa+HsrY/ukj/eBhiWg2LOP9bb9gsPZlh42VGJ14JhLhZtK l4oT/fFBkSe0irizoXulxlyfBkGn/CVZoZCyqFEFTnRQ5iHLVKaULNfG9YQPyX52UXIE Yty0fR8aWF1ZDPkPV3dBxeY0xVzxP7023KQEqEip5bGxjeULdtmXklmSX7VZ3rNgNCox wwOA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iZ7l3BC4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-122995-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-122995-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id n2-20020a635c42000000b005dc87163f09si1420668pgm.392.2024.03.28.06.52.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 06:52:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-122995-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=iZ7l3BC4; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-122995-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-122995-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id F28BEB22CCF for ; Thu, 28 Mar 2024 13:52:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 99448823CB; Thu, 28 Mar 2024 13:52:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iZ7l3BC4" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8EEF1DFF2; Thu, 28 Mar 2024 13:51:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711633919; cv=none; b=roBjaAxp2ZiJ6XxxXm7OqnwA7l4LlSewfpT3eAVb2MSgxbUdaBW7OqwnFSFmsQdzcQ38qTZFQzuVdK96hqTxeAZkV7UfahB/4ndjVEouANuZfCbetLz67of9rvqh2xQLZSnwB1uR/M0HQVmXD5seCI/+44pyAfA2qI//Oaj3zpY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711633919; c=relaxed/simple; bh=26u9hTutRX6gyzhSopBxvNqZnd9SNWQgRgZYdO/+yxg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=sUiiKJa7Zv35vxZa/FVhUU3mf3+TcA6AQe+THtoOzyXK1nZQ1TXJPmMZdpoTuuTLlSv/tmNJG3zP463QnzkKfjCpYG0Djqm9BPUmSCHBiN5TeFr90FIIemgIAUZ0+GBDT592ByRlif3L6h3gEzboIfNB0uZfKjA+KrQbPN8u2YI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iZ7l3BC4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5365CC433F1; Thu, 28 Mar 2024 13:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711633919; bh=26u9hTutRX6gyzhSopBxvNqZnd9SNWQgRgZYdO/+yxg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=iZ7l3BC4RFLFjfD958z/Um8CFZJv87cNlRlI2Q68ynNI5q3ZWgso7zPVIi8TTsRbt x6ltTKqlH2ezgVxYqJdyHkgsf3MxwjsbzY8Ttwd7n232+ILqpSgEwThJ0XU3CVwOFb mG7lC9MPSEO74lcIJYE2eCCZkUP0h1DYU0Bl/rqN4RSdxlIO+JzDoCLfuC+MbsO0tr ERVYr0LkSOIGAwM+idaDlpuCOpkMbbaGnYUXbgoi9Q1jsn+Rvs2UVOGVfszjPb+9Ge 4KXetUBFBwBr4n8KynzSYgedrrPXwmCfKyXZzl5hrWyQpIePoh9+k4zzeySti9Pe8R I2knuWsLWI3bg== Date: Thu, 28 Mar 2024 13:51:40 +0000 From: Jonathan Cameron To: David Lechner Cc: Jonathan Corbet , Liam Girdwood , Mark Brown , Jean Delvare , Guenter Roeck , Support Opensource , Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Greg Kroah-Hartman , Dmitry Torokhov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-input@vger.kernel.org Subject: Re: [PATCH RFC 5/7] iio: frequency: admv1013: Use devm_regulator_get_enable_get_voltage() Message-ID: <20240328135140.7cb91163@jic23-huawei> In-Reply-To: <20240327-regulator-get-enable-get-votlage-v1-5-5f4517faa059@baylibre.com> References: <20240327-regulator-get-enable-get-votlage-v1-0-5f4517faa059@baylibre.com> <20240327-regulator-get-enable-get-votlage-v1-5-5f4517faa059@baylibre.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Mar 2024 18:18:54 -0500 David Lechner wrote: > We can reduce boilerplate code by using > devm_regulator_get_enable_get_voltage(). > > The common mode voltage is now passed as a parameter in the init > functions so we can avoid adding a state member that is only used > during init. > > Signed-off-by: David Lechner LGTM - on basis this might not go through my tree Reviewed-by: Jonathan Cameron