Received-SPF: pass (google.com: domain of linux-kernel+bounces-122996-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <3db9a68c6f71a67d95d25886fdc708de6269adc2.camel@gmail.com>
Subject: Re: [PATCH][next] iio: addac: ad74115: remove redundant if statement
From: Nuno =?ISO-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
To: Colin Ian King <colin.i.king@gmail.com>, Lars-Peter Clausen
 <lars@metafoo.de>, Michael Hennerich <Michael.Hennerich@analog.com>, Cosmin
 Tanislav <cosmin.tanislav@analog.com>, Jonathan Cameron <jic23@kernel.org>,
  linux-iio@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Date: Thu, 28 Mar 2024 14:52:43 +0100
In-Reply-To: <20240328112211.761618-1-colin.i.king@gmail.com>
References: <20240328112211.761618-1-colin.i.king@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.50.4 (3.50.4-1.fc39) 
Precedence: bulk
MIME-Version: 1.0

Hi Colin,

Thanks for your patch...

On Thu, 2024-03-28 at 11:22 +0000, Colin Ian King wrote:
> The if statement is redundant because the variable i being
> assigned in the statement is never read afterwards. Remove it.
>=20
> Cleans up clang scan build warning:
> drivers/iio/addac/ad74115.c:570:3: warning: Value stored to 'i'
> is never read [deadcode.DeadStores]
>=20
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> =C2=A0drivers/iio/addac/ad74115.c | 3 ---
> =C2=A01 file changed, 3 deletions(-)
>=20
> diff --git a/drivers/iio/addac/ad74115.c b/drivers/iio/addac/ad74115.c
> index e6bc5eb3788d..d31d4adb017e 100644
> --- a/drivers/iio/addac/ad74115.c
> +++ b/drivers/iio/addac/ad74115.c
> @@ -566,9 +566,6 @@ static int ad74115_set_comp_debounce(struct ad74115_s=
tate *st,
> unsigned int val)
> =C2=A0		if (val <=3D ad74115_debounce_tbl[i])
> =C2=A0			break;
> =C2=A0
> -	if (i =3D=3D len)
> -		i =3D len - 1;
> -

Hmm, this change is clearly good but I think we're actually missing the pro=
per fix in
here. I'm being lazy and not checking the datasheet and Cosmin can further =
comment.
But I'm fairly sure that the intent of the code is actually to use i in the=
 call to
regmap_update_bits(). I mean if we look at the mask AD74115_DIN_DEBOUNCE_MA=
SK and the
possible values of val...

- Nuno S=C3=A1