Received-SPF: pass (google.com: domain of linux-kernel+bounces-123046-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 28 Mar 2024 17:14:32 +0300
From: Dan Carpenter <dan.carpenter@linaro.org>
To: Nuno =?iso-8859-1?Q?S=E1?= <noname.nuno@gmail.com>
Cc: Colin Ian King <colin.i.king@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Cosmin Tanislav <cosmin.tanislav@analog.com>,
	Jonathan Cameron <jic23@kernel.org>, linux-iio@vger.kernel.org,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] iio: addac: ad74115: remove redundant if statement
Message-ID: <2b3d418d-55ee-4ca4-b6ae-bab441a76adf@moroto.mountain>
References: <20240328112211.761618-1-colin.i.king@gmail.com>
 <3db9a68c6f71a67d95d25886fdc708de6269adc2.camel@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3db9a68c6f71a67d95d25886fdc708de6269adc2.camel@gmail.com>

On Thu, Mar 28, 2024 at 02:52:43PM +0100, Nuno S? wrote:
> Hi Colin,
> 
> Thanks for your patch...
> 
> On Thu, 2024-03-28 at 11:22 +0000, Colin Ian King wrote:
> > The if statement is redundant because the variable i being
> > assigned in the statement is never read afterwards. Remove it.
> > 
> > Cleans up clang scan build warning:
> > drivers/iio/addac/ad74115.c:570:3: warning: Value stored to 'i'
> > is never read [deadcode.DeadStores]
> > 
> > Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> > ---
> > ?drivers/iio/addac/ad74115.c | 3 ---
> > ?1 file changed, 3 deletions(-)
> > 
> > diff --git a/drivers/iio/addac/ad74115.c b/drivers/iio/addac/ad74115.c
> > index e6bc5eb3788d..d31d4adb017e 100644
> > --- a/drivers/iio/addac/ad74115.c
> > +++ b/drivers/iio/addac/ad74115.c
> > @@ -566,9 +566,6 @@ static int ad74115_set_comp_debounce(struct ad74115_state *st,
> > unsigned int val)
> > ?		if (val <= ad74115_debounce_tbl[i])
> > ?			break;
> > ?
> > -	if (i == len)
> > -		i = len - 1;
> > -
> 
> Hmm, this change is clearly good but I think we're actually missing the proper fix in
> here. I'm being lazy and not checking the datasheet and Cosmin can further comment.
> But I'm fairly sure that the intent of the code is actually to use i in the call to
> regmap_update_bits(). I mean if we look at the mask AD74115_DIN_DEBOUNCE_MASK and the
> possible values of val...

Good eye.  I haven't looked at the datasheet either, but logically I
would think you go until you hit something that is too high and then
step back to the valid valies.  In other words the <= should be < and
the i = len - 1 should just be i--.

(The first element in the ad74115_debounce_tbl[] array is zero btw, so
it's never going to break with i == 0).

regards,
dan carpenter

diff --git a/drivers/iio/addac/ad74115.c b/drivers/iio/addac/ad74115.c
index e6bc5eb3788d..8d484cefe5ff 100644
--- a/drivers/iio/addac/ad74115.c
+++ b/drivers/iio/addac/ad74115.c
@@ -559,19 +559,16 @@ static void ad74115_gpio_set(struct gpio_chip *gc, unsigned int offset, int valu
 
 static int ad74115_set_comp_debounce(struct ad74115_state *st, unsigned int val)
 {
-	unsigned int len = ARRAY_SIZE(ad74115_debounce_tbl);
 	unsigned int i;
 
-	for (i = 0; i < len; i++)
-		if (val <= ad74115_debounce_tbl[i])
+	for (i = 0; i < ARRAY_SIZE(ad74115_debounce_tbl); i++)
+		if (ad74115_debounce_tbl[i] > val)
 			break;
-
-	if (i == len)
-		i = len - 1;
+	i--;
 
 	return regmap_update_bits(st->regmap, AD74115_DIN_CONFIG1_REG,
 				  AD74115_DIN_DEBOUNCE_MASK,
-				  FIELD_PREP(AD74115_DIN_DEBOUNCE_MASK, val));
+				  FIELD_PREP(AD74115_DIN_DEBOUNCE_MASK, ad74115_debounce_tbl[i]));
 }
 
 static int ad74115_comp_gpio_get_direction(struct gpio_chip *chip,