Received: by 2002:ab2:b82:0:b0:1f3:401:3cfb with SMTP id 2csp470853lqh; Thu, 28 Mar 2024 07:23:25 -0700 (PDT) X-Forwarded-Encrypted: i=3; AJvYcCVWN/2+htdX61dv7UV6dZ6FoycgtqKhkpg6xVgcZoy7EcEu3dCK5hFbfqeoBqvtnMlLUPaH2tI+njnFaWL5xxgiluthidBeomQz8tuo7A== X-Google-Smtp-Source: AGHT+IFcsej2o6KBml/ZVIWEDvJ2UiwShh87ZwMM+ibN5h3m434dwbQK/WyZ+8ZnKhPWR8xvF2iO X-Received: by 2002:a17:902:f78a:b0:1e2:a70:247e with SMTP id q10-20020a170902f78a00b001e20a70247emr3170843pln.18.1711635804838; Thu, 28 Mar 2024 07:23:24 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1711635804; cv=pass; d=google.com; s=arc-20160816; b=ppQ5B4RUlWOpav1/gkS38hDAhWqiwe52b0uyXbqklxTiABEqdeBE9etveJ13wOMAa0 ttbfguBs/JdFK22th4tzaM3GKNHI39ESVp4ynklmUnkVZo6dn+TglcZFYcRgTBAksRtA Zt7Mq99QSVbfVyK9qL81onFFre8OtFATsLlFi5TtglZVJziv1I1Rr8DQFyBNcE6+BJw0 t5/PS5gub5BhQrTboqrsh3FjToR0j0F1eGMEWuz/Cah99/U/hPymS7q5SiafZPYcrKnT TQ0ABvTFMITWRAahoSZyynMr3y4fOsnYFTvsl/nd9i84vqLs/cEf3vk8SG7lntb8y7Z4 nhfQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=HRsk3CRux7ZXA6iFHHiNHL9VI08fPi8fOzEOn7j7AzI=; fh=NbtzYSGyln1NBy3dwjrRwMhypQlB/UwbJ7oBc05rlIE=; b=Tpwv57FPhmRu1h3uer8GvEsehwzgZVNyMuhtfQyDcrRB1p6if55DSFBUsCcuplKiB3 9aIJ8SVqIPieyRJc+CTwmohZkI9Sp2AUlkrS7GaDTKHltq7n2G9Un2wbZPg/zkxqt0PX GR5FDXw2IGC1GGKWp7peKHdIz3utffPyu1D4fncIG4LkqqSif+U36kiMSVUU5361Kvx9 v1SFfjOUYWpyTbPmcWU+AXQ0sdmfKbSf98PxyyuUNJ3VBwA6Gr5wYEdfqJCQVcZXptMj 7PahoPR1tjEyIUmL9B0NiAHnKIRJFhurEz0jVW7giXULUiBUOiipmlbYh3AadwWWBl6d xN+A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qW+heum+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-123064-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123064-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id w15-20020a1709026f0f00b001e205f1c424si1443929plk.404.2024.03.28.07.23.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Mar 2024 07:23:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel+bounces-123064-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qW+heum+; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-123064-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-123064-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 2EE21B232B1 for ; Thu, 28 Mar 2024 14:22:25 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D2133127B47; Thu, 28 Mar 2024 14:22:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qW+heum+" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E09BF81AB1; Thu, 28 Mar 2024 14:22:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711635736; cv=none; b=UmDS0d6syVOWfqTsI3Hg7XMynDA4sg2Etk4DrNOfXMnWENTScAK+Z5xuObjmXH2Gos47NWgiVmNuTd2CJfcVmQ1zBAipTvl4wDg1urgKEDQOky0ulwNgZm5IZRYOEbMXOq6xnF0fI+1BBqqUCHOWe+LOt3Lxuqj6JKWATcPXVGk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711635736; c=relaxed/simple; bh=P56jOi+vB8F/gMU79xMGuZt5R/KzQ/6nNhG9zp3Tbzs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=pG+NC5wDUEg//PvFDfmP6DrCwQVmsPdCjskMv4RLCHI5CVKHnnLMXnIyu2KyymCkq/eqSTIkjP+c4XlAfPx+pKt3aNwzWM0TjkTF9n46cjkXziyQeTEGTppHZbflroTC/BGBQMCEpQzVHPg8Tb0J9iBVX4utiRbSIpagdlbhKUM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qW+heum+; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id B217DC433C7; Thu, 28 Mar 2024 14:22:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711635735; bh=P56jOi+vB8F/gMU79xMGuZt5R/KzQ/6nNhG9zp3Tbzs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qW+heum+mVGRg4Y8WD/6/b5KDOfVXXCaezVOK5N5kNlmQKXB+4xgq886lcXn+VCHZ nvtP+Jpzo3FgDgMkphAbyJNVdL2Btul4fMPChIBvEfxGkghWBpkyEFw0FwDa6Ls5ET OYJk/wXBKRia4xnvbG8q7ixE2E8WZO6/s0NvDBLS6Q9zfdslkT1SVYhNg/n/ACD3g5 iXw9neckqjuysP8U2VI8A/pZaiGzGFNZ7f6bFJuNzlxGoLTETp3JHR/dGXj0s5tRVh KULLcNWOKbBgyQCVa6rX7+MtEN0PdIGx1uFp8AN+j2HQXH4R8UAzk98CECzVVI6si0 jn5mqWWWk3nXw== Date: Thu, 28 Mar 2024 14:21:57 +0000 From: Jonathan Cameron To: David Lechner Cc: Jonathan Corbet , Liam Girdwood , Mark Brown , Jean Delvare , Guenter Roeck , Support Opensource , Cosmin Tanislav , Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Greg Kroah-Hartman , Dmitry Torokhov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-staging@lists.linux.dev, linux-input@vger.kernel.org Subject: Re: [PATCH RFC 7/7] Input: mpr121: Use devm_regulator_get_enable_get_voltage() Message-ID: <20240328142157.2165dc5d@jic23-huawei> In-Reply-To: <20240327-regulator-get-enable-get-votlage-v1-7-5f4517faa059@baylibre.com> References: <20240327-regulator-get-enable-get-votlage-v1-0-5f4517faa059@baylibre.com> <20240327-regulator-get-enable-get-votlage-v1-7-5f4517faa059@baylibre.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 27 Mar 2024 18:18:56 -0500 David Lechner wrote: > We can reduce boilerplate code by using > devm_regulator_get_enable_get_voltage(). > > Signed-off-by: David Lechner LGTM though you may want to bring an error message back if you drop the prints from the regulator functions. Reviewed-by: Jonathan Cameron